Modify

Opened 3 years ago

Last modified 8 days ago

#15240 new enhancement

transform gui icons to svg

Reported by: Klumbumbus Owned by: team
Priority: major Milestone: Longterm
Component: Core Version:
Keywords: svg png icon Cc:

Description (last modified by Klumbumbus)

Since we have an icon scaling on hidpi screens now (ticket:9995#comment:110) it would be nice to transform all icons to svg. Preset icons are already all svg (#13357)

Here are the current numbers: 60 svg icons and 270 png icons. This statistic excludes the folders images/presets, images/icons (only potlatch icons), our logo (which exists 6 times as png versions additionally to svg) and two special cases (lambert maps).



I think we could ask the osm community for help on this subject.

There are two possibilities:

  • transform the 270 png to svg
  • create a whole new icon set with an consistent look

For the second, there was already such an (not fully complete) dataset, see JOSM themes:






progress since creation of this ticket:

https://docs.google.com/spreadsheets/d/e/2PACX-1vTerX1bI5UhTzyxaK3NyyvnaQp6YvaqjFcn6AbvhMUFfjrEUnEjyYetQMAYtQ0SQ5_GipVbMucQ0tVn/pubchart
(numbers of svg icons not recorded between 09/2017 and 12/2019)

(typ:png in images folder minus 132 (124 potlatch + 6 logo + 2 embankment pattern) and typ:svg in images folder minus typ:svg in images/presets folder)

Attachments (87)

png_icons.png (161.2 KB) - added by Klumbumbus 3 years ago.
svg_icons.png (22.8 KB) - added by Klumbumbus 3 years ago.
black-red.jpg (5.6 KB) - added by Don-vip 3 years ago.
blue-red.jpg (6.4 KB) - added by Don-vip 3 years ago.
monochrome.jpg (4.9 KB) - added by Don-vip 3 years ago.
standart.jpg (5.1 KB) - added by Don-vip 3 years ago.
statusline-svg.patch (2.2 KB) - added by floscher 2 years ago.
Proposal for SVG icons for the status line
statusline.gif (53.3 KB) - added by floscher 2 years ago.
Animated comparison between the statusline icons (current and proposed)
statusline-before.png (1.4 KB) - added by floscher 2 years ago.
Current appearance of the statusline icons
statusline-after.png (1.2 KB) - added by floscher 2 years ago.
Proposed appearance of the statusline icons
anglesnap.svg (552 bytes) - added by floscher 2 years ago.
alignline.svg (443 bytes) - added by floscher 2 years ago.
black_x.svg (200 bytes) - added by floscher 2 years ago.
Replacement for misc/black_x.png
green_check.svg (477 bytes) - added by floscher 2 years ago.
Replacement for misc/green_check.png
green_check.2.svg (484 bytes) - added by floscher 2 years ago.
Replacement for misc/green_check.png
246png.png (152.2 KB) - added by Klumbumbus 2 years ago.
separator.svg (218 bytes) - added by floscher 2 years ago.
Replacement for preferences/separator.png
closedway.svg (311 bytes) - added by anonymous 2 years ago.
Replacement for data/closedway.png
multipolygon.svg (527 bytes) - added by floscher 2 years ago.
Replacement for data/multipolygon.png
node.svg (246 bytes) - added by floscher 2 years ago.
Replacement for data/node.png
sequence.svg (876 bytes) - added by floscher 2 years ago.
Replacement for data/sequence.png
way.svg (287 bytes) - added by floscher 2 years ago.
Replacement for data/way.png
separator.2.svg (225 bytes) - added by floscher 2 years ago.
Replacement for data/sequence.png
aligncircle.svg (326 bytes) - added by floscher 2 years ago.
Replacement for aligncircle.png
taginfo.svg (292 bytes) - added by floscher 2 years ago.
Replacement for dialogs/taginfo.png
aligncircle.2.svg (327 bytes) - added by floscher 2 years ago.
New version for aligncircle.png
apply.svg (485 bytes) - added by floscher 2 years ago.
Replacement for apply.png
gray_check.svg (485 bytes) - added by floscher 2 years ago.
Replacement for misc/gray_check.png
ti_jochen.png (101.2 KB) - added by stoecker 2 years ago.
TagInfo image from Jochen Topf
taginfo_preview.png (2.1 KB) - added by Don-vip 2 years ago.
taginfo.2.svg (615 bytes) - added by floscher 2 years ago.
Updated TagInfo logo with more contrast
taginfo_preview2.png (3.9 KB) - added by floscher 2 years ago.
Preview of the context menu with TagInfo logo
rectangle.svg (211 bytes) - added by floscher 2 years ago.
normal.svg (243 bytes) - added by floscher 2 years ago.
crosshair.2.svg (221 bytes) - added by floscher 2 years ago.
crosshair.svg (221 bytes) - added by floscher 2 years ago.
select_add.svg (446 bytes) - added by floscher 2 years ago.
selection.svg (384 bytes) - added by floscher 2 years ago.
select_node.svg (443 bytes) - added by floscher 2 years ago.
select_node_add.svg (505 bytes) - added by floscher 2 years ago.
select_node_remove.svg (487 bytes) - added by floscher 2 years ago.
select_remove.svg (428 bytes) - added by floscher 2 years ago.
select_way.svg (512 bytes) - added by floscher 2 years ago.
select_way_add.svg (574 bytes) - added by floscher 2 years ago.
select_way_remove.svg (556 bytes) - added by floscher 2 years ago.
close.svg (280 bytes) - added by floscher 7 months ago.
replacement for misc/close.png
combineway.svg (353 bytes) - added by floscher 7 months ago.
replacement for combineway.png
grey_x.svg (468 bytes) - added by floscher 7 months ago.
replacement for misc/grey_x.png
joinnodeway.svg (299 bytes) - added by floscher 7 months ago.
replacement for joinnodeway.png
minimized.svg (249 bytes) - added by floscher 7 months ago.
replacement for misc/minimized.png
normal.2.svg (252 bytes) - added by floscher 7 months ago.
replacement for misc/normal.png
rectangle.2.svg (478 bytes) - added by floscher 7 months ago.
replacement for misc/rectangle.png
reorder.svg (331 bytes) - added by floscher 7 months ago.
replacement for reorder.png
downloadalongtrack.svg (348 bytes) - added by floscher 7 months ago.
replacement for downloadalongtrack.png
download_along_way.svg (348 bytes) - added by floscher 7 months ago.
replacement for download_along_way.png
addnode.svg (279 bytes) - added by floscher 7 months ago.
add_node_lock.svg (398 bytes) - added by floscher 7 months ago.
create_note.svg (463 bytes) - added by floscher 7 months ago.
joinnode.svg (247 bytes) - added by floscher 7 months ago.
joinway.svg (275 bytes) - added by floscher 7 months ago.
lock.svg (258 bytes) - added by floscher 7 months ago.
mode.svg (300 bytes) - added by floscher 7 months ago.
parallel.svg (335 bytes) - added by floscher 7 months ago.
parallel_add.svg (411 bytes) - added by floscher 7 months ago.
parallel_remove.svg (391 bytes) - added by floscher 7 months ago.
audio-tracer.svg (137 bytes) - added by floscher 7 months ago.
Bridge.svg (207 bytes) - added by floscher 7 months ago.
Crossing.svg (172 bytes) - added by floscher 7 months ago.
addnote.svg (486 bytes) - added by floscher 7 months ago.
addsegment.svg (212 bytes) - added by floscher 7 months ago.
png_icons.2.png (232.9 KB) - added by floscher 7 months ago.
svg_icons.2.png (75.1 KB) - added by floscher 7 months ago.
toggledialogsframe.png (25.8 KB) - added by Klumbumbus 4 months ago.
josm_toggle_dialog_frame.png (71.6 KB) - added by skyper 4 months ago.
menu windows screenshot
frame.png (417 bytes) - added by Klumbumbus 4 months ago.
p2.svg (627 bytes) - added by Stereo 4 months ago.
Replaces resources/images/dialogs/mappaint/pl2_small.png
josm-all-png.PNG (401.2 KB) - added by Stereo 3 months ago.
PNG files in the JOSM source tree on 2020-03-30
Extrude.svg (1.4 KB) - added by Stereo 3 months ago.
Based off Tango's Applications-accessories, replacement for resources/images/mapmode/extrude/extrude.png
Upload.svg (13.2 KB) - added by Stereo 3 months ago.
Based of Gnome-document-save, replacement for resources/images/upload.png
Upload-selection.svg (13.3 KB) - added by Stereo 3 months ago.
Based of Gnome-document-save (see Upload.svg) and JOSM's way-select.svg, improved replacement for resources/images/uploadselection.png
overpass-api-small (1).svg (2.8 KB) - added by Stereo 3 months ago.
Based off Overpass API logo but with thicker lines, improved replacement for resources/images/download-overpass.png
qa.svg (931 bytes) - added by Stereo 3 months ago.
The blue validation checkmark is easily one of the ugliest icons in JOSM, but also one of the most recognisable ones. I've vectorised an improved, flatter one.
activate-down.svg (400 bytes) - added by Stereo 3 months ago.
Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/preferences/activate-down.png
activate-right.svg (396 bytes) - added by Stereo 3 months ago.
Same as activate_down but to replace ./resources/images/preferences/activate-right.png
useallleft.svg (757 bytes) - added by Stereo 3 months ago.
Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/dialogs/conflict/useallleft.png
useallright.svg (757 bytes) - added by Stereo 3 months ago.
Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/dialogs/conflict/useallright.png
Tower_dome.svg (806 bytes) - added by skyper 3 months ago.
[[JOSMImage(...)]] could be replaced with [[Image(...)]] osmwiki:File:Tower_dome.svg as the first does not look nice in preset menu

Download all attachments as: .zip

Change History (240)

Changed 3 years ago by Klumbumbus

Attachment: png_icons.png added

Changed 3 years ago by Klumbumbus

Attachment: svg_icons.png added

comment:1 Changed 3 years ago by Don-vip

Keywords: svg png icon added
Priority: normalmajor

comment:2 Changed 3 years ago by Klumbumbus

Description: modified (diff)

comment:3 in reply to:  description Changed 3 years ago by Don-vip

Replying to Klumbumbus:

For the second, there was already such an (not fully complete) dataset, see JOSM themes. Sadly the links and screenshoots in the forum are no longer available. Maybe we could recover them.

I remember very well. Felis was one of the finalists for the LogoContest and he almost won. It was really a hard thing to choose between the two final designs. I love what he did, too bad we can't have two logos :D

I just sent him an e-mail to let it know about this ticket.

comment:4 Changed 3 years ago by Felis Pimeja

FYI, as long as Dropbox has changed sharing mechanics, theme files are now available at:

https://drive.google.com/file/d/0BzTaubB85qV2cEFPcnA2UTBZbG8/view?usp=sharing

And I'm searching for the source files now.

comment:5 Changed 3 years ago by bastiK

Our current icons are partly based on the Tango icon theme, which has an svg set. See also GNOME set (based on Tango) with icons for download, delete and others.

comment:6 in reply to:  4 Changed 3 years ago by bastiK

Replying to Felis Pimeja:

FYI, as long as Dropbox has changed sharing mechanics, theme files are now available at:

https://drive.google.com/file/d/0BzTaubB85qV2cEFPcnA2UTBZbG8/view?usp=sharing

And I'm searching for the source files now.

Wow, it's pretty good! I like the black-red color scheme.

Changed 3 years ago by Don-vip

Attachment: black-red.jpg added

Changed 3 years ago by Don-vip

Attachment: blue-red.jpg added

Changed 3 years ago by Don-vip

Attachment: monochrome.jpg added

Changed 3 years ago by Don-vip

Attachment: standart.jpg added

comment:7 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:8 Changed 3 years ago by Don-vip

See also new default theme for Gnome 3: https://git.gnome.org/browse/adwaita-icon-theme/

comment:9 Changed 3 years ago by stoecker

The colorschemes like black-red do look good, but in my eyes they aren't good as the standard design. This should still be colorful (when possible with a bit more unified style :-).

comment:10 Changed 3 years ago by bastiK

How to move forward?

I noticed that some of the vector icons don't scale well down to very small sizes:

Current download icon (24x24px):
https://josm.openstreetmap.de/export/7668/josm/trunk/images/download.png
Scalable image, rendered at 48x48 px:
https://upload.wikimedia.org/wikipedia/commons/thumb/9/92/Gnome-document-save.svg/48px-Gnome-document-save.svg.png
Scalable image, rendered at 24x24 px
https://upload.wikimedia.org/wikipedia/commons/thumb/9/92/Gnome-document-save.svg/24px-Gnome-document-save.svg.png

Just replacing the current download.png by download.svg would be nice for HiDPI users, but clearly is a loss in image quality for everyone else. My conclusion so far is that some scalable images are designed with a certain minimum size in mind and will just look bad when scaled below that limit. This affects some icons more than others, the undo/redo image scales fine for example.

Possible solutions:

  • Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
  • Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

comment:11 in reply to:  10 ; Changed 2 years ago by Don-vip

Replying to bastiK:

Possible solutions:

  • Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
  • Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

I don't think we will succeed to find good SVG icons scalable to small sizes. It's already difficult enough to find a SVG version. This leaves only the second option.

comment:12 in reply to:  11 ; Changed 2 years ago by stoecker

Replying to Don-vip:

Replying to bastiK:

Possible solutions:

  • Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
  • Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

I don't think we will succeed to find good SVG icons scalable to small sizes. It's already difficult enough to find a SVG version. This leaves only the second option.

  • Change the icons, so that the vanishing elements (usually some sort of boundaries) are wider, so they don't vanish.

E.g. see point 7 here: ​https://www.creativebloq.com/how-to/10-golden-rules-for-responsive-svgs

comment:13 in reply to:  12 ; Changed 2 years ago by bastiK

Replying to stoecker:

Replying to Don-vip:

Replying to bastiK:

Possible solutions:

  • Find svg icons that scale well to 24x24 px (and decently well to 16x16 px for the menus).
  • Ship both the 24x24px "pixel art" and the .svg and use whatever image is better suited.

I don't think we will succeed to find good SVG icons scalable to small sizes. It's already difficult enough to find a SVG version. This leaves only the second option.

  • Change the icons, so that the vanishing elements (usually some sort of boundaries) are wider, so they don't vanish.

E.g. see point 7 here: ​https://www.creativebloq.com/how-to/10-golden-rules-for-responsive-svgs

This is more the job of a graphics designer that that of a programmer. Take the download icon posted above as an example: How can you modify the SVG without loss of quality in either the 24 px (top) or the 48 px rendering?

Anyway, if we implement option 2, it is still possible to improve the SVGs one by one, as suggested.

comment:14 in reply to:  13 Changed 2 years ago by stoecker

This is more the job of a graphics designer that that of a programmer. Take the download icon posted above as an example: How can you modify the SVG without loss of quality in either the 24 px (top) or the 48 px rendering?

Anyway, if we implement option 2, it is still possible to improve the SVGs one by one, as suggested.

Sure.

But the option 2 means a workaround which again will live MANY years. I personally would rather accept slightly worse low-zoom icons than another workaround.

comment:15 Changed 2 years ago by stoecker

P.S. We already had 24x24 menu icons. Maybe default simply should be 30x30 nowadays even for normal screens?

Changed 2 years ago by floscher

Attachment: statusline-svg.patch added

Proposal for SVG icons for the status line

Changed 2 years ago by floscher

Attachment: statusline.gif added

Animated comparison between the statusline icons (current and proposed)

comment:16 Changed 2 years ago by floscher

I propose to replace the icons in the statusline with SVG versions.
Below you see a comparison between the current icons (PNG, 18×18 pixels, scaled to 180×180), then how my proposed SVG icons look when converted to a 18×18 raster image scaled up to 180×180 pixels. And finally how the SVG icons look as 180×180 pixel image.
Animated comparison between the statusline icons (current and proposed)
(https://josm.openstreetmap.de/attachment/ticket/15240/statusline-svg.patch is the corresponding patch)

Changed 2 years ago by floscher

Attachment: statusline-before.png added

Current appearance of the statusline icons

Changed 2 years ago by floscher

Attachment: statusline-after.png added

Proposed appearance of the statusline icons

comment:17 Changed 2 years ago by floscher

Before:
Current appearance of the statusline icons
After:
Proposed appearance of the statusline icons

comment:18 Changed 2 years ago by stoecker

In 13363/josm:

see #15240 replace statusline png icons with svg variants by floscher, set mime-types for many images

comment:19 Changed 2 years ago by stoecker

No need to do such a impressive presentation. :) The new images and a before/after is enough. We plan to replace all PNG images anyway.

comment:20 Changed 2 years ago by Don-vip

Nice! thank you :)

comment:21 Changed 2 years ago by Hb---

References to the old PNG-files are still used in the wiki, please see https://josm.openstreetmap.de/wiki/Help/StatusBar
Wiki has been updated.

Last edited 2 years ago by Hb--- (previous) (diff)

comment:22 Changed 2 years ago by bastiK

In 13375/josm:

see #15240 - replace image for geoimage layer with svg version (from Tango icon project)

comment:23 Changed 2 years ago by stoecker

In 13376/josm:

see #15240 - set proper mime-type

comment:24 Changed 2 years ago by Klumbumbus

some icons replaced in #16159

Changed 2 years ago by floscher

Attachment: anglesnap.svg added

Changed 2 years ago by floscher

Attachment: alignline.svg added

Changed 2 years ago by floscher

Attachment: black_x.svg added

Replacement for misc/black_x.png

Changed 2 years ago by floscher

Attachment: green_check.svg added

Replacement for misc/green_check.png

Changed 2 years ago by floscher

Attachment: green_check.2.svg added

Replacement for misc/green_check.png

comment:25 Changed 2 years ago by floscher

Here are four more:
https://josm.openstreetmap.de/export/13612/josm/trunk/images/anglesnap.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/alignline.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/misc/black_x.png Replacement for misc/black_x.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/misc/green_check.png Replacement for misc/green_check.png

By the way: Can the icons dialogs/valid https://josm.openstreetmap.de/export/13612/josm/trunk/images/dialogs/valid.png and misc/check_large https://josm.openstreetmap.de/export/13612/josm/trunk/images/misc/check_large.png also be replaced by the checkmark above or is there a need for three different green checkmarks?

comment:26 Changed 2 years ago by stoecker

In 13613/josm:

see #15240 - new SVG icons

comment:27 Changed 2 years ago by stoecker

I didn't replace misc/check_large. It is used in the upload dialog and I'd say it looks better there than the boxy green_check.

comment:28 Changed 2 years ago by Klumbumbus

interim result: 246 png icons left :)

Changed 2 years ago by Klumbumbus

Attachment: 246png.png added

comment:29 Changed 2 years ago by stoecker

Hmm, are sure that's right? The green check is svg and the large is missing and some icons are in two sizes and 3 blue checkmarks?

comment:30 Changed 2 years ago by stoecker

BTW The WMS/TMS related icons are all ugly.

Better ones would be fine.

comment:31 Changed 2 years ago by Klumbumbus

It seems you accidently moved the large green check to nodist instead of source:trunk/images/misc/green_check.png.

comment:32 Changed 2 years ago by Klumbumbus

in the screenshot I scaled all icons to 24px. multiple icons appear when there are different sizes available, e.g. source:trunk/images/imagery_menu.pngsource:trunk/images/imagery_small.pngsource:trunk/images/preferences/imagery.png source:trunk/images/dialogs/validator.pngsource:trunk/images/layer/validator_small.pngsource:trunk/images/preferences/validator.png

should be unified when replayed by svg

comment:33 Changed 2 years ago by Klumbumbus

Code of the screenshot. Can be used here in wiki with comment preview feature. (But takes a bit to load all images which is why I made the screenshot)

[[Image(source:trunk/images/addmarkers.png,24)]][[Image(source:trunk/images/aligncircle.png,24)]][[Image(source:trunk/images/apply.png,24)]][[Image(source:trunk/images/bug.png,24)]][[Image(source:trunk/images/cancel.png,24)]][[Image(source:trunk/images/clock.png,24)]][[Image(source:trunk/images/closechangeset.png,24)]][[Image(source:trunk/images/colorchooser.png,24)]][[Image(source:trunk/images/combineway.png,24)]][[Image(source:trunk/images/converttogpx.png,24)]][[Image(source:trunk/images/converttoosm.png,24)]][[Image(source:trunk/images/copy.png,24)]][[Image(source:trunk/images/distribute.png,24)]][[Image(source:trunk/images/download-overpass.png,24)]][[Image(source:trunk/images/download.png,24)]][[Image(source:trunk/images/downloadalongtrack.png,24)]][[Image(source:trunk/images/downloadprimitive.png,24)]][[Image(source:trunk/images/download_in_view.png,24)]][[Image(source:trunk/images/duplicate.png,24)]][[Image(source:trunk/images/exit.png,24)]][[Image(source:trunk/images/expert.png,24)]][[Image(source:trunk/images/exportgpx.png,24)]][[Image(source:trunk/images/eye.png,24)]][[Image(source:trunk/images/help.png,24)]][[Image(source:trunk/images/imagery_menu.png,24)]][[Image(source:trunk/images/imagery_small.png,24)]][[Image(source:trunk/images/importaudio.png,24)]][[Image(source:trunk/images/info.png,24)]][[Image(source:trunk/images/java.png,24)]][[Image(source:trunk/images/joinnodeway.png,24)]][[Image(source:trunk/images/movenode.png,24)]][[Image(source:trunk/images/movenodeontoway.png,24)]][[Image(source:trunk/images/new.png,24)]][[Image(source:trunk/images/note_search.png,24)]][[Image(source:trunk/images/ok.png,24)]][[Image(source:trunk/images/open.png,24)]][[Image(source:trunk/images/openlocation.png,24)]][[Image(source:trunk/images/openrecent.png,24)]][[Image(source:trunk/images/paste.png,24)]][[Image(source:trunk/images/pastetags.png,24)]][[Image(source:trunk/images/preference.png,24)]][[Image(source:trunk/images/purge.png,24)]][[Image(source:trunk/images/redo.png,24)]][[Image(source:trunk/images/reorder.png,24)]][[Image(source:trunk/images/restart.png,24)]][[Image(source:trunk/images/save.png,24)]][[Image(source:trunk/images/save_as.png,24)]][[Image(source:trunk/images/simplify.png,24)]][[Image(source:trunk/images/splitway.png,24)]][[Image(source:trunk/images/undo.png,24)]][[Image(source:trunk/images/unglueways.png,24)]][[Image(source:trunk/images/updatedata.png,24)]][[Image(source:trunk/images/upload.png,24)]][[Image(source:trunk/images/uploadselection.png,24)]][[Image(source:trunk/images/view-fullscreen-revert.png,24)]][[Image(source:trunk/images/view-fullscreen.png,24)]][[Image(source:trunk/images/warning-small.png,24)]][[Image(source:trunk/images/wayflip.png,24)]][[Image(source:trunk/images/cursor/crosshair.png,24)]][[Image(source:trunk/images/cursor/hand.png,24)]][[Image(source:trunk/images/cursor/normal.png,24)]][[Image(source:trunk/images/cursor/rotate.png,24)]][[Image(source:trunk/images/cursor/scale.png,24)]][[Image(source:trunk/images/cursor/modifier/addnode.png,24)]][[Image(source:trunk/images/cursor/modifier/add_node_lock.png,24)]][[Image(source:trunk/images/cursor/modifier/create_note.png,24)]][[Image(source:trunk/images/cursor/modifier/delete.png,24)]][[Image(source:trunk/images/cursor/modifier/delete_node.png,24)]][[Image(source:trunk/images/cursor/modifier/delete_segment.png,24)]][[Image(source:trunk/images/cursor/modifier/delete_way_node_only.png,24)]][[Image(source:trunk/images/cursor/modifier/delete_way_normal.png,24)]][[Image(source:trunk/images/cursor/modifier/delete_way_only.png,24)]][[Image(source:trunk/images/cursor/modifier/joinnode.png,24)]][[Image(source:trunk/images/cursor/modifier/joinway.png,24)]][[Image(source:trunk/images/cursor/modifier/lock.png,24)]][[Image(source:trunk/images/cursor/modifier/mode.png,24)]][[Image(source:trunk/images/cursor/modifier/move.png,24)]][[Image(source:trunk/images/cursor/modifier/parallel.png,24)]][[Image(source:trunk/images/cursor/modifier/parallel_add.png,24)]][[Image(source:trunk/images/cursor/modifier/parallel_remove.png,24)]][[Image(source:trunk/images/cursor/modifier/rectangle.png,24)]][[Image(source:trunk/images/cursor/modifier/rectangle_move.png,24)]][[Image(source:trunk/images/cursor/modifier/rectangle_plus.png,24)]][[Image(source:trunk/images/cursor/modifier/rectangle_plussmall.png,24)]][[Image(source:trunk/images/cursor/modifier/rope.png,24)]][[Image(source:trunk/images/cursor/modifier/selection.png,24)]][[Image(source:trunk/images/cursor/modifier/select_add.png,24)]][[Image(source:trunk/images/cursor/modifier/select_node.png,24)]][[Image(source:trunk/images/cursor/modifier/select_node_add.png,24)]][[Image(source:trunk/images/cursor/modifier/select_node_remove.png,24)]][[Image(source:trunk/images/cursor/modifier/select_remove.png,24)]][[Image(source:trunk/images/cursor/modifier/select_way.png,24)]][[Image(source:trunk/images/cursor/modifier/select_way_add.png,24)]][[Image(source:trunk/images/cursor/modifier/select_way_remove.png,24)]][[Image(source:trunk/images/cursor/modifier/zoom.png,24)]][[Image(source:trunk/images/data/closedway.png,24)]][[Image(source:trunk/images/data/error.png,24)]][[Image(source:trunk/images/data/key.png,24)]][[Image(source:trunk/images/data/multipolygon.png,24)]][[Image(source:trunk/images/data/node.png,24)]][[Image(source:trunk/images/data/object.png,24)]][[Image(source:trunk/images/data/other.png,24)]][[Image(source:trunk/images/data/purge.png,24)]][[Image(source:trunk/images/data/relation.png,24)]][[Image(source:trunk/images/data/sequence.png,24)]][[Image(source:trunk/images/data/user.png,24)]][[Image(source:trunk/images/data/warning.png,24)]][[Image(source:trunk/images/data/way.png,24)]][[Image(source:trunk/images/dialogs/add.png,24)]][[Image(source:trunk/images/dialogs/addrelation.png,24)]][[Image(source:trunk/images/dialogs/add_tms.png,24)]][[Image(source:trunk/images/dialogs/add_wms.png,24)]][[Image(source:trunk/images/dialogs/add_wmts.png,24)]][[Image(source:trunk/images/dialogs/bookmark-new.png,24)]][[Image(source:trunk/images/dialogs/bookmark.png,24)]][[Image(source:trunk/images/dialogs/centreview.png,24)]][[Image(source:trunk/images/dialogs/commandstack.png,24)]][[Image(source:trunk/images/dialogs/conflict.png,24)]][[Image(source:trunk/images/dialogs/delete.png,24)]][[Image(source:trunk/images/dialogs/down.png,24)]][[Image(source:trunk/images/dialogs/downloadincomplete.png,24)]][[Image(source:trunk/images/dialogs/duplicatelayer.png,24)]][[Image(source:trunk/images/dialogs/edit.png,24)]][[Image(source:trunk/images/dialogs/filter.png,24)]][[Image(source:trunk/images/dialogs/fix.png,24)]][[Image(source:trunk/images/dialogs/history.png,24)]][[Image(source:trunk/images/dialogs/layerlist.png,24)]][[Image(source:trunk/images/dialogs/mappaintpreference.png,24)]][[Image(source:trunk/images/dialogs/mergedown.png,24)]][[Image(source:trunk/images/dialogs/minimap.png,24)]][[Image(source:trunk/images/dialogs/movedown.png,24)]][[Image(source:trunk/images/dialogs/moveup.png,24)]][[Image(source:trunk/images/dialogs/next.png,24)]][[Image(source:trunk/images/dialogs/pin.png,24)]][[Image(source:trunk/images/dialogs/previous.png,24)]][[Image(source:trunk/images/dialogs/refresh.png,24)]][[Image(source:trunk/images/dialogs/relationlist.png,24)]][[Image(source:trunk/images/dialogs/search.png,24)]][[Image(source:trunk/images/dialogs/select.png,24)]][[Image(source:trunk/images/dialogs/selectionlist.png,24)]][[Image(source:trunk/images/dialogs/settings.png,24)]][[Image(source:trunk/images/dialogs/showhide.png,24)]][[Image(source:trunk/images/dialogs/sort.png,24)]][[Image(source:trunk/images/dialogs/sort_below.png,24)]][[Image(source:trunk/images/dialogs/taginfo.png,24)]][[Image(source:trunk/images/dialogs/up.png,24)]][[Image(source:trunk/images/dialogs/uploadproperties.png,24)]][[Image(source:trunk/images/dialogs/userlist.png,24)]][[Image(source:trunk/images/dialogs/validator.png,24)]][[Image(source:trunk/images/dialogs/zoom-best-fit.png,24)]][[Image(source:trunk/images/dialogs/zoomin.png,24)]][[Image(source:trunk/images/dialogs/zoomout.png,24)]][[Image(source:trunk/images/dialogs/autoscale/conflict.png,24)]][[Image(source:trunk/images/dialogs/autoscale/data.png,24)]][[Image(source:trunk/images/dialogs/autoscale/download.png,24)]][[Image(source:trunk/images/dialogs/autoscale/layer.png,24)]][[Image(source:trunk/images/dialogs/autoscale/next.png,24)]][[Image(source:trunk/images/dialogs/autoscale/previous.png,24)]][[Image(source:trunk/images/dialogs/autoscale/problem.png,24)]][[Image(source:trunk/images/dialogs/autoscale/selection.png,24)]][[Image(source:trunk/images/dialogs/conflict/useallleft.png,24)]][[Image(source:trunk/images/dialogs/conflict/useallright.png,24)]][[Image(source:trunk/images/dialogs/geoimage/deletefromdisk.png,24)]][[Image(source:trunk/images/dialogs/geoimage/gpx2img.png,24)]][[Image(source:trunk/images/dialogs/geoimage/photo-marker-selected.png,24)]][[Image(source:trunk/images/dialogs/geoimage/photo-marker.png,24)]][[Image(source:trunk/images/dialogs/geoimage/togglegit.png,24)]][[Image(source:trunk/images/dialogs/layerlist/active-pressed.png,24)]][[Image(source:trunk/images/dialogs/layerlist/active.png,24)]][[Image(source:trunk/images/dialogs/layerlist/blank.png,24)]][[Image(source:trunk/images/dialogs/layerlist/colorfulness.png,24)]][[Image(source:trunk/images/dialogs/layerlist/eye-off.png,24)]][[Image(source:trunk/images/dialogs/layerlist/eye-pressed.png,24)]][[Image(source:trunk/images/dialogs/layerlist/eye-translucent.png,24)]][[Image(source:trunk/images/dialogs/layerlist/eye.png,24)]][[Image(source:trunk/images/dialogs/layerlist/gamma.png,24)]][[Image(source:trunk/images/dialogs/layerlist/offset.png,24)]][[Image(source:trunk/images/dialogs/layerlist/sharpness.png,24)]][[Image(source:trunk/images/dialogs/layerlist/transparency.png,24)]][[Image(source:trunk/images/dialogs/layerlist/visibility.png,24)]][[Image(source:trunk/images/dialogs/mappaint/pencil.png,24)]][[Image(source:trunk/images/dialogs/mappaint/pl2_small.png,24)]][[Image(source:trunk/images/dialogs/notes/note_closed.png,24)]][[Image(source:trunk/images/dialogs/notes/note_comment.png,24)]][[Image(source:trunk/images/dialogs/notes/note_new.png,24)]][[Image(source:trunk/images/dialogs/notes/note_open.png,24)]][[Image(source:trunk/images/dialogs/relation/arrowdown.png,24)]][[Image(source:trunk/images/dialogs/relation/arrowup.png,24)]][[Image(source:trunk/images/dialogs/relation/downloadincomplete.png,24)]][[Image(source:trunk/images/dialogs/relation/downloadincompleteselected.png,24)]][[Image(source:trunk/images/dialogs/relation/reverse.png,24)]][[Image(source:trunk/images/dialogs/relation/roundabout_left_tiny.png,24)]][[Image(source:trunk/images/dialogs/relation/roundabout_right_tiny.png,24)]][[Image(source:trunk/images/dialogs/relation/roundedcorners.png,24)]][[Image(source:trunk/images/help/home.png,24)]][[Image(source:trunk/images/help/internet.png,24)]][[Image(source:trunk/images/help/next.png,24)]][[Image(source:trunk/images/help/previous.png,24)]][[Image(source:trunk/images/layer/gpx_small.png,24)]][[Image(source:trunk/images/layer/marker_small.png,24)]][[Image(source:trunk/images/layer/osmdata_small.png,24)]][[Image(source:trunk/images/layer/validator_small.png,24)]][[Image(source:trunk/images/mapmode/addnote.png,24)]][[Image(source:trunk/images/mapmode/addsegment.png,24)]][[Image(source:trunk/images/mapmode/adjustimg.png,24)]][[Image(source:trunk/images/mapmode/delete.png,24)]][[Image(source:trunk/images/mapmode/improvewayaccuracy.png,24)]][[Image(source:trunk/images/mapmode/playheaddrag.png,24)]][[Image(source:trunk/images/mapmode/rope.png,24)]][[Image(source:trunk/images/mapmode/zoom.png,24)]][[Image(source:trunk/images/mapmode/extrude/dualalign.png,24)]][[Image(source:trunk/images/mapmode/extrude/extrude.png,24)]][[Image(source:trunk/images/mapmode/move/move.png,24)]][[Image(source:trunk/images/mapmode/node/autonode.png,24)]][[Image(source:trunk/images/markers/audio-tracer.png,24)]][[Image(source:trunk/images/markers/Bridge.png,24)]][[Image(source:trunk/images/markers/Crossing.png,24)]][[Image(source:trunk/images/markers/photo.png,24)]][[Image(source:trunk/images/markers/speech.png,24)]][[Image(source:trunk/images/markers/web.png,24)]][[Image(source:trunk/images/misc/buttonhide.png,24)]][[Image(source:trunk/images/misc/buttonshow.png,24)]][[Image(source:trunk/images/misc/close.png,24)]][[Image(source:trunk/images/misc/gray_check.png,24)]][[Image(source:trunk/images/misc/green_check.png,24)]][[Image(source:trunk/images/misc/grey_x.png,24)]][[Image(source:trunk/images/misc/minimized.png,24)]][[Image(source:trunk/images/misc/normal.png,24)]][[Image(source:trunk/images/misc/rectangle.png,24)]][[Image(source:trunk/images/misc/sticky.png,24)]][[Image(source:trunk/images/preferences/activate-down.png,24)]][[Image(source:trunk/images/preferences/activate-right.png,24)]][[Image(source:trunk/images/preferences/advanced.png,24)]][[Image(source:trunk/images/preferences/audio.png,24)]][[Image(source:trunk/images/preferences/connection.png,24)]][[Image(source:trunk/images/preferences/display.png,24)]][[Image(source:trunk/images/preferences/imagery.png,24)]][[Image(source:trunk/images/preferences/map.png,24)]][[Image(source:trunk/images/preferences/plugin.png,24)]][[Image(source:trunk/images/preferences/remotecontrol.png,24)]][[Image(source:trunk/images/preferences/reset.png,24)]][[Image(source:trunk/images/preferences/separator.png,24)]][[Image(source:trunk/images/preferences/shortcuts.png,24)]][[Image(source:trunk/images/preferences/toolbar.png,24)]][[Image(source:trunk/images/preferences/validator.png,24)]][[Image(source:trunk/images/statusline/name.png,24)]]

comment:34 in reply to:  31 Changed 2 years ago by stoecker

Replying to Klumbumbus:

It seems you accidently moved the large green check to nodist instead of source:trunk/images/misc/green_check.png.

Ooops. Can someone please fix this before next build?

comment:35 Changed 2 years ago by Klumbumbus

could be a meme: JOSM user level expert: knows the difference between the upload icon and the upload selection icon
source:trunk/images/upload.pngsource:trunk/images/uploadselection.png

Last edited 2 years ago by Klumbumbus (previous) (diff)

comment:36 Changed 2 years ago by Klumbumbus

In 13615/josm:

see #15240 - fix moved icons

comment:37 in reply to:  35 Changed 2 years ago by Don-vip

Replying to Klumbumbus:

could be a meme: JOSM user level expert: knows the difference between the upload icon and the upload selection icon
source:trunk/images/upload.pngsource:trunk/images/uploadselection.png

hahaha :D

Changed 2 years ago by floscher

Attachment: separator.svg added

Replacement for preferences/separator.png

Changed 2 years ago by anonymous

Attachment: closedway.svg added

Replacement for data/closedway.png

Changed 2 years ago by floscher

Attachment: multipolygon.svg added

Replacement for data/multipolygon.png

Changed 2 years ago by floscher

Attachment: node.svg added

Replacement for data/node.png

Changed 2 years ago by floscher

Attachment: sequence.svg added

Replacement for data/sequence.png

Changed 2 years ago by floscher

Attachment: way.svg added

Replacement for data/way.png

Changed 2 years ago by floscher

Attachment: separator.2.svg added

Replacement for data/sequence.png

Changed 2 years ago by floscher

Attachment: aligncircle.svg added

Replacement for aligncircle.png

Changed 2 years ago by floscher

Attachment: taginfo.svg added

Replacement for dialogs/taginfo.png

comment:38 Changed 2 years ago by floscher

And some more:
https://josm.openstreetmap.de/export/13612/josm/trunk/images/preferences/separator.pngReplacement for data/sequence.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/data/closedway.pngReplacement for data/closedway.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/data/multipolygon.pngReplacement for data/multipolygon.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/data/node.pngReplacement for data/node.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/data/sequence.pngReplacement for data/sequence.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/data/way.pngReplacement for data/way.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/dialogs/taginfo.pngReplacement for dialogs/taginfo.png
https://josm.openstreetmap.de/export/13612/josm/trunk/images/aligncircle.pngReplacement for aligncircle.png

The last one I changed, because the line around really should be the circle (I think), not the ways connecting the nodes. So I changed the color (if you want some other color, we could change it). And I made the points more irregular to emphasize that the nodes are not evenly distributed around a circle, but only moved to the closest point on a circle.

comment:39 Changed 2 years ago by stoecker

Hmm. taginfo does still not look nice. It's the website favicon, but looks ugly. Adding the world logo from the website behind the ti?

comment:40 in reply to:  39 Changed 2 years ago by anonymous

Replying to stoecker:

Hmm. taginfo does still not look nice. It's the website favicon, but looks ugly. Adding the world logo from the website behind the ti?

Don't know if that would work at this resolution (16x16). Probably has to be something simpler.

comment:41 Changed 2 years ago by Don-vip

Maybe just frame it with something like https://png.icons8.com/metro/50/000000/note.png

comment:42 Changed 2 years ago by stoecker

Or let the t look a bit like a "tag"?

comment:43 Changed 2 years ago by stoecker

https://www.google.de/search?q=icon+tag
They all have a hole inside.
Or simply such a tag with an i or ti inside. When we have something better we'd need to ask Jochen if he likes it.

comment:44 Changed 2 years ago by Klumbumbus

Or we pixel align the current taginfo icon a bit to make it look a bit sharper.

Regarding https://josm.openstreetmap.de/export/13612/josm/trunk/images/aligncircle.pngReplacement for aligncircle.png I agree that there should be a circle in the icon instead of a pentagon to better illustrate the align in circle action. However the irregular pattern destroys this illustration again a bit in my opinion. And if you select a way and hit O then the nodes are indeed evenly distributed. The thin light green is pretty hard to recognize on a light background too.

Currently Help/Action/AlignInCircle and Help/Action/CreateCircle use the same icon. While the align action works on single nodes too, the create action always creates a way, so probably the black way lines shouldn't be removed from the create action icon.

My suggestion (but I didn't test how it looks): a circle and even distributed nodes for both icons; for the create action the circle is black and for the align action grey or another color (but a bit darker than the light green).

Changed 2 years ago by floscher

Attachment: aligncircle.2.svg added

New version for aligncircle.png

comment:45 Changed 2 years ago by floscher

Here's my draft for an alternative TagInfo logo:
Updated TagInfo logo with more contrast

And another version of aligncircle: New version for aligncircle.png.

@Klumbumbus: Actually it depends on what you select if the nodes distribute equally around the circle: When selecting a way, they do. When selecting only the nodes, they do not distribute evenly around the circle. I thought they were always only jumping to their nearest position on the circle, but it seems to be more complicated.
Anyway, I now changed the icon to show evenly distributed nodes, also for aesthetic reasons. Also the color is now grey. I think a second version in black would be too much, especially because they are too similar… Not that in the end your joke about the download icons really becomes a meme 😉

comment:46 in reply to:  45 ; Changed 2 years ago by stoecker

Replying to floscher:

Here's my draft for an alternative TagInfo logo:

I contacted Jochen and asked for his opinion.

comment:47 Changed 2 years ago by stoecker

In 13630/josm:

see #15240 - new SVG icons made by floscher

Changed 2 years ago by floscher

Attachment: apply.svg added

Replacement for apply.png

comment:48 Changed 2 years ago by Klumbumbus

(replacement for gray_check.png source:trunk/images/misc/gray_check.png can be derived from the green and blue one too)

Changed 2 years ago by floscher

Attachment: gray_check.svg added

Replacement for misc/gray_check.png

comment:49 Changed 2 years ago by floscher

You might consider renaming gray_check.svg to grey_check.svg. Next to it there is the file grey_x.png, which uses the other spelling.

comment:50 Changed 2 years ago by Hb---

On Plugins the images /browser/trunk/images/misc/black_x.png and ../green_check.png are missing now.

They are placed by a script in the last column to indicate if a plugin needs a restart. The alt parameters for the images are localized. This script needs to be modified.

Replacing the former PNG images with their SVG counterparts will make the page display in the Help Browser worse, because that Browser can't properly resize images currently. Simple characters like ✓ and ✕ may give the same information.

comment:51 in reply to:  50 ; Changed 2 years ago by Klumbumbus

Did someone fix this already? The icons are displayed fine for me. (I remember that i fixed wiki:JavaBugs and wiki:OldJavaBugs 5 weeks ago and I think that the Plugins page was already working fine a that point.)

Replying to Hb---:

Replacing the former PNG images with their SVG counterparts will make the page display in the Help Browser worse, because that Browser can't properly resize images currently.

That shouldn't be a problem anyway in this case as these two icons have a small base size and shouldn't be resized.

Last edited 2 years ago by Klumbumbus (previous) (diff)

comment:52 in reply to:  51 Changed 2 years ago by stoecker

Replying to Klumbumbus:

Did someone fix this already?

Yes.

comment:53 Changed 2 years ago by Don-vip

In 13832/josm:

fix #5603, see #5256, see #15240 - add first/last buttons for geoimage dialog. Fixed shortcuts. Switch to SVG icons taken from https://commons.wikimedia.org/wiki/GNOME_Desktop_icons#Navigation

comment:54 Changed 2 years ago by Don-vip

In 13837/josm:

see #15240 - convert more GNOME icons to SVG versions. Taken from https://commons.wikimedia.org/wiki/Category:GNOME_Desktop_icons

comment:55 Changed 2 years ago by Klumbumbus

duplicate icons:
source:trunk/images/help/previous.svgsource:trunk/images/dialogs/previous.svg
source:trunk/images/help/next.svgsource:trunk/images/dialogs/next.svg

Last edited 2 years ago by Klumbumbus (previous) (diff)

comment:56 Changed 2 years ago by Don-vip

In 13844/josm:

see #15240 - remove duplicated icons

comment:57 in reply to:  46 Changed 2 years ago by Don-vip

Replying to stoecker:

I contacted Jochen and asked for his opinion.

any news?

comment:58 Changed 2 years ago by Don-vip

Another thing: the icon warnings scripts says bookmark.svg is not used, but it is:

        static ImageIcon getDefaultIcon() {
            return ImageProvider.get("dialogs", "bookmark", ImageSizes.SMALLICON);
        }

Changed 2 years ago by stoecker

Attachment: ti_jochen.png added

TagInfo image from Jochen Topf

comment:59 Changed 2 years ago by stoecker

TagInfo image from Jochen Topf

Jochen sent me this image which he also uses (which is to large for our purpose), but didn't answer whether he likes or does not like the small icon.

I'd say we simply use floscher's icon in JOSM.

comment:60 Changed 2 years ago by stoecker

In 13857/josm:

see #15240 - detect another type of ImageProvider calls for in image check script

Changed 2 years ago by Don-vip

Attachment: taginfo_preview.png added

comment:61 Changed 2 years ago by Don-vip

It's nice but the contrast should be increased, it's hard to view the tag on grey background:


Changed 2 years ago by floscher

Attachment: taginfo.2.svg added

Updated TagInfo logo with more contrast

Changed 2 years ago by floscher

Attachment: taginfo_preview2.png added

Preview of the context menu with TagInfo logo

comment:62 Changed 2 years ago by floscher

Should now be better:
Updated TagInfo logo with more contrast
Preview of the context menu with TagInfo logo

comment:63 Changed 2 years ago by Don-vip

In 13860/josm:

see #15240 - use new taginfo icon (by floscher)

comment:64 Changed 2 years ago by Klumbumbus

In 13862/josm:

see #15240 - new SVG icons made by floscher

comment:65 Changed 2 years ago by Klumbumbus

In 13863/josm:

see #15240 - add svg mime type

Changed 2 years ago by floscher

Attachment: rectangle.svg added

Changed 2 years ago by floscher

Attachment: normal.svg added

comment:66 Changed 2 years ago by floscher

Replacements for some icons in the directory images/cursor/modifier:
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/rectangle.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_add.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/selection.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node_add.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node_remove.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_remove.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_way.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_way_add.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_way_remove.png

As well as these two in images/cursor:
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/crosshair.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/normal.png

Last edited 2 years ago by Don-vip (previous) (diff)

Changed 2 years ago by floscher

Attachment: crosshair.2.svg added

Changed 2 years ago by floscher

Attachment: crosshair.svg added

comment:67 Changed 2 years ago by Don-vip

In 13871/josm:

see #15240 - switch 12 cursor icons to SVG (by floscher)

comment:68 Changed 2 years ago by Klumbumbus

Did you accidently not pixel align the red node symbols at these three icons?

https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node_add.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node_remove.png

Changed 2 years ago by floscher

Attachment: select_add.svg added

Changed 2 years ago by floscher

Attachment: selection.svg added

Changed 2 years ago by floscher

Attachment: select_node.svg added

Changed 2 years ago by floscher

Attachment: select_node_add.svg added

Changed 2 years ago by floscher

Attachment: select_node_remove.svg added

Changed 2 years ago by floscher

Attachment: select_remove.svg added

Changed 2 years ago by floscher

Attachment: select_way.svg added

Changed 2 years ago by floscher

Attachment: select_way_add.svg added

Changed 2 years ago by floscher

Attachment: select_way_remove.svg added

comment:69 in reply to:  68 Changed 2 years ago by floscher

Replying to Klumbumbus:

Did you accidently not pixel align the red node symbols at these three icons?

https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node_add.png
https://josm.openstreetmap.de/export/13870/josm/trunk/images/cursor/modifier/select_node_remove.png

Yes, good catch, thank you! I corrected the icons. And I also made a small modification to the other select-modifiers, which shouldn't change the appearance in JOSM, but in some image viewing programs (e.g. Gimp) the dashed line should display correctly.

comment:70 Changed 2 years ago by Klumbumbus

In 13874/josm:

see #15240 - update 9 SVG icons made by floscher, add svg mime type

comment:71 Changed 2 years ago by Don-vip

@bastiK @michael2402 The test MapCSSRendererTest.testRender[area-fill-image] is both failing and slower on Jenkins since r13862, could you please have a look? Surprisingly the test is OK on my machine.

comment:72 Changed 2 years ago by Klumbumbus

Description: modified (diff)

add progress chart to ticket description, little motivation ;)

comment:73 in reply to:  71 Changed 2 years ago by Don-vip

@bastiK @michael2402

up? Is the test failing for you?

comment:74 Changed 2 years ago by Don-vip

In 13904/josm:

see #15240 - drop png suffix in renderer unit tests

comment:75 Changed 2 years ago by Don-vip

In 13909/josm:

see #15240 - update renderer unit test reference image

comment:76 Changed 10 months ago by Klumbumbus

Milestone: Longterm

Changed 7 months ago by floscher

Attachment: close.svg added

replacement for misc/close.png

Changed 7 months ago by floscher

Attachment: combineway.svg added

replacement for combineway.png

Changed 7 months ago by floscher

Attachment: grey_x.svg added

replacement for misc/grey_x.png

Changed 7 months ago by floscher

Attachment: joinnodeway.svg added

replacement for joinnodeway.png

Changed 7 months ago by floscher

Attachment: minimized.svg added

replacement for misc/minimized.png

Changed 7 months ago by floscher

Attachment: normal.2.svg added

replacement for misc/normal.png

Changed 7 months ago by floscher

Attachment: rectangle.2.svg added

replacement for misc/rectangle.png

Changed 7 months ago by floscher

Attachment: reorder.svg added

replacement for reorder.png

comment:77 Changed 7 months ago by floscher

a few more SVG icons:

before after
https://josm.openstreetmap.de/export/15557/josm/trunk/images/misc/close.png replacement for misc/close.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/combineway.png replacement for combineway.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/downloadalongtrack.png replacement for downloadalongtrack.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/download_along_way.png replacement for download_along_way.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/misc/grey_x.png replacement for misc/grey_x.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/joinnodeway.png replacement for joinnodeway.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/misc/minimized.png replacement for misc/minimized.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/misc/normal.png replacement for misc/normal.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/misc/rectangle.png replacement for misc/rectangle.png
https://josm.openstreetmap.de/export/15557/josm/trunk/images/reorder.png replacement for reorder.png
Last edited 7 months ago by floscher (previous) (diff)

Changed 7 months ago by floscher

Attachment: downloadalongtrack.svg added

replacement for downloadalongtrack.png

Changed 7 months ago by floscher

Attachment: download_along_way.svg added

replacement for download_along_way.png

comment:78 Changed 7 months ago by Klumbumbus

Where are grey_x, rectangle and reorder used in JOSM? I can't find them right now.

comment:80 Changed 7 months ago by floscher

I'm currently looking at icons in https://josm.openstreetmap.de/browser/josm/trunk/images/cursor/modifier?rev=15558 and found that some of them have a white outline that is not completely opaque. But the icons are not really consistent on how opaque/transparent that white outline is. For example https://josm.openstreetmap.de/browser/josm/trunk/images/cursor/modifier/joinway.png?rev=15558 has opacity values 196, 204 and 231 (of 255) for different parts of the icon.

Should these white outlines have a bit of transparency? If yes how much?

Last edited 7 months ago by floscher (previous) (diff)

comment:81 Changed 7 months ago by Klumbumbus

I think transparency is probably not needed on these outlines. At least on stadard dpi screens I guess you don't see an difference between full white and such a slight transparency at all. Not sure about hi dpi screens.

comment:82 Changed 7 months ago by Klumbumbus

In 15571/josm:

see #15240 - new SVG icons made by floscher

comment:83 Changed 7 months ago by Klumbumbus

Thanks for the icons.

I couldn't figure out how to get an Image marker layer, so I hope this icon works fine ;)

Changed 7 months ago by floscher

Attachment: addnode.svg added

Changed 7 months ago by floscher

Attachment: add_node_lock.svg added

Changed 7 months ago by floscher

Attachment: create_note.svg added

Changed 7 months ago by floscher

Attachment: joinnode.svg added

Changed 7 months ago by floscher

Attachment: joinway.svg added

Changed 7 months ago by floscher

Attachment: lock.svg added

Changed 7 months ago by floscher

Attachment: mode.svg added

Changed 7 months ago by floscher

Attachment: parallel.svg added

Changed 7 months ago by floscher

Attachment: parallel_add.svg added

Changed 7 months ago by floscher

Attachment: parallel_remove.svg added

Changed 7 months ago by floscher

Attachment: audio-tracer.svg added

Changed 7 months ago by floscher

Attachment: Bridge.svg added

Changed 7 months ago by floscher

Attachment: Crossing.svg added

Changed 7 months ago by floscher

Attachment: addnote.svg added

comment:84 Changed 7 months ago by floscher

some more SVG icons:

before after
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/addnode.png cursor/modifier/addnode
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/add_node_lock.png cursor/modifier/add_node_lock
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/create_note.png cursor/modifier/create_note
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/joinnode.png cursor/modifier/joinnode
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/joinway.png cursor/modifier/joinway
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/lock.png cursor/modifier/lock
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/mode.png cursor/modifier/mode
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/parallel.png cursor/modifier/parallel
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/parallel_add.png cursor/modifier/parallel_add
https://josm.openstreetmap.de/export/15576/josm/trunk/images/cursor/modifier/parallel_remove.png cursor/modifier/parallel_remove
https://josm.openstreetmap.de/export/15576/josm/trunk/images/mapmode/addnote.png mapmode/addnote
https://josm.openstreetmap.de/export/15576/josm/trunk/images/mapmode/addsegment.png mapmode/addsegment
https://josm.openstreetmap.de/export/15576/josm/trunk/images/markers/audio-tracer.png markers/audio-tracer
https://josm.openstreetmap.de/export/15576/josm/trunk/images/markers/Bridge.png markers/Bridge
https://josm.openstreetmap.de/export/15576/josm/trunk/images/markers/Crossing.png markers/Crossing
Last edited 7 months ago by floscher (previous) (diff)

Changed 7 months ago by floscher

Attachment: addsegment.svg added

Changed 7 months ago by floscher

Attachment: png_icons.2.png added

Changed 7 months ago by floscher

Attachment: svg_icons.2.png added

comment:85 Changed 7 months ago by floscher

Description: modified (diff)

comment:86 Changed 7 months ago by Klumbumbus

In 15577/josm:

see #15240 - new SVG icons made by floscher

comment:87 Changed 7 months ago by Klumbumbus

Description: modified (diff)

comment:89 Changed 7 months ago by Klumbumbus

Description: modified (diff)

comment:90 Changed 7 months ago by Klumbumbus

Description: modified (diff)

comment:91 Changed 7 months ago by Don-vip

There's a new icon warning for Departements_Lambert4Zones.svg: Style starts with minus: -inkscape-font-specification:DejaVu Sans

Last edited 7 months ago by Don-vip (previous) (diff)

comment:92 Changed 7 months ago by Klumbumbus

In 15585/josm:

see #15240 - fix icon

comment:93 Changed 4 months ago by Stereo

https://www.sjjb.co.uk/mapicons/contactsheet has a lot of icons that we use in the potlatch2 theme - https://www.sjjb.co.uk/mapicons/svg/accommodation/alpinehut.svg could replace source:trunk/resources/images/icons/accommodation_alpinehut.n.16.png resources/images/icons/accommodation_alpinehut.n.16.png etc.

comment:94 Changed 4 months ago by Stereo

http://osm-icons.org/wiki/Icons has more of the same icons

comment:95 Changed 4 months ago by Klumbumbus

This ticket is about the icons of the programm, not the mappaint style(s). (The JOSM default mappaint style is already full svg. I personally don't plan to invest time in the potlatch mappaint style.)

comment:96 Changed 4 months ago by tgertin

Klumbumbus, in the JOSM wiki Introduction, the images do not work. Do you think you can get them to work? Thanks

comment:97 in reply to:  96 Changed 4 months ago by Klumbumbus

Replying to tgertin:

Klumbumbus, in the JOSM wiki Introduction, the images do not work. Do you think you can get them to work? Thanks

Currently all icons in the wiki which refer to the josm source code are not displayed. It will be fixed soon. See #18845.

comment:98 in reply to:  95 ; Changed 4 months ago by Stereo

Replying to Klumbumbus:

This ticket is about the icons of the programm, not the mappaint style(s). (The JOSM default mappaint style is already full svg. I personally don't plan to invest time in the potlatch mappaint style.)

I really like the Potlatch style. Should I open a separate ticket for it?

If I'd like to work on this, how should I submit my patch?

comment:99 Changed 4 months ago by stoecker

In this case a zip file with the new images and a small shell script doing the necessary svn commands would probable be the best idea (old icons moved with "svn mv" to nodist directory).

comment:100 in reply to:  98 Changed 4 months ago by Klumbumbus

Replying to Stereo:

Should I open a separate ticket for it?

Yes.

comment:101 Changed 4 months ago by Klumbumbus

Anyone knows why some toggle dialogs have that scrollbar frame and some not? Most of the toggle dialogs are kind of lists which may be scrollable. Maybe we could unify this and drop the frame?
With frame are: Selection, Relations, Mini map, Command Stack, Authors, Relation Toolbox

Changed 4 months ago by Klumbumbus

Attachment: toggledialogsframe.png added

comment:102 Changed 4 months ago by Klumbumbus

Is there an easy way to find all references to an icon in the source code?

Changed 4 months ago by skyper

menu windows screenshot

comment:103 Changed 4 months ago by skyper

Replying to Klumbumbus:

Anyone knows why some toggle dialogs have that scrollbar frame and some not?

Do not really understand, are you talking about the toggle dialog or the menu "Windows". What has your screenshot to do with your question ?

My menu looks a bit different:

menu windows screenshot

comment:104 Changed 4 months ago by Klumbumbus

I mean this "frame" around some icons:

Changed 4 months ago by Klumbumbus

Attachment: frame.png added

comment:105 Changed 4 months ago by Klumbumbus

Description: modified (diff)

comment:106 in reply to:  104 ; Changed 4 months ago by skyper

Replying to Klumbumbus:

I mean this "frame" around some icons:

Thanks got it, you are talking about the icons in the windows menu.
+1 for removing but maybe we need new icons, e.g. I am not sure if the relation icon source:trunk/resources/images/data/relation.png is the best for the relation list. Similar is true for the selection list.

comment:107 in reply to:  106 Changed 4 months ago by Klumbumbus

Replying to skyper:

you are talking about the icons in the windows menu.

These are the same as in the toggle dialogs!?

Changed 4 months ago by Stereo

Attachment: p2.svg added

Replaces resources/images/dialogs/mappaint/pl2_small.png

comment:108 Changed 4 months ago by Stereo

I've added a p2.svg as attachment that replaces resources/images/dialogs/mappaint/pl2_small.png

Original: 4 KB
SVG: 627 bytes

Hey, it's still something :)

comment:109 Changed 4 months ago by Klumbumbus

In 16059/josm:

see #15240 - change Potlatch2 icon to svg, icon provided by Stereo

comment:110 in reply to:  108 Changed 4 months ago by Klumbumbus

Replying to Stereo:

Hey, it's still something :)

Thanks! (I needed to adjust the svg code a bit as JOSM was not able to display it.)

comment:111 Changed 3 months ago by Stereo

I haven't found an easy way of displaying all the images in one, like in the original ticket. In the end, I found this, which also adds the filename:

find . -not -path './nodist/*' -not -path '*/images/icons/*' -not -path '*/images/logo*' -not -path './test*' -not -path './native/linux/*' -name \*.png | cat - <(echo -ne "josm-all-png.PNG\0") | xargs montage -label '%f' -tile 6x

Edit: excluded nodist

Last edited 3 months ago by Stereo (previous) (diff)

Changed 3 months ago by Stereo

Attachment: josm-all-png.PNG added

PNG files in the JOSM source tree on 2020-03-30

comment:112 Changed 3 months ago by Klumbumbus

You can exclude the nodist folder.

comment:113 Changed 3 months ago by Stereo

Original vector files

https://commons.wikimedia.org/wiki/File:Process-stop.svg is resources/images/cancel.png

https://commons.wikimedia.org/wiki/File:Document-save.svg is resources/images/save.png

https://commons.wikimedia.org/wiki/File:Document-save-as.svg is resources/images/save_as.png

https://commons.wikimedia.org/wiki/File:Gnome-document-properties.svg is ./resources/images/dialogs/settings.png

https://commons.wikimedia.org/wiki/File:Dialog-error.svg is resources/images/data/error.png

https://commons.wikimedia.org/wiki/File:Gnome-emblem-web.svg is resources/images/help/internet.png

https://commons.wikimedia.org/wiki/File:Gnome-text-html.svg is resources/images/markers/web.png

https://commons.wikimedia.org/wiki/File:Gnome-document-save.svg is resources/images/download.png (and the source of many other download icons, as mentioned above)

https://commons.wikimedia.org/wiki/File:Gtk-refresh.svg is resources/images/restart.png (but https://commons.wikimedia.org/wiki/File:View-refresh-2.svg could also be used)

https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg is ./resources/images/dialogs/zoom-best-fit.png (see zoom.png)

https://commons.wikimedia.org/wiki/File:Mail-mark-junk-2.svg is both ./resources/images/purge.png and ./resources/images/data/purge.png

https://commons.wikimedia.org/wiki/File:View-fullscreen.svg is resources/images/view-fullscreen.png (see below for fullscreen-revert)

Near matches

https://commons.wikimedia.org/wiki/File:View-fullscreen.svg is resources/images/view-fullscreen-revert.png with all the arrows turned 180 degrees.

https://commons.wikimedia.org/wiki/File:Emblem-system.svg can replace resources/images/data/relation.png

https://commons.wikimedia.org/wiki/File:System-software-update.svg can replace resources/images/updatedata.png

https://commons.wikimedia.org/wiki/File:Text-x-generic_with_pencil.svg can replace resources/images/dialogs/edit.png . The original looks very gnome-ish, but I couldn't find the source.

https://en.wikipedia.org/wiki/Java_(programming_language)#/media/File:Java_programming_language_logo.svg can replace resources/images/java.png

https://commons.wikimedia.org/wiki/File:Document-open.svg can replace resources/images/open.png

https://commons.wikimedia.org/wiki/File:Emblem-notice.svg can replace resources/images/info.png

https://github.com/GNOME/gimp/blob/mainline/icons/Color/24/gimp-tool-free-select.svg can replace resources/images/mapmode/rope.png

https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg is probably the source for resources/images/mapmode/zoom.png - there is no empty magnifying glass in the gnome icons. Otherwise https://commons.wikimedia.org/wiki/File:System-search.svg can also be used. In that case, zoom-best-fit.png should be https://commons.wikimedia.org/wiki/File:View-zoom-fit.svg.

https://commons.wikimedia.org/wiki/File:Gnome-dialog-warning.svg can replace both resources/images/warning-small.png and resources/images/data/warning.png

https://commons.wikimedia.org/wiki/File:Edit-find.svg can replace resources/images/dialogs/search.png

Improvements

https://commons.wikimedia.org/wiki/File:Input-keyboard.svg looks a lot like resources/images/preferences/shortcuts.png but https://commons.wikimedia.org/wiki/File:Preferences-desktop-keyboard-shortcuts.svg would be a much nicer replacement

https://commons.wikimedia.org/wiki/File:Gnome-preferences-desktop.svg can maybe replace resources/images/preference.png although it's not great, especially on low zoom. Maybe https://commons.wikimedia.org/wiki/File:Preferences-system.svg would be a better fit.

resources/images/preferences/reset.png is https://commons.wikimedia.org/wiki/File:Gnome-go-jump.svg flipped, but https://commons.wikimedia.org/wiki/File:Edit-undo.svg could be a better one

resources/images/data/user.png is https://commons.wikimedia.org/wiki/File:Gnome-system-users.svg but https://commons.wikimedia.org/wiki/File:System-users-3.svg is nicer

https://commons.wikimedia.org/wiki/File:Gnome-applications-utilities.svg (swiss army knife) or https://commons.wikimedia.org/wiki/File:Applications-development.svg (helmet) could replace resources/images/expert.png (Einstein)

I like https://commons.wikimedia.org/wiki/File:Red_bug.svg to replace resources/images/bug.png

Tango look uniformisation

https://commons.wikimedia.org/wiki/File:Gnome-view-refresh.svg is resources/images/dialogs/refresh.png but https://commons.wikimedia.org/wiki/File:View-refresh.svg could be used to standardise on the Tango look

resources/images/preferences/advanced.png is https://commons.wikimedia.org/wiki/File:Gnome-document-properties.svg but https://commons.wikimedia.org/wiki/File:Document-properties.svg could be used to standardise on the Tango look

resources/images/preferences/display.png is https://commons.wikimedia.org/wiki/File:Gnome-preferences-desktop-wallpaper.svg but https://commons.wikimedia.org/wiki/File:Preferences-desktop-wallpaper.svg could be used to standardise on the Tango look

KDE Breeze icons

https://commons.wikimedia.org/wiki/Breeze_icons has some beautiful ones, and they come in different sizes, which means we can make them look good even in smaller sizes. If you all like these, I'll create the other icons.

https://github.com/KDE/breeze-icons/blob/master/icons/actions/22/selection-move-to-layer-below.svg can replace resources/images/dialogs/mergedown.png

https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-duplicate.svg can replace resources/images/dialogs/duplicatelayer.png

https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-bottom.svg could be adapted with a double-headed arrow to replace resources/images/dialogs/reorderlayers.png

https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-kstars_satellites.svg could replace resources/images/layer/gpx_small.png and be the base for all gpx-related icons: resources/images/exportgpx.png , resources/images/dialogs/geoimage/gpx2img.png and resources/images/converttogpx.png

https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-redeyes.svg, https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-hint.svg and https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-visibility.svg could be adapted to replace all the eye icons: resources/images/misc/buttonshow.png , resources/images/dialogs/layerlist/eye-off.png , resources/images/dialogs/layerlist/eye-pressed.png , resources/images/misc/buttonhide.png , resources/images/dialogs/layerlist/eye-translucent.png , resources/images/dialogs/showhide.png and resources/images/dialogs/layerlist/eye.png . We could also use their layer icons - https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-layer-visible-on.svg and https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-layer-visible-off.svg

https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-autocorrection.svg could replace resources/images/dialogs/fix.png - and be an UI improvement over the socket wrench

https://commons.wikimedia.org/wiki/File:Breezeicons-emblems-16-vcs-normal.svg can replace resources/images/dialogs/layerlist/active.png right away. I'm not sure when resources/images/dialogs/layerlist/active-pressed.png is ever shown, but I could easily create that.

For filters, it has https://github.com/KDE/breeze-icons/blob/master/icons-dark/preferences/32/preferences-desktop-filter.svg https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-kt-add-filters.svg https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-kt-remove-filters.svg.

https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/document-edit.svg can replace resources/images/dialogs/mappaint/pencil.png

https://commons.wikimedia.org/wiki/File:Breezeicons-actions-22-edit-select-lasso.svg could replace resources/images/cursor/modifier/rope.png

https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-raise.svg and https://github.com/KDE/breeze-icons/blob/master/icons/actions/16/layer-lower.svg could replace the up/down arrows in the Layers panel.

resources/images/clock.png is only even used for Help > Show Status Report. I suggest replacing it with https://github.com/KDE/breeze-icons/blob/master/icons/actions/22/debug-run.svg

Last edited 3 months ago by Stereo (previous) (diff)

Changed 3 months ago by Stereo

Attachment: Extrude.svg added

Based off Tango's Applications-accessories, replacement for resources/images/mapmode/extrude/extrude.png

Changed 3 months ago by Stereo

Attachment: Upload.svg added

Based of Gnome-document-save, replacement for resources/images/upload.png

Changed 3 months ago by Stereo

Attachment: Upload-selection.svg added

Based of Gnome-document-save (see Upload.svg) and JOSM's way-select.svg, improved replacement for resources/images/uploadselection.png

Changed 3 months ago by Stereo

Attachment: overpass-api-small (1).svg added

Based off Overpass API logo but with thicker lines, improved replacement for resources/images/download-overpass.png

comment:114 Changed 3 months ago by Stereo

The existing ./resources/images/mapmode/addnote.svg can replace ./resources/images/dialogs/notes/note_new.png

Last edited 3 months ago by Stereo (previous) (diff)

comment:115 Changed 3 months ago by Stereo

The validation checkmark is actually there four times:

resources/images/preferences/validator.png
resources/images/layer/validator_small.png
resources/images/dialogs/validator.png
resources/images/data/imagery/qa.png

Last edited 3 months ago by Stereo (previous) (diff)

Changed 3 months ago by Stereo

Attachment: qa.svg added

The blue validation checkmark is easily one of the ugliest icons in JOSM, but also one of the most recognisable ones. I've vectorised an improved, flatter one.

Changed 3 months ago by Stereo

Attachment: activate-down.svg added

Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/preferences/activate-down.png

Changed 3 months ago by Stereo

Attachment: activate-right.svg added

Same as activate_down but to replace ./resources/images/preferences/activate-right.png

comment:116 Changed 3 months ago by Stereo

https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/images/NoteMarker.svg could replace:

./resources/images/dialogs/notes/note_closed.png
./resources/images/dialogs/notes/note_open.png
./resources/images/dialogs/notes/note_comment.png
./resources/images/dialogs/notes/note_new.png
./resources/images/mapmode/addnote.svg

and be adapted for

./resources/images/note_search.png

Changed 3 months ago by Stereo

Attachment: useallleft.svg added

Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/dialogs/conflict/useallleft.png

Changed 3 months ago by Stereo

Attachment: useallright.svg added

Modified from ./resources/images/dialogs/activate.svg, here's the replacement for ./resources/images/dialogs/conflict/useallright.png

comment:117 Changed 3 months ago by Stereo

Actually, I see that we already have arrows like that in the SVG sprite at the top! Well, whichever works best.

Changed 3 months ago by skyper

Attachment: Tower_dome.svg added

source:trunk/resources/images/presets/landmark/tower.png could be replaced with [[JOSMImage(presets/landmark/tower)]] could be replaced with [[Image(Tower_dome.svg)]] osmwiki:File:Tower_dome.svg as the first does not look nice in preset menu osmwiki:File:Tower_dome.svg as the first does not look nice in preset menu

comment:118 Changed 3 months ago by Klumbumbus

Thanks a lot for this long list of replacements, Stereo! I'll have a look after the upcoming next JOSM stable release.

comment:119 Changed 3 months ago by Klumbumbus

In 16250/josm:

comment:120 Changed 3 months ago by Klumbumbus

I had these validator icons sitting here already for a while. I compared with your suggestions (https://commons.wikimedia.org/wiki/File:Gnome-dialog-warning.svg and https://commons.wikimedia.org/wiki/File:Dialog-error.svg) but these don't scale down well.

Last edited 3 months ago by Klumbumbus (previous) (diff)

comment:122 Changed 3 months ago by Klumbumbus

In 16251/josm:

see #15240 - use nicer user icon (from https://commons.wikimedia.org/wiki/File:System-users-3.svg, removed strange script from file, CC0 and PD licensed)

comment:123 Changed 3 months ago by Klumbumbus

@Dirk: Do we need some special additions in the contribution file for icons with licenses like https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg
And whats the license of the KDE Breeze icons?

comment:124 Changed 3 months ago by stoecker

I fear icons which require individual attribution can't be used. If we use larger sets of icons where one attribution fits, our contributions file can be used.

comment:125 Changed 3 months ago by Klumbumbus

I reworked the icon section in the contribution file. Please have a look if it is ok:

  • CONTRIBUTION

     
    105105
    106106------------------------------------ ICONS ------------------------------------
    107107
    108 Most icons have been nicked from GNOME and the GIMP, both under GPL.
    109 Some are originally LGPL but redistributed here under GPL.
     108Lots of icons are from GNOME Project https://www.gnome.org/ under GPL or LGPL, redistributed here under GPL.
    110109
     110Some icons are from GIMP https://www.gimp.org/ under GPL or LGPL, redistributed here under GPL.
     111
     112Lots of icons are from https://openclipart.org/, https://publicdomainvectors.org/, The Tango Desktop Project, other sources or self created, all PD and CC0 licensed.
     113
    111114Simple OpenStreetMap logo has been created by ScubbX (CC-SA 2.0) based on official
    112115logo used by the OpenStreetMap Foundation:
    113116https://wiki.openstreetmap.org/wiki/File:Logo_simple.svg
     
    121124- original filename: keyboard.png
    122125- original size: 128x128
    123126- modifications: icon was cropped, then resized
     127
     128See also the commit message of each icon for its source at https://josm.openstreetmap.de/browser/josm/trunk/resources/images.
     129 No newline at end of file
Last edited 3 months ago by Klumbumbus (previous) (diff)

comment:126 Changed 3 months ago by stoecker

The last link shouldn't have a point at the end. Either remove it or add one more word behind :-). Also add the newline at the end. Otherwise it looks fine to me.

comment:127 Changed 3 months ago by Klumbumbus

In 16351/josm:

see #15240 - Rework icon attribution section

comment:128 in reply to:  113 Changed 8 weeks ago by Klumbumbus

Replying to Stereo:

Original vector files

...

These look blurry when scaled down to 16 or 24 px. Anyone knows a program/tool that pixel aligns svgs somehow? Doing this manually is lots of work.
I loaded the tango theme (where we use some pngs still) from https://web.archive.org/web/20150911230620/http://tango.freedesktop.org/releases/tango-icon-theme-0.8.90.tar.gz and beside the svgs it includes png exports at 16, 22 and 32 px, which are nicely pixel aligned but I don't know if this was done manually too or with one of the included scripts.

Also a general question: For the gui icons we stay at the base size of 24px, do we? In the past (some years ago) the size in the menus was 24px too similar to the toolbar. Now that the menus display the icons at 16 px lots of them are blurry. (See e.g. the tools menu.)

comment:129 Changed 10 days ago by Klumbumbus

In 16719/josm:

see #15240 - Replace cancel icon by svg, (icon from tango project https://commons.wikimedia.org/wiki/File:Process-stop.svg, modified, PD and CC0 licensed)

comment:130 Changed 10 days ago by Klumbumbus

In 16720/josm:

see #15240 - Replace validator icon by svg, (icon by Stereo, PD and CC0 licensed)

comment:131 Changed 10 days ago by Klumbumbus

In 16721/josm:

see #15240 - Replace activate-down and activate-right icon by svg (icon by Stereo, PD and CC0 licensed)

comment:132 Changed 10 days ago by Klumbumbus

Thanks for the icons Stereo.
Yeah, we reached the turning point. 173 png vs. 173 svg gui icons right now, see graph in ticket desciption above \o/

comment:133 Changed 10 days ago by Stereo


comment:134 Changed 10 days ago by skyper

Would it be a good idea to add the size 24 as default option to [[JOSMImage()]] or do we need to adjust all wiki pages where the icons are present?

comment:135 Changed 10 days ago by Klumbumbus

In 16722/josm:

see #15240 - Resize one of the validator icons to avoid a lot wiki changes

comment:136 Changed 10 days ago by Klumbumbus

In 16724/josm:

see #15240 - Replace some icons by svg

see #10759 - Remove old unused icons

comment:137 Changed 9 days ago by Klumbumbus

One regression, see #19446, already fixed. I hope there are no more plugins affected.

comment:138 Changed 9 days ago by Klumbumbus

At least the plugins undelete and buildings_tools are affected too :(
Too bad Jenkins doesn't report it.
Can someone please give me a hint how to find all affected plugins and how to properly fix it, not like [o35496]?

comment:139 in reply to:  138 Changed 9 days ago by Klumbumbus

Replying to Klumbumbus:

how to properly fix it, not like [o35496]?

I just figured out that simply deleting the extension seems to work fine too. Is that a good solution?

comment:140 in reply to:  138 ; Changed 9 days ago by stoecker

Replying to Klumbumbus:

At least the plugins undelete and buildings_tools are affected too :(
Too bad Jenkins doesn't report it.
Can someone please give me a hint how to find all affected plugins and how to properly fix it, not like [o35496]?

grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"
or a bit reduced:
grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"|grep "cancel\.png"

I just figured out that simply deleting the extension seems to work fine too. Is that a good solution?

That's the right solution. Extension should only be specified in rare cases when for some reason the auto-choice is unwanted.

So in most cases (in Java code) the extension should simply be dropped everywhere.

comment:141 Changed 8 days ago by Klumbumbus

So by simply removing the file extension I don't need to change plugin.main.version right?

comment:142 in reply to:  140 Changed 8 days ago by Klumbumbus

Replying to stoecker:

grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"
or a bit reduced:
grep -e "\.\(png\|svg\)\"" -r .|grep "\.java"|grep "cancel\.png"

Thx, that helped, I found:

areaselector\src\org\openstreetmap\josm\plugins\areaselector\AddressDialog.java:    protected static final String[] BUTTON_ICONS = new String[] {"ok.png", "cancel.png"};
austriaaddresshelper\src\org\openstreetmap\josm\plugins\austriaaddresshelper\AddressTypeDialog.java:    protected static final String[] BUTTON_ICONS = new String[] {"ok.png", "cancel.png"};
buildings_tools\src\org\openstreetmap\josm\plugins\buildings_tools\MyDialog.java:    private static final String[] BUTTON_ICONS = new String[] {"ok.png", "cancel.png"};
DirectUpload\src\org\openstreetmap\josm\plugins\DirectUpload\UploadDataGui.java:        setButtonIcons(new String[] { "uploadtrace.png", "cancel.png" });
Dxf-Import\src\org\openstreetmap\josm\plugins\dxfimport\ImportDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png"});
ext_tools\src\ext_tools\preferences\EditToolDialog.java:        setButtonIcons("ok.png", "cancel.png");
FastDraw\src\org\openstreetmap\josm\plugins\fastdraw\FastDrawConfigDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png"});
importvec\src\org\openstreetmap\josm\plugins\importvec\ImportDialog.java:        setButtonIcons(new String[] { "ok.png", "cancel.png" });
photo_geotagging\src\org\openstreetmap\josm\plugins\photo_geotagging\GeotaggingAction.java:            .setButtonIcons(new String[] {"ok.png", "cancel.png"})
photo_geotagging\src\org\openstreetmap\josm\plugins\photo_geotagging\GeotaggingAction.java:                        .setButtonIcons(new String[] {"cancel.png", "ok.png", "dialogs/delete.png"})
roadsigns\src\org\openstreetmap\josm\plugins\roadsigns\RoadSignInputDialog.java:        setButtonIcons("ok.png", "cancel.png");
sds\src\org\openstreetmap\hot\sds\SdsDiskAccessAction.java:                dialog.setButtonIcons(new String[] {"save_as.png", "cancel.png"});
sds\src\org\openstreetmap\hot\sds\SdsDiskAccessAction.java:            dialog.setButtonIcons(new String[] {"save_as.png", "cancel.png"});
terracer\src\org\openstreetmap\josm\plugins\terracer\HouseNumberInputDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png" });
tracer2\src\org\openstreetmap\josm\plugins\tracer2\preferences\ServerParamDialog.java:        setButtonIcons(new String[] {"ok.png", "cancel.png"});

(found with findstr /s /i cancel\.png *.java)

comment:143 in reply to:  141 Changed 8 days ago by stoecker

Replying to Klumbumbus:

So by simply removing the file extension I don't need to change plugin.main.version right?

Yes. In the core that was done years ago for all icons.

comment:144 Changed 8 days ago by stoecker

I removed all extensions in plugins for setButtonIcons() call. Now recompiling and publishing is needed.

comment:145 in reply to:  144 ; Changed 8 days ago by Klumbumbus

Replying to stoecker:

I removed all extensions in plugins for setButtonIcons() call.

Thx.

Now recompiling and publishing is needed.

Are you on it yet or should I do it?

comment:146 in reply to:  145 Changed 8 days ago by stoecker

Replying to Klumbumbus:

Replying to stoecker:

I removed all extensions in plugins for setButtonIcons() call.

Thx.

Now recompiling and publishing is needed.

Are you on it yet or should I do it?

I currently have no Java8 system ready (and compiling with 11 may cause trouble). If you do it that would be fine, so I must not search a place for compiling. Simply compile all plugins (e.g. "ant build" in main dir) and then in dist dir do ./getversions. That drops all files without version change. This way also all the pending i18n is updated :-) Afterwards check in all changed files jars.

Last edited 8 days ago by stoecker (previous) (diff)

comment:147 Changed 8 days ago by Klumbumbus

fixed trac plugins in [o35502] (with ant clean dist in every plugin directory)
still todo:

I don't know how the github releases work.

comment:148 Changed 8 days ago by josmTEACH

hey there wizards! i randomly walked into a large .svg on a wiki page (/styles)https://josm.openstreetmap.de/wiki/Styles and somehow teleported here, so wanted to let you know it might affect other wiki pages too?

big props to all the efforts done through the years fellas

comment:149 Changed 8 days ago by Klumbumbus

In 16728/josm:

see #15240 - fix icons size

comment:150 Changed 8 days ago by Klumbumbus

Thx for reporting josmTEACH.

comment:151 Changed 8 days ago by skyper

See #18562 for a problem with source:trunk/resources/images/dialogs/delete.svg delete.svg

comment:152 in reply to:  151 Changed 8 days ago by stoecker

Replying to skyper:

See #18562 for a problem with source:trunk/resources/images/dialogs/delete.svg delete.svg

Should be fixed in the plugin, i.e. in #18562.

comment:153 in reply to:  147 Changed 8 days ago by stoecker

Replying to Klumbumbus:

I don't know how the github releases work.

I could find out, but actually I don't want to. I don't want to care for multiple build systems.

I'd say we release core tomorrow.

Either the plugins get fixed by the maintainers of the plugins or disabled. I'd only handle them after a reimport into the SVN.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Klumbumbus
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.