[patch] unused icons active-pressed and eye-pressed

[Klumbumbus]

The icons dialogs/layerlist/active-pressed and dialogs/layerlist/eye-pressed are actually never used in JOSM, or are they in different OS/LookAndFeel?

They don't make much sense to me anyway.

Is it fine to remove the two icons and these two lines? (These are the two only occurrences of setPressedIcon in the whole JOSM code.)

LayerListDialog.java

@@ -465 +465 @@
             setSelectedIcon(active);
             setRolloverIcon(blank);
             setRolloverSelectedIcon(active);
-            setPressedIcon(ImageProvider.get("dialogs/layerlist", "active-pressed"));
         }
     }
 
@@ -482 +481 @@
             iconEye = new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye");
             iconEyeTranslucent = new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye-translucent", true);
             setIcon(ImageProvider.get("dialogs/layerlist", "eye-off"));
-            setPressedIcon(new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye-pressed"));
             setSelectedIcon(iconEye);
             isTranslucent = false;
         }

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-25 14:35:24 +0200 (Sat, 25 Jul 2020)
Build-Date:2020-07-26 01:30:54
Revision:16808
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16808 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 723 MB / 1820 MB (302 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1680x1050 (scaling 1.0x1.0)
Maximum Screen Size: 1680x1050
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=49841, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

[skyper]

Isn't "dialogs/layerlist/eye-pressed" used in layer list panel for imagery if the opacity is below 100%?

[Klumbumbus]

No, thats dialogs/layerlist/eye-translucent

[skyper]

Replying to Klumbumbus:

No, thats dialogs/layerlist/eye-translucent

You are right. Cannot see much difference except of the placement.

[Klumbumbus]

In 16828/josm:

• see #15240 - remove forgotten png in svg
• fix #19583 - remove unused icons