Modify

#19583 closed enhancement (fixed)

[patch] unused icons active-pressed and eye-pressed

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 20.08
Component: Core Version:
Keywords: template_report Cc:

Description (last modified by Klumbumbus)

The icons source:trunk/resources/images/dialogs/layerlist/active-pressed.png dialogs/layerlist/active-pressed and source:trunk/resources/images/dialogs/layerlist/eye-pressed.png dialogs/layerlist/eye-pressed are actually never used in JOSM, or are they in different OS/LookAndFeel?

They don't make much sense to me anyway.

Is it fine to remove the two icons and these two lines? (These are the two only occurrences of setPressedIcon in the whole JOSM code.)

  • LayerListDialog.java

     
    465465            setSelectedIcon(active);
    466466            setRolloverIcon(blank);
    467467            setRolloverSelectedIcon(active);
    468             setPressedIcon(ImageProvider.get("dialogs/layerlist", "active-pressed"));
    469468        }
    470469    }
    471470
     
    482481            iconEye = new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye");
    483482            iconEyeTranslucent = new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye-translucent", true);
    484483            setIcon(ImageProvider.get("dialogs/layerlist", "eye-off"));
    485             setPressedIcon(new EyeIcon(/* ICON(dialogs/layerlist/) */ "eye-pressed"));
    486484            setSelectedIcon(iconEye);
    487485            isTranslucent = false;
    488486        }
URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-25 14:35:24 +0200 (Sat, 25 Jul 2020)
Build-Date:2020-07-26 01:30:54
Revision:16808
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16808 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 723 MB / 1820 MB (302 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1680x1050 (scaling 1.0x1.0)
Maximum Screen Size: 1680x1050
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest.jnlp, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=49841, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Attachments (0)

Change History (5)

comment:1 Changed 12 months ago by skyper

Isn't source:trunk/resources/images/dialogs/layerlist/eye-pressed.png "dialogs/layerlist/eye-pressed" used in layer list panel for imagery if the opacity is below 100%?

Last edited 12 months ago by skyper (previous) (diff)

comment:2 Changed 12 months ago by Klumbumbus

No, thats source:trunk/resources/images/dialogs/layerlist/eye-translucent.svg dialogs/layerlist/eye-translucent

Last edited 12 months ago by Klumbumbus (previous) (diff)

comment:3 Changed 12 months ago by Klumbumbus

Description: modified (diff)

comment:4 in reply to:  2 Changed 12 months ago by skyper

Replying to Klumbumbus:

No, thats source:trunk/resources/images/dialogs/layerlist/eye-translucent.svg dialogs/layerlist/eye-translucent

You are right. Cannot see much difference except of the placement. source:trunk/resources/images/dialogs/layerlist/eye-translucent.svg source:trunk/resources/images/dialogs/layerlist/eye-pressed.png

Last edited 12 months ago by skyper (previous) (diff)

comment:5 Changed 12 months ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16828/josm:

  • see #15240 - remove forgotten png in svg
  • fix #19583 - remove unused icons

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.