Modify

Opened 7 weeks ago

Closed 3 weeks ago

#19668 closed defect (fixed)

download.svg icon missing on StartupPage

Reported by: mdk Owned by: team
Priority: normal Milestone: 20.09
Component: Core Version: latest
Keywords: template_report Cc: simon04, Don-vip

Description (last modified by mdk)

What steps will reproduce the problem?

  1. Start JOSM

What is the expected result?

StartupPage shows Icon Download.svg in the text.

What happens instead?

The icon is replaced by an error placeholder:

Please provide any additional information below. Attach a screenshot if possible.

The Wiki shows the icon correctly:
https://josm.openstreetmap.de/wiki/StartupPageSource

Same happens on my Ubuntu machine.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-08-11 22:26:29 +0200 (Tue, 11 Aug 2020)
Build-Date:2020-08-12 01:30:47
Revision:16871
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16871 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1909 (18363)
Memory Usage: 1206 MB / 3616 MB (605 MB allocated, but free)
Java version: 1.8.0_201-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1200 (scaling 1.0x1.0), \Display1 1920x1200 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1200
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32

Plugins:
+ buildings_tools (35500)

Last errors/warnings:
- E: Region [TMS_BLOCK_v2] : Problem loading keys for file TMS_BLOCK_v2

Attachments (1)

MissingIcon.png (6.2 KB) - added by mdk 7 weeks ago.

Download all attachments as: .zip

Change History (12)

Changed 7 weeks ago by mdk

Attachment: MissingIcon.png added

comment:1 Changed 7 weeks ago by mdk

Description: modified (diff)

comment:2 Changed 7 weeks ago by skyper

Should have been fixed with r16872, a few hours ago.

comment:3 Changed 7 weeks ago by Klumbumbus

Milestone: 20.08
Resolution: fixed
Status: newclosed
Version: latest

Yes. Should be fine again tomorrow.

comment:4 Changed 6 weeks ago by skyper

Only fixed for latest, see simon04's comment 203 on #15240.

tested and all derivatives of it will probably continue to have the problem.

I changed the wiki page to use the old icon for now (diff).

Should I reopen the ticket and set the milestone to 20.9 as an reminder to revert it in September?

comment:5 Changed 6 weeks ago by Klumbumbus

Milestone: 20.0820.09
Resolution: fixed
Status: closedreopened

I'm not sure if it will work for old versions if we put the new svg icon also in the nodist folder and link this one. Else I think we will have to live with a png for a few more months.

comment:6 Changed 6 weeks ago by stoecker

You don't need to change SVN. I'd say you only need to reference the historic png instead of the SVG. The main cause is that SVG was not supported directly in start page. PNG icons should work thought. Data URL's with png inside work for sure.

SVG not in josm-core still is not supported I fear. What I did is to replace SVG by PNG on the fly :-).

comment:7 Changed 6 weeks ago by stoecker

Cc: simon04 Don-vip added

P.S. If someone knows a way to enable SVG support in GettingStarted it would be welcome aside from my fix.

comment:8 Changed 6 weeks ago by Klumbumbus

comment:9 Changed 3 weeks ago by Klumbumbus

In 17014/josm:

see #19668 - Change downloadicon of startuppage to new design. Use 96px for hidpi.

comment:10 Changed 3 weeks ago by Klumbumbus

In 17015/josm:

see #19668 - Change size of downloadicon of startuppage from 96px to 24px as downscaling via startuppagesource doesn't work.

comment:11 Changed 3 weeks ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

For now this is fixed. (minor issue: hidpi users will see a pixelated icon on startuppage) We can replace the png by svg in a year or so when nobody uses an JOSM version without svg support on startuppage anymore (i.e. < r16872).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.