Modify

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#12135 closed enhancement (fixed)

Popular tags not in internal presets (2/2)

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 15.12
Component: Internal preset Version:
Keywords: bin building entrance footway golf highway historic landuse leisure locality man_made place railway route ruins seamark trolley_wire waterway Cc: Klumbumbus

Description (last modified by Don-vip)

This is the follow-up of #12102 for 15.12 milestone:

Tag (wiki) Count (taginfo) Decision
bicycle=dismount 37307 Ignored for now, see #9158
bin=yes 22245 Added
building=civic 53949 Ignored for now, controversial tag
building=hotel 21776 Added
building=houseboat 11520 Ignored, not a building
building=kindergarten 13125 Added
building=manufacture 94507 Added
building=public 39377 Ignored for now, controversial tag
building=service 95527 Added
building=static_caravan 26023 Ignored, not a building
building=train_station 13938 Added
cuisine=coffee_shop 16997 Added
entrance=staircase 66237 Added
footway=crossing 135476 Added
footway=sidewalk 217915 Added
golf=bunker 64675 ........ see #12240
golf=fairway 24191 ........ see #12240
highway=proposed 51018 Ignored for now, see #11139
historic=building 11875 Ignored. Should be categorized with a better value than "building"
landuse=conservation 24867 Deprecated in favour of boundary=protected_area
leisure=recreation_ground 27747 Ignored. Conflicts with landuse=recreation_ground which is more used and in JOSM default presets
locality=townland 48104 Ignored (only used in Ireland)
man_made=mast 23646 ............ see #10759
man_made=silo 41194 ............ see #11915
place=allotments 12582 Ignored (only used in former Soviet Union)
railway=signal 40435 Added
railway=stop 11325 Ignored (better fit in OpenRailwayMap than default presets)
route=foot 26924 ............ see #10991
ruins=yes 33287 Added
seamark=buoy 10212 Deprecated
trolley_wire=yes 34577 Added
waterway=rapids 44573 Keep the situation as is for now. Difficult case. Was removed from mappaint in r8135 and r8767. The tag is clearly garbage, however there is no replacement, so a deprecation warning is not possible.

Attachments (0)

Change History (52)

comment:1 Changed 4 years ago by Don-vip

Type: defectenhancement

comment:2 Changed 4 years ago by Klumbumbus

I asked tumsi and he allows us to use the golf svg icons. He also maybe can create new icons if needed for the tags in Presets/Golf_Course, which do not have an icon. (I did not yet check the tags).

comment:3 Changed 3 years ago by Don-vip

In 9089/josm:

see #12135 - add bin to public_transport=platform and highway=bus_stop. Reuse translation of amenity=waste_basket

comment:4 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:5 Changed 3 years ago by Don-vip

In 9090/josm:

see #12135 - add footway=crossing/sidewalk to highway=footway

comment:6 Changed 3 years ago by Don-vip

Description: modified (diff)
Keywords: bin highway footway added

comment:7 Changed 3 years ago by Klumbumbus

In 9091/josm:

see #12135 - add seamark=buoy to mappaint and preset; remove old deprecated tags section in elemstyles.mapcss

comment:8 Changed 3 years ago by Klumbumbus

Description: modified (diff)

buoy icon [o31800]

comment:9 Changed 3 years ago by Klumbumbus

In 9092/josm:

see #12135 - add railway=signal to mappaint and preset

comment:10 Changed 3 years ago by Klumbumbus

Description: modified (diff)

railway signal icon ​[o31801]

comment:11 Changed 3 years ago by malcolmh

"seamark=buoy" is a 'dead' tag. It belongs to a tagging scheme that was proposed back in 2009, but subsequently abandoned. The number of objects which have this tag has been steadily decreasing since then. The 'live' tagging scheme, uses the tag "seamark:type=*". There are some 47000 buoy objects with this tagging and the number has increased fourfold since 2009. Of the 10000 objects with "seamark=buoy", some 7000 of those also have the "seamark:type=*" tag. There is already a preset for the "seamark:type" tagging (https://raw.githubusercontent.com/OpenSeaMap/josm/master/INT-1-preset.xml)

Please do not include "seamark=buoy" as a standard preset.

comment:12 Changed 3 years ago by Klumbumbus

Thanks for clarification.

comment:13 Changed 3 years ago by Klumbumbus

In 9093/josm:

see #12135 - remove seamark=buoy and add deprecated warning; fix icon size of railway=signal

comment:14 Changed 3 years ago by Klumbumbus

Description: modified (diff)

comment:15 Changed 3 years ago by Klumbumbus

In 9094/josm:

see #12135 - ignore seamark:type tags in missing tags validation test

comment:16 Changed 3 years ago by Don-vip

In 9137/josm:

see #12135 - ignore locality=townland (only used in Ireland)

comment:17 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:18 Changed 3 years ago by Don-vip

In 9138/josm:

see #12135 - add building=hotel/service/train_station to default presets

comment:19 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:20 Changed 3 years ago by anonymous

hi , can you please add "amenity=social_facility" to the list ? It's very popular tag , we have 40000 use and we don't have preset for this tag.

comment:21 Changed 3 years ago by Atalanttore

You should add end_date, because start_date is already in JOSM.

Another key I would like is cemetery=grave.

Regards,
Ettore

comment:22 Changed 3 years ago by anonymous

Hi Don-vip , I re opened this ticket #12190 , and I written reasons in this ticket.

comment:23 Changed 3 years ago by anonymous

hi , can you give me the answer ?

comment:24 Changed 3 years ago by Don-vip

will you please stop asking every day? We treat tickets when we have time to do it, please be patient.

comment:25 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:26 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:27 Changed 3 years ago by Don-vip

In 9157/josm:

see #12135 - add building=kindergarten/manufacture to default presets

comment:28 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:29 Changed 3 years ago by Don-vip

In 9158/josm:

see #12135 - add cuisine=coffee_shop to default presets

comment:30 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:31 Changed 3 years ago by Don-vip

In 9159/josm:

see #12135 - add entrance=staircase to default presets

comment:32 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:33 Changed 3 years ago by Don-vip

In 9160/josm:

see #12135 - deprecate landuse=conservation in favour of boundary=protected_area (better fit, and it has been removed from default rendering, see https://github.com/gravitystorm/openstreetmap-carto/pull/1830)

comment:34 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:35 Changed 3 years ago by Don-vip

In 9161/josm:

see #12135 - add trolley_wire to urban ways presets

comment:36 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:37 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:38 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:39 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:40 Changed 3 years ago by Don-vip

In 9162/josm:

see #12135 - ignore more tags

comment:41 Changed 3 years ago by Don-vip

In 9164/josm:

see #12135 - remove cuisine=coffee_shop from ignored tags

comment:42 Changed 3 years ago by Don-vip

In 9165/josm:

see #12135 - add ruins=yes to historic=castle and military=bunker presets

comment:43 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:44 Changed 3 years ago by Don-vip

In 9181/josm:

see #12135 - ignore railway=stop (better fit in OpenRailwayMap than default presets)

comment:45 Changed 3 years ago by Don-vip

Description: modified (diff)

comment:46 Changed 3 years ago by Don-vip

Keywords: building entrance golf historic landuse leisure locality man_made place railway route ruins seamark trolley_wire waterway added

comment:47 Changed 3 years ago by Don-vip

Description: modified (diff)
Resolution: fixed
Status: newclosed

comment:48 Changed 3 years ago by Math1985

Once again really great work! How did you generate the list of commonly used tags? Is there a follow-up for lesser used tags planned?

comment:49 Changed 3 years ago by Don-vip

The list was obtained from Overpass API which only lists tags with more than 10.000 occurrences. I don't plan to make another global research now, it should be on case by case.

comment:50 Changed 3 years ago by Klumbumbus

comment:52 Changed 3 years ago by Klumbumbus

In 9302/josm:

see #12135 - add mappaint for entrance=staircase and tourism=wilderness_hut, adjust tourism color (was to similar to building), typos

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.