Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12102 closed enhancement (fixed)

Popular tags not in internal presets (1/2)

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 15.11
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by Don-vip)

I have built the list of popular tags (as defined by taginfo), unknown from JOSM presets, for which we do not have a MapCSS deprecation warning.

We should decide which tags should be added to presets, which ones should be deprecated and which ones should be ignored by the tag/key not in presets validator test. The decision that a tag is ignored is not forever and can of course be reconsidered later.

Tag (wiki) Count (taginfo) Decision
abandoned=yes 19932 Ignored. Lifecycle
amenity=swimming_pool 46883 Ignored. Duplicate of leisure=swimming_pool. However not declared as deprecated in the wiki.
bicycle=dismount 37307 Ignored for now, see #9158
bin=yes 22245 ........ see #12135
building=cabin 89126 Added
building=civic 53949 ........ see #12135
building=hotel 21776 ........ see #12135
building=houseboat 11520 ........ see #12135
building=kindergarten 13125 ........ see #12135
building=manufacture 94507 ........ see #12135
building=public 39377 ........ see #12135
building=service 95527 ........ see #12135
building=stable 10477 Added
building=static_caravan 26023 ........ see #12135
building=train_station 13938 ........ see #12135
construction=yes 48871 Ignored. Lifecycle
crop=corn 13629 Added
crop=grass 14186 Added
crop=rice 15795 Added
cuisine=coffee_shop 16997 ........ see #12135
entrance=staircase 66237 ........ see #12135
footway=crossing 135476 ........ see #12135
footway=sidewalk 217915 ........ see #12135
golf=bunker 64675 ........ see #12240
golf=fairway 24191 ........ see #12240
heritage=2 16686 Ignored like admin_level
heritage=4 14589 Ignored like admin_level
highway=proposed 51018 Ignored for now, see #11139
historic=building 11875 ........ see #12135
historic=yes 34631 Ignored. Lifecycle
landuse=conservation 24867 ........ see #12135
landuse=farm 572939 Deprecated in favour of landuse=farmland and landuse=farmyard
leisure=recreation_ground 27747 ........ see #12135
living_street=yes 193832 Ignored. Used only in Russia. unclear situation in relation to highway=living_street.
locality=townland 48104 ........ see #12135
maintenance=gritting 15556 Ignored. Empty wiki page and local usage, see taginfo map
man_made=mast 23646 ............ see #10759
man_made=petroleum_well 32326 Ignored. Unclear definition in relation to man_made=pumping_rig
man_made=silo 41194 ............ see #11915
military=bunker 23317 Added
mooring=yes 18504 Added
oneway=-1 122298 Deprecated We already have a validator warning.
oneway=1 10250 Deprecated We already have a validator warning.
pipeline=marker 12322 Added
place=allotments 12582 ........ see #12135
placement=right_of:1 17516 Added
placement=transition 12958 Added
railway=signal 40435 ........ see #12135
railway=stop 11325 ........ see #12135
residential=rural 125887 Ignored. Used only in Russia. Different concepts of refining residential landuse exist.
residential=urban 15335 Ignored. Used only in Russia. Different concepts of refining residential landuse exist.
route=foot 26924 ............ see #10991
ruins=yes 33287 ........ see #12135
seamark=buoy 10212 ........ see #12135
service=crossover 16733 Added.
service=emergency_access 11623 Added
smoking=outside 14449 Added
surface=earth 24377 Ignored. Duplicate of ground and dirt (which are used much more) However not declared as deprecated in the wiki.
takeaway=yes 17507 Added
tidal=yes 16590 Added
traffic_sign=maxspeed 19063 Added
trolley_wire=yes 34577 ........ see #12135
wall=dry_stone 43074 Added
wall=no 10747377 Ignored. Used in French cadastre import
water=intermittent 269254 Deprecated. Validator Rule added.
waterway=rapids 44573 Keep the situation as is for now. Difficult case. Was removed from mappaint in r8135 and r8767. The tag is clearly garbage, however there is no replacement, so a deprecation warning is not possible.

Attachments (0)

Change History (67)

comment:1 Changed 4 years ago by Don-vip

In 9014/josm:

see #12102 - add crop=corn,grass,rice,wheat,hop to landuse=farmland preset

comment:2 Changed 4 years ago by Don-vip

Milestone: 15.11

comment:3 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:4 Changed 4 years ago by Don-vip

In 9015/josm:

see #12102 - add building=cabin,stable to Building preset

comment:5 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:6 Changed 4 years ago by Klumbumbus

There are some tags, which are neither deprecated, nor are they appropriate to use in a preset imho. Possible reasons are:

  • the definition is unclear
  • they are mainly used only in one country (and are maybe a result of an import), e.g. wall=no, living_street=yes
  • we previously decided to not add them (however we could rethink the dicision), e.g. highway=proposed
  • there is a similar tag, tagging scheme is undecided by community, e.g. amenity=swimming_pool, ice cream

Would it be possible to create a list where we add these tags, so they do not appear in the "tag not in presets" warning (info level)?

Last edited 4 years ago by Klumbumbus (previous) (diff)

comment:7 in reply to:  6 Changed 4 years ago by Don-vip

Replying to Klumbumbus:

Would it be possible to create a list where we add these tags, so they do not appear in the "tag not in presets" warning (info level)?

Agreed. Let's update the table with these information for the unclear/ambiguous tags, and I'll code the list.

comment:8 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:9 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:10 Changed 4 years ago by Don-vip

In 9023/josm:

see #12102 - cleanup TagChecker

  • code refactor/cleanup/simplification
  • clean list of ignored tags by removing tags that have been added to internal presets during past years
  • add unit test to detect these tags if we add new tags to internal presets that are currently being ignored

comment:11 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:12 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:13 Changed 4 years ago by Don-vip

In 9024/josm:

see #12102 - ignore Lifecycle tags

comment:14 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:15 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:16 Changed 4 years ago by Klumbumbus

In 9026/josm:

see #12102 - add placement to major road preset

comment:17 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:18 Changed 4 years ago by Klumbumbus

In 9027/josm:

see #12102 - add takeaway to meal presets

comment:19 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:20 Changed 4 years ago by Klumbumbus

In 9028/josm:

see #12102 - add tidal to water presets

comment:21 Changed 4 years ago by Klumbumbus

In 9029/josm:

see #12102 - add floating and mooring to pier preset

comment:22 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:23 Changed 4 years ago by Klumbumbus

In 9030/josm:

see #12102 - add some tags to ignore list

comment:24 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:25 Changed 4 years ago by Klumbumbus

In 9031/josm:

see #12102 - add service=crossover to railway presets and deprecate water=intermittent

comment:26 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:27 Changed 4 years ago by Don-vip

In 9033/josm:

see #12102 - add wall=dry_stone,noise_barrier to barrier=wall preset

comment:28 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:29 Changed 4 years ago by Don-vip

In 9034/josm:

see #12102 - add traffic_sign=maxspeed preset

comment:30 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:31 Changed 4 years ago by Don-vip

In 9035/josm:

see #12102 - add smoking=outside

comment:32 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:33 Changed 4 years ago by Don-vip

In 9036/josm:

see #12102 - add service=emergency_access to highway=service preset

comment:34 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:35 Changed 4 years ago by Don-vip

In 9037/josm:

see #12102 - add pipeline=marker preset + deprecate type for pipelines and pipeline markers (replaced by substance), see #10907

comment:36 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:37 Changed 4 years ago by Don-vip

In 9039/josm:

see #12102 - add military=airfield,barracks,bunker,range presets

comment:38 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:39 Changed 4 years ago by Don-vip

In 9040/josm:

see #12102 - deprecate landuse=farm in favour of landuse=farmland

comment:40 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:41 Changed 4 years ago by Don-vip

In 9041/josm:

see #12102 - ignore heritage, like admin_level

comment:42 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:43 Changed 4 years ago by Don-vip

In 9042/josm:

see #12102 - ignore wall=no

comment:44 Changed 4 years ago by Don-vip

In 9043/josm:

see #12102 - remove tags recently added to internal presets from ignored list

comment:45 Changed 4 years ago by Klumbumbus

In 9045/josm:

see #12102 - add military translation context, improve traffic sign display values, improve farm validator warning

comment:46 Changed 4 years ago by Klumbumbus

While the most areas with landuse=farm are indeed farmland there are also a lot which are farmyard. This misunderstanding was once the reason to invent farmland. So I changed the validator check.

comment:47 Changed 4 years ago by Klumbumbus

In 9046/josm:

see #12102 - adjust pipeline presets, add marker icon, see #10907

comment:48 Changed 4 years ago by Klumbumbus

pipeline marker icon [o31776]

comment:49 Changed 4 years ago by Don-vip

In 9047/josm:

see #12102 - ignore ref:*, CLC:*, local_authority:*

comment:50 Changed 4 years ago by Don-vip

I have started a patch for golf but I'm not sure to have time to finish it.
Presets/Golf_Course contains very nice SVG icons we could maybe reuse.

  • data/defaultpresets.xml

     
    49944994  </group>  <!-- Facilities -->
    49954995  <group name="Sports" icon="styles/standard/sport/soccer.png">
    49964996    <group name="Sport Facilities" icon="presets/stadium.png">
     4997        <group name="Golf" icon="styles/standard/sport/golf.svg">
     4998                <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
     4999                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5000                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5001                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5002                          fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5003                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5004                          pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5005                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5006                    <space />
     5007                    <key key="leisure" value="golf_course" />
     5008                    <reference ref="name_oh_wheelchair" />
     5009                </item> <!-- Golf Course -->
     5010                <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
     5011                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
     5012                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
     5013                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
     5014                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
     5015                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
     5016                          ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
     5017                    <space />
     5018                    <key key="leisure" value="miniature_golf" />
     5019                    <reference ref="name_oh_wheelchair" />
     5020                </item> <!-- Miniature Golf -->
     5021            <separator/>
     5022            <item name="Teeing Ground" type="node,closedway" preset_name_label="true">
     5023                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5024                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5025                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5026                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5027                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5028                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5029                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5030                <space />
     5031                <key key="golf" value="tee" />
     5032            </item> <!-- Teeing Ground -->
     5033            <item name="Hole" name_context="golf" type="way,closedway" preset_name_label="true">
     5034                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5035                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5036                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5037                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5038                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5039                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5040                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5041                <space />
     5042                <key key="golf" value="hole" />
     5043                <text key="ref" text="Reference" />
     5044                <text key="par" text="Par" />
     5045                <optional>
     5046                    <text key="name" text="Name" />
     5047                </optional>
     5048            </item> <!-- Hole -->
     5049            <item name="Pin" name_context="golf" type="node" preset_name_label="true">
     5050                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5051                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5052                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5053                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5054                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5055                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5056                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5057                <space />
     5058                <key key="golf" value="pin" />
     5059                <text key="ref" text="Reference" />
     5060            </item> <!-- Pin -->
     5061            <item name="Green" name_context="golf" type="closedway" preset_name_label="true">
     5062                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5063                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5064                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5065                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5066                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5067                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5068                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5069                <space />
     5070                <key key="golf" value="green" />
     5071            </item> <!-- Green -->
     5072            <item name="Bunker" name_context="golf" type="closedway" preset_name_label="true">
     5073                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=bunker" />
     5074                <space />
     5075                <key key="golf" value="bunker" />
     5076            </item> <!-- Bunker -->
     5077            <item name="Fairway" name_context="golf" type="closedway" preset_name_label="true">
     5078                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=fairway" />
     5079                <space />
     5080                <key key="golf" value="fairway" match="keyvalue!" />
     5081                <key key="surface" value="grass" />
     5082            </item> <!-- Fairway -->
     5083        </group> <!-- Golf -->
    49975084        <item name="Stadium" icon="styles/standard/sport/stadium.png" type="node,closedway" preset_name_label="true">
    49985085            <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=stadium"
    49995086                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=stadium"
     
    50535140            <text key="name" text="Name" />
    50545141            <combo key="sport" text="Sport" values="athletics,cycling,dog_racing,equestrian,horse_racing,running,skating" values_context="sport" />
    50555142        </item> <!-- Racetrack -->
    5056         <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
    5057             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
    5058                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
    5059                   es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
    5060                   fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
    5061                   ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
    5062                   pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
    5063                   pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
    5064             <space />
    5065             <key key="leisure" value="golf_course" />
    5066             <reference ref="name_oh_wheelchair" />
    5067         </item> <!-- Golf Course -->
    5068         <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
    5069             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
    5070                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
    5071                   es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
    5072                   ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
    5073                   pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
    5074                   ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
    5075             <space />
    5076             <key key="leisure" value="miniature_golf" />
    5077             <reference ref="name_oh_wheelchair" />
    5078         </item> <!-- Miniature Golf -->
    50795143    </group> <!-- Sport Facilities -->
    50805144    <group name="Sport" icon="presets/rowing.png">
    50815145        <item name="Multi" icon="styles/standard/sport/multi.png" type="node,closedway" preset_name_label="true">

comment:51 in reply to:  46 Changed 4 years ago by Don-vip

Replying to Klumbumbus:

While the most areas with landuse=farm are indeed farmland there are also a lot which are farmyard. This misunderstanding was once the reason to invent farmland. So I changed the validator check.

ok thanks :)

comment:52 Changed 4 years ago by Klumbumbus

In 9048/josm:

see #12102 - adjust military=barracks preset, add mappaint icon for pipeline=marker (fix #10907), fix mappaint icon for military=airfield

comment:53 Changed 4 years ago by Klumbumbus

In 9050/josm:

see #12102 - ignore man_made=petroleum_well, add validator warning for unusual value of admin_level

comment:54 Changed 4 years ago by Klumbumbus

In 9051/josm:

see #12102 - make validator text universal (prepared for later addition of e.g. heritage without new required i18n string)

comment:55 in reply to:  50 Changed 4 years ago by Klumbumbus

Replying to Don-vip:

I have started a patch for golf but I'm not sure to have time to finish it.
Presets/Golf_Course contains very nice SVG icons we could maybe reuse.

We can do this one and the rest of the list in the next milestone. I think we should stop adding new i18n strings today because of #12115.

comment:56 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:57 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:58 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:59 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:60 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:61 Changed 4 years ago by Klumbumbus

In 9052/josm:

see #12102 - remove mappaint of landuse=farm

comment:62 Changed 4 years ago by Klumbumbus

In 9053/josm:

see #12102 - add some tags to ignore list

comment:63 Changed 4 years ago by Klumbumbus

In 9054/josm:

see #12102 - add some tags to ignore list

comment:64 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed
Summary: Popular tags not in internal presetsPopular tags not in internal presets (1/2)

Let's close this one and continue the work for next milestone in #12135.

comment:65 Changed 4 years ago by Don-vip

In 9056/josm:

see #12102 - update presets lang

comment:66 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:67 Changed 4 years ago by Don-vip

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.