Modify

Opened 4 years ago

Closed 3 years ago

#12240 closed enhancement (fixed)

Add golf preset + new popular tags

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 16.02
Component: Internal preset Version:
Keywords: golf maintenance power seasonal Cc: Klumbumbus, tumsi

Description (last modified by Klumbumbus)

Last piece of work from #12135: add golf presets:

Tag (wiki) Count (taginfo) Decision
golf=bunker 64675 Added.
golf=fairway 24191 Added.

and these new tags:

Tag (wiki) Count (taginfo) Decision
maintenance=gritting 15620 Ignored Very local usage see taginfo map, and other (better) tags are availible
old_railway_operator=PRR 10038 Ignored (only US)
power=portal 10422 see #12297
seasonal=yes 14724 Added

Presets/Golf_Course contains very nice SVG icons we can reuse, as Klumbumbus said in #12135:

I asked tumsi and he allows us to use the golf svg icons. He also maybe can create new icons if needed for the tags in Presets/Golf_Course, which do not have an icon. (I did not yet check the tags).

I wrote an initial patch:

  • data/defaultpresets.xml

     
    49944994  </group>  <!-- Facilities -->
    49954995  <group name="Sports" icon="styles/standard/sport/soccer.png">
    49964996    <group name="Sport Facilities" icon="presets/stadium.png">
     4997        <group name="Golf" icon="styles/standard/sport/golf.svg">
     4998                <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
     4999                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5000                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5001                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5002                          fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5003                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5004                          pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5005                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5006                    <space />
     5007                    <key key="leisure" value="golf_course" />
     5008                    <reference ref="name_oh_wheelchair" />
     5009                </item> <!-- Golf Course -->
     5010                <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
     5011                    <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
     5012                          de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
     5013                          es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
     5014                          ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
     5015                          pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
     5016                          ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
     5017                    <space />
     5018                    <key key="leisure" value="miniature_golf" />
     5019                    <reference ref="name_oh_wheelchair" />
     5020                </item> <!-- Miniature Golf -->
     5021            <separator/>
     5022            <item name="Teeing Ground" type="node,closedway" preset_name_label="true">
     5023                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5024                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5025                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5026                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5027                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5028                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5029                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5030                <space />
     5031                <key key="golf" value="tee" />
     5032            </item> <!-- Teeing Ground -->
     5033            <item name="Hole" name_context="golf" type="way,closedway" preset_name_label="true">
     5034                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5035                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5036                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5037                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5038                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5039                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5040                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5041                <space />
     5042                <key key="golf" value="hole" />
     5043                <text key="ref" text="Reference" />
     5044                <text key="par" text="Par" />
     5045                <optional>
     5046                    <text key="name" text="Name" />
     5047                </optional>
     5048            </item> <!-- Hole -->
     5049            <item name="Pin" name_context="golf" type="node" preset_name_label="true">
     5050                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5051                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5052                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5053                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5054                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5055                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5056                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5057                <space />
     5058                <key key="golf" value="pin" />
     5059                <text key="ref" text="Reference" />
     5060            </item> <!-- Pin -->
     5061            <item name="Green" name_context="golf" type="closedway" preset_name_label="true">
     5062                <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
     5063                      de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
     5064                      es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
     5065                      fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
     5066                      ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
     5067                      pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
     5068                      pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
     5069                <space />
     5070                <key key="golf" value="green" />
     5071            </item> <!-- Green -->
     5072            <item name="Bunker" name_context="golf" type="closedway" preset_name_label="true">
     5073                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=bunker" />
     5074                <space />
     5075                <key key="golf" value="bunker" />
     5076            </item> <!-- Bunker -->
     5077            <item name="Fairway" name_context="golf" type="closedway" preset_name_label="true">
     5078                <link href="http://wiki.openstreetmap.org/wiki/Tag:golf=fairway" />
     5079                <space />
     5080                <key key="golf" value="fairway" match="keyvalue!" />
     5081                <key key="surface" value="grass" />
     5082            </item> <!-- Fairway -->
     5083        </group> <!-- Golf -->
    49975084        <item name="Stadium" icon="styles/standard/sport/stadium.png" type="node,closedway" preset_name_label="true">
    49985085            <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=stadium"
    49995086                  de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=stadium"
     
    50535140            <text key="name" text="Name" />
    50545141            <combo key="sport" text="Sport" values="athletics,cycling,dog_racing,equestrian,horse_racing,running,skating" values_context="sport" />
    50555142        </item> <!-- Racetrack -->
    5056         <item name="Golf Course" icon="styles/standard/sport/golf.svg" type="node,closedway" preset_name_label="true">
    5057             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=golf_course"
    5058                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=golf_course"
    5059                   es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=golf_course"
    5060                   fr.href="http://wiki.openstreetmap.org/wiki/FR:Tag:leisure=golf_course"
    5061                   ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=golf_course"
    5062                   pt.href="http://wiki.openstreetmap.org/wiki/Pt:Tag:leisure=golf_course"
    5063                   pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=golf_course" />
    5064             <space />
    5065             <key key="leisure" value="golf_course" />
    5066             <reference ref="name_oh_wheelchair" />
    5067         </item> <!-- Golf Course -->
    5068         <item name="Miniature Golf" icon="styles/standard/sport/miniature_golf.svg" type="node,closedway" preset_name_label="true">
    5069             <link href="http://wiki.openstreetmap.org/wiki/Tag:leisure=miniature_golf"
    5070                   de.href="http://wiki.openstreetmap.org/wiki/DE:Tag:leisure=miniature_golf"
    5071                   es.href="http://wiki.openstreetmap.org/wiki/ES:Tag:leisure=miniature_golf"
    5072                   ja.href="http://wiki.openstreetmap.org/wiki/JA:Tag:leisure=miniature_golf"
    5073                   pt_BR.href="http://wiki.openstreetmap.org/wiki/Pt-br:Tag:leisure=miniature_golf"
    5074                   ru.href="http://wiki.openstreetmap.org/wiki/RU:Tag:leisure=miniature_golf" />
    5075             <space />
    5076             <key key="leisure" value="miniature_golf" />
    5077             <reference ref="name_oh_wheelchair" />
    5078         </item> <!-- Miniature Golf -->
    50795143    </group> <!-- Sport Facilities -->
    50805144    <group name="Sport" icon="presets/rowing.png">
    50815145        <item name="Multi" icon="styles/standard/sport/multi.png" type="node,closedway" preset_name_label="true">

Attachments (0)

Change History (16)

comment:1 Changed 4 years ago by Don-vip

Milestone: 16.0116.02

comment:2 Changed 4 years ago by Don-vip

Description: modified (diff)
Keywords: maintenance power seasonal added
Summary: [draft patch] Add golf preset[draft patch] Add golf preset + new popular tags

comment:3 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:4 Changed 4 years ago by Don-vip

In 9322/josm:

see #12240 - add taginfo test for popular tags - ignore unknown tags until their fate is decided (added, ignored, or deprecated)

comment:5 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:6 Changed 4 years ago by Klumbumbus

In 9425/josm:

see #12240 - add seasonal=yes to waterways and wetland, adjust intermittent; move ignored tags

comment:7 Changed 4 years ago by Klumbumbus

Description: modified (diff)

comment:8 Changed 3 years ago by Klumbumbus

Owner: changed from team to Klumbumbus

comment:9 Changed 3 years ago by Klumbumbus

In 9640/josm:

see #12240 - add golf preset group (icons by tumsi, see [o32026])

comment:10 Changed 3 years ago by Klumbumbus

Owner: changed from Klumbumbus to team

tumsi, we need an icon for "Driving range", would you like to create one?

comment:11 Changed 3 years ago by Klumbumbus

In 9641/josm:

see #12240 - remove golf tags from validator ignore list

comment:12 Changed 3 years ago by Klumbumbus

Summary: [draft patch] Add golf preset + new popular tagsAdd golf preset + new popular tags

comment:13 Changed 3 years ago by Klumbumbus

Description: modified (diff)

comment:14 Changed 3 years ago by Klumbumbus

In 9650/josm:

see #12240 - small fixes to golf=bunker preset

comment:15 Changed 3 years ago by Klumbumbus

In 9654/josm:

see #12240 - add golf=driving_range icon, icon see [o32029]

comment:16 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

I just made a driving_range icon :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.