source: josm

checkstyle

fix #24160, fix typo

fix #24016 - better visibility of correlation status, patch by StephaneP

fix #21007, fix failing unit test, patch by StephaneP

increase possible number of steps for zooming, see #24145

checkstyle

see #24104, add deprecated dates for remaining used functions, patch by gaben (stripped down a lot)

see #21007 - now add the missing file I was sure I already added

fix #24137 : Wrong plural in Warning message?

update i18n

fix #24121, fix null access

fix CID 1591123, add missing break

Fix most new PMD issues

It would be better to use the newer switch syntax introduced in Java 14 (JEP 361),
but we currently target Java 11+. When we move to Java 17, this should be
reverted and the newer switch syntax should be used.

add Taylor

update pmd

Revert errorprone to 2.31 since that was the last version to officially work on Java 11

fix another valid PMD complain

Fix compile errors

remove most of the new PMD messages

See #23913: Fetch remote API keys for Bing imagery

Update JMapViewer and other dependencies

Fix tests broken by r19289

Fix #24097: Zoom to imagery layer

This fixes two issues:

1. Adds implementation for visitBoundingBox used by the Zoom to layer action
2. Uses addLayer(Layer, boolean) to avoid zooming to the bounds of the layer on layer add

Also, clean up some deprecation warnings.

I18n update, see #24067

Fix #24075: Reduce memory allocations for TaggingPresetItem#matches

This is done by doing the following:

• Converting KeyedItem.match to a MatchType from a String
  • This avoids calling MatchType#ofString repeatedly
  • This does decrease the visibility of the match field and change the type
• Avoiding ArrayList.Itr creation in TaggingPresetItem#matches
  • This does produce some duplicate code, unfortunately.

The KeyedItem.match change reduces memory allocations in KeyedItem#matches by
98% and CPU cycles by 77%.
The TaggingPresetItem#matches change to avoid ArrayList.Itr creation reduces
memory allocations by 100% and CPU cycles by 94% for ArrayList (only looking at
changes between the for loop types).

The net change for TaggingPresetItem#matches is a reduction of memory
allocations by 99% and CPU cycles by 74%. As noted in the ticket, there was a
reduction in GC by ~80%.

see #24067 - I18n update

converted_by no longer exists in the database, stop handling it special

fix #24037

• revert the changes from r17423 in GenericRelationEditor
• use GuiHelper.runInEDT() to avoid the EDT violations reported in #20228

i18n update

checkstyle

fix #24054 - no longer silently ignore identical or mismatching asserts in mapcss tag checker

Fix a performance issue when working with large datasets

The primary issue is that the collection passed to the resetTiles method is a
filtered collection with no defined size. In order to calculate the size, it must
iterate through the collection which becomes expensive with large datasets.

The fix for this is to remove the dependency on the size of the dataset, and just
look at the number of primitives passed in.

In addition, if the current renderer is not StyledTiledMapRenderer, clear the cache and return.

silence PMD - some of these rules are bullshit - explicit initialization is always better than default ones even if it costs a little space

Fix #22035: Add preset amenity=driver_training (patch by SteveLz, modified)

Modifications are as follows:

• Add similar but different tag links
• Add rendering for amenity=driver_training when it is a node

amenity=driver_training is different from amenity=driving_school in that
amenity=driver_training is where the student driver can physically drive a
vehicle for practice. amenity=driving_school may also teach theoretical driving
practices and may have physical training aids.

i18n updates

indicate possible shortcuts for parser

See #24014: Add multiline and normalize attributes to preset xsd

normalize="false" will prevent all whitespace normalization while
normalize="true" + multiline="true" will strip start and end whitespace and
inner whitespace that is not newlines.

The primary reason for this change is ​osmwiki:Key:inscription which can have
newlines in order to match the inscription.

This does not modify UI elements to support multiline editing.

fix #23943 - patch by Famlam - allow negative values for substring to count from the end of the string

fix #23932 - patch by huntertur - Add cycleway:*:buffer to Highways/Ways/Cycle Lane/Track preset

fix URL joining for WMTS when URL comes from capabilities and doesn't end in a separation, fix #23980

Fix #23988: Add api.openhistoricalmap.org as a possible endpoint for OHM when getting the default client id (patch by Rub21)

Dependency updates

Most plugins have been moved to require a minimum version of r19044 (mostly for
Java 11+ build reasons).

Fix #23978: Windows does not like paths with multiple :

This fixes an issue where a gpx track with attached images could cause an
exception.

Fix #23950: Fix a StackOverflowError that occurs when a self-referencing relation exists

Also disable StyledTiledMapRendererTest in CI for now.

Fix #23253: Remove landuse=paddy from the ignore list

It looks like most of the landuse=paddy uses were removed (probably from a
revert).

See r19242: Ensure that seasonal is removed when it is seasonal=no

forgot Bopo, see #23964

see #23184 - Change color of bus in busway icon from black to blue to be more consistent with similar icons, e.g. steps, bicycle_road, living_street or pedestrian

See #23948: Fix url type (faq to help for /wiki/Help) and add a link for contribute

This additionally adds system requirements (both required and recommended).
The memory requirements comes from downloading
39.0642941;-108.5662508;39.0654645;-108.5642928
and displaying the Mesa County GIS Valleywide 2024 imagery. This was after a GC
was triggered manually; as such, JOSM is technically usable.

Fix #23956: JsonParsingException when the destination server returns 200 and a malformed document

In this case, the destination server performed a redirect via javascript in the
response.

drop list url, see #23948