[Reporting PATCH] Keep wrapped ReportedException data sections

[richlv]

Exception after resizing the image viewing window.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-08-28 22:00:04 +0200 (Wed, 28 Aug 2024)
Revision:19207
Build-Date:2024-08-29 01:30:31
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19207 en) Windows 10 64-Bit
OS Build number: Windows 10 Pro 22H2 (19045)
Memory Usage: 1920 MB / 8096 MB (1283 MB allocated, but free)
Java version: 21.0.1+12-29, Oracle Corporation, OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1200x32bpp@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: UTF-8
System property sun.jnu.encoding: Cp1252
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Dataset consistency test: No problems found

Plugins:
+ InfoMode (36126)
+ Mapillary (1776)
+ PicLayer (1.0.3)
+ apache-commons (36282)
+ buildings_tools (36226)
+ ejml (36176)
+ geotools (36273)
+ imagery_offset_db (36289)
+ jackson (36273)
+ jaxb (36118)
+ jts (36004)
+ measurement (36256)
+ opendata (36327)
+ reltoolbox (36298)
+ reverter (36320)
+ undelete (36298)
+ utilsplugin2 (36298)

Last errors/warnings:
- 00344.975 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00344.976 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00344.977 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00344.979 W: Already here java.net.SocketTimeoutException: Read timed out
- 00344.980 W: Already here java.net.SocketTimeoutException: Read timed out
- 00344.980 W: Already here java.net.SocketTimeoutException: Read timed out
- 00417.941 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00419.305 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 00419.789 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 03669.342 E: Handled by bug report queue: org.openstreetmap.josm.tools.bugreport.ReportedException: java.lang.ArrayIndexOutOfBoundsException. Cause: java.lang.ArrayIndexOutOfBoundsException



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (48) of main
ReportedException [thread=Thread[#88,ForkJoinPool.commonPool-worker-15,5,main], exception=java.lang.ArrayIndexOutOfBoundsException, methodWarningFrom=null]
	at org.openstreetmap.josm.tools.bugreport.BugReport.intercept(BugReport.java:213)
	at org.openstreetmap.josm.gui.util.imagery.CameraPlane.lambda$commonFastByteMapping$8(CameraPlane.java:333)
	at java.base/java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:104)
	at java.base/java.util.stream.IntPipeline$Head.forEach(IntPipeline.java:617)
	at org.openstreetmap.josm.gui.util.imagery.CameraPlane.lambda$commonFastByteMapping$9(CameraPlane.java:313)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfInt.accept(ForEachOps.java:205)
	at java.base/java.util.stream.Streams$RangeIntSpliterator.forEachRemaining(Streams.java:104)
	at java.base/java.util.Spliterator$OfInt.forEachRemaining(Spliterator.java:712)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
	at java.base/java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:754)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
Caused by: java.lang.ArrayIndexOutOfBoundsException

[taylor.smock]

Similar: #22590

The code from r19088 is supposed to give me more information to debug stuff. It isn't, apparently.

[taylor.smock]

When I manually cause it to throw an exception, it gives me the information I wanted.

This should fix that particular issue:

src/org/openstreetmap/josm/tools/bugreport/BugReport.java

@@ -159 +159 @@
         }
         if (isIncludeData()) {
             exception.printReportDataTo(out);
+            // Exceptions thrown in threads *may* be automatically wrapped by the thread handler (ForkJoinPool, etc.)
+            // We want to keep the data saved in the child exceptions, so we print that as well.
+            Throwable cause = exception.getCause();
+            while (cause != null) {
+                if (cause instanceof ReportedException) {
+                    ((ReportedException) cause).printReportDataTo(out);
+                }
+                cause = cause.getCause();
+            }
         }
         exception.printReportStackTo(out);
         if (isIncludeAllStackTraces()) {

The bug report functionality is kind of critical, so I want to give other maintainers a chance to yell at me. :)

[taylor.smock]

In 19246/josm:

Fix #23920: Wrapped ReportedException don't keep data on bug report