[PATCH] Add/ignore popular tags

[taylor.smock]

Add

• generator:solar:tracking: See ​osmwiki:Key:generator:solar:tracking
• natural=earth_bank: See ​osmwiki:Tag:natural=earth_bank
• highway=busway: See ​osmwiki:Tag:highway=busway
• school:gender: See ​osmwiki:Key:school:gender
• craft=electronics_repair: See ​osmwiki:Tag:electronics_repair
• place=municipality: See ​osmwiki:Tag:place=municipality

Ignore

• check_date:?*: Used by surveying applications (fix #23182)
• boundary=religious_administration: Not well documented

Replace

• landuse=reservoir: Deprecated by ​osmwiki:Proposal:Reservoir_(2020) and replaced by ​osmwiki:water=reservoir, see #23185

For now, I'm ignoring:
cyclestreet=yes - 12117 - We have a similar preset already, and we don't currently filter presets based off of location. The GSOC student this year implemented something for this which I need to merge.
leisure=dance - 10101 - I don't know how to make a "good" icon for this
trailblazed=symbols - 31527 - Approved proposal; not really a top-level tag, but also not something that I feel like we should be adding to all highway presets.

[taylor.smock]

Ticket #23185 has been marked as a duplicate of this ticket.

[taylor.smock]

Update reservoir preset

[taylor.smock]

In 18843/josm:

Fix #23184: Add/ignore popular tags

Add

• generator:solar:tracking: See ​osmwiki:Key:generator:solar:tracking
• natural=earth_bank: See ​osmwiki:Tag:natural=earth_bank
  • Icon drawn by taylor.smock
• highway=busway: See ​osmwiki:Tag:highway=busway
  • Icon from merging way_residential.svg and bus.svg
• school:gender: See ​osmwiki:Key:school:gender
• craft=electronics_repair: See ​osmwiki:Tag:electronics_repair
  • Icon drawn by taylor.smock
• place=municipality: See ​osmwiki:Tag:place=municipality
  • municipality.svg is largely copied from city.svg, color modified

Ignore

• check_date:?*: Used by surveying applications (fix #23182)
• boundary=religious_administration: Not well documented

Replace

• landuse=reservoir: Deprecated by ​osmwiki:Proposal:Reservoir_(2020) and replaced by ​osmwiki:water=reservoir (fix #23185)
  • tailings_pond.svg is a modified reservoir.svg icon; ​osmwiki:Tag:man_made=tailings_pond is a replacement for landuse=reservoir + reservoir_type=tailings.

This additionally fixes an issue discovered by gaben in #23183, whereby
values_from="java.util.Locale#getISOCountries" could have some values
translated. This was fixed by adding a values_context attribute; in this case,
I used "country codes".

[gaben]

Ooops, in line 75 in deprecated.mapcss missing the comment block.

[taylor.smock]

I noticed; I've got a local patch for it. I'm just waiting to see if my fix for TagEditHelperTest.testTicket23191() succeeds before I upload it.

[gaben]

Btw, what editor are you using? I'm thinking about a syntax highlighter plugin for IJ. For VSCode there is already ​one.

[taylor.smock]

what editor are you using

IntelliJ IDEA. :)

I started working on a syntax highlighter plugin, but I got stuck on writing the grammar file. I still have a copy of it locally, if you want to take a look (I'll make a repo on GitHub for it, if you want to look at it).

[gaben]

Oh wow, yes, thank you!

My other concern is the incomplete MapCSS definition. I checked the pages in the past, and I'm amazed at how it is possible to build something based on the available information. Also, there are the software-specific extensions.

[taylor.smock]

I'll make a repo on GitHub for it

Have a link to the (currently) broken source code: ​https://github.com/JOSM/MapCSS_IntelliJIDEA_Plugin/tree/main

[taylor.smock]

Ticket retargeted after milestone deleted

[taylor.smock]

Ticket retargeted after milestone deleted

[Klumbumbus]

In 19239/josm:

see #23184 - Change color of bus in busway icon from black to blue to be more consistent with similar icons, e.g. steps, bicycle_road, living_street or pedestrian