josm preset for water reservoir

[anonymous]

The Josm preset for water/water/reservoir uses tag landuse=water.
I expect it should tag as natural=water plus water=reservoir
​https://wiki.openstreetmap.org/wiki/Key:water states at the bottom...
landuse=reservoir ‒ This tag is deprecated, the current tagging is natural=water + water=reservoir.

[taylor.smock]

Closed as duplicate of #23184.
​osmwiki:Tag:landuse=reservoir was deprecated by ​osmwiki:Proposal:Reservoir_(2020) (vote ended 2022-01-31). I think I'll wrap this into #23184.

[taylor.smock]

In 18843/josm:

Fix #23184: Add/ignore popular tags

Add

• generator:solar:tracking: See ​osmwiki:Key:generator:solar:tracking
• natural=earth_bank: See ​osmwiki:Tag:natural=earth_bank
  • Icon drawn by taylor.smock
• highway=busway: See ​osmwiki:Tag:highway=busway
  • Icon from merging way_residential.svg and bus.svg
• school:gender: See ​osmwiki:Key:school:gender
• craft=electronics_repair: See ​osmwiki:Tag:electronics_repair
  • Icon drawn by taylor.smock
• place=municipality: See ​osmwiki:Tag:place=municipality
  • municipality.svg is largely copied from city.svg, color modified

Ignore

• check_date:?*: Used by surveying applications (fix #23182)
• boundary=religious_administration: Not well documented

Replace

• landuse=reservoir: Deprecated by ​osmwiki:Proposal:Reservoir_(2020) and replaced by ​osmwiki:water=reservoir (fix #23185)
  • tailings_pond.svg is a modified reservoir.svg icon; ​osmwiki:Tag:man_made=tailings_pond is a replacement for landuse=reservoir + reservoir_type=tailings.

This additionally fixes an issue discovered by gaben in #23183, whereby
values_from="java.util.Locale#getISOCountries" could have some values
translated. This was fixed by adding a values_context attribute; in this case,
I used "country codes".

[taylor.smock]

Ticket retargeted after milestone deleted

[taylor.smock]

Ticket retargeted after milestone deleted