Modify

Opened 7 months ago

Closed 5 months ago

Last modified 5 months ago

#23945 closed enhancement (fixed)

[PATCH] ImageViewerDialog.displayImages() - do not re-center if the image has not changed

Reported by: IreuN Owned by: team
Priority: normal Milestone: 24.12
Component: Core image mapping Version:
Keywords: Cc:

Description (last modified by gaben)

Hello!

I'm asking you if mention method could be changed to not zoom map to the image, in case the image is the same one.
This could be benefitial to Mapillary plugin, which has to re-display the image after sequence has been downloaded (without it, the previous/next buttons are disabled.

as i can see there is already imageChanged = currentEntry != entry; which could be fed to the if statement.

            imageChanged = currentEntry != entry;

            if (centerView && entry != null && MainApplication.isDisplayingMapView() && entry.getPos() != null) {
                MainApplication.getMap().mapView.zoomTo(entry.getPos());
            }

josm/trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java#L893

Attachments (1)

78e599ef8d48e96abbec01c697e6987f8dc4d7e5.patch (1.1 KB ) - added by IreuN 7 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 by IreuN, 7 months ago

Video of what this causes: https://streamable.com/osypzs

comment:3 by IreuN, 7 months ago

Summary: ImageViewerDialog.displayImages() - do not re-center if the image has not changed[PATCH] ImageViewerDialog.displayImages() - do not re-center if the image has not changed

comment:4 by gaben, 7 months ago

Component: CoreCore image mapping
Description: modified (diff)

comment:5 by taylor.smock, 5 months ago

Resolution: fixed
Status: newclosed

In 19266/josm:

Fix #23945: ImageViewerDialog.displayImages() - do not re-center if the image has not changed (patch by IreuN)

comment:6 by taylor.smock, 5 months ago

Milestone: 24.12

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.