source: josm

see #23184 - Change color of bus in busway icon from black to blue to be more consistent with similar icons, e.g. steps, bicycle_road, living_street or pedestrian

See #23948: Fix url type (faq to help for /wiki/Help) and add a link for contribute

This additionally adds system requirements (both required and recommended).
The memory requirements comes from downloading
39.0642941;-108.5662508;39.0654645;-108.5642928
and displaying the Mesa County GIS Valleywide 2024 imagery. This was after a GC
was triggered manually; as such, JOSM is technically usable.

Fix #23956: JsonParsingException when the destination server returns 200 and a malformed document

In this case, the destination server performed a redirect via javascript in the
response.

drop list url, see #23948

ShortcutTest: Determine if HTML is supported before asserting against an HTML string

This does a few things:

• Ensures that the test will work properly if the default LaF is *not* Aqua (the default macOS LaF)
• If Aqua ever supports HTML in menu tooltips, we will only have to change one location
• Fewer locations to worry about in unit tests if we change the default LaF for mac to something else

remove TLD from IANA

Fix #20908: IllegalStateException: JOSM expected to find primitive in dataset after undoing a Parallel mode action

The test acts (roughly) like a user would, and performs click and drags via a new
utility class (MapModeUtils) which has various methods for performing mouse
actions on the map view.

Fix #23925: Indicate/link to alternative download methods when the user attempts to download too much data

Add JUnit5 tags to integration tests, functional tests, and performance tests

This should allow contributors to filter out integration tests inside the standard
test directory. Of specific note, this should reduce test runtime for contributors
by a non-trivial amount if contributors filter out the tagged tests.

For consistencies’ sake, tests in functional and performance were also
annotated. As such, if we ever merge the test directories, this will let us
filter which tests are run in CI.

Note that many functional tests don't have the annotation. This is because they
are manual tests.

Fix failing build due to putting unit test for renderer in unit instead of functional

This was done by fixing a TODO comment ("move to separate class ImageTestUtils")
in the MapCSSRendererTest.

See #23837: Set -XX:MaxRAMPercentage to >25% of system memory

Drop RAM arguments since it causes issues with OWS.

Fix #23911: wireframe was not properly highlighting relations

This was a regression from r19166.

Fix #23837: Set -XX:MaxRAMPercentage to >25% of system memory

This does not currently work for WebStart, see
​https://github.com/AdoptOpenJDK/IcedTea-Web/pull/954 .

As noted in the ticket, all supported MS Windows and Apple macOS machines have
4G+ of RAM. Linux machines don't have a baseline, and some have 1G or less. Where
we detect that a machine has <8G of memory in the linux start scripts, we don't
add the JVM parameters.

As a reminder to everyone reading the changelog: just because we ask for the
ability to use 75% of the system memory doesn't mean we will use all of that
memory. The JVM will free up unused memory for the rest of the system.

We additionally set the minimum memory allocation to 256m; while this can be
lower, that is for minimal amounts of data loaded. A clean JOSM install will use
99mb, for example. But once we add a minimal amount of data and a background
layer, static memory usage goes up to 161mb.

fix SyncEditorLayerIndex script

make cache file length configurable, ensure it's below 140 - encrypted ext4 seems to have a 143 byte limit, see #23850

Add @Plugins annotation to clean up after plugins have been loaded in tests

This should help reduce the issues related to plugins not being unloaded after
PluginHandlerTestIT when tests are run locally with a UI -- the primary cause
of problems is the SDS plugin though.

i18n updates

Fix keyboard navigation in the mapview on MacOS

This also adds default shortcuts for mission control and showing all windows of
the currently focused application.

See ​https://web.archive.org/web/20240828134626/https://support.apple.com/en-us/102650 .

Add properties to pom.xml to make it easier to synchronize versions with plugins

Also use /public for the repository instead of having one for /central, one
for /releases, and one for /snapshots.

Fix #23290: Exclude incomplete relations from region checks

Also rework TagCheckerTest to use parameterized tests.

see #21856, fix typo

Fix #21856: Split way: Wrong position of new member in PTv2 relation splitting a loop

Fix #23860: Duplicate key+value in preset causes an ISE in TagChecker

This fixes the actual issue in TagChecker, but also adds a sanity check to
TaggingPresetPreferenceTestIT since it is usually unintended to have
duplicate key/values (and it is always a problem if they are different and are
Key items).

The fix for TagChecker is just keeping whatever value is last. Not ideal, but
it should work 99% of the time since an object won't match the preset if we have
highway=footway and highway=footway2 as Key objects.

Add/ignore documented popular tags

Add

• ​osmwiki:Tag:office=financial -- icon derived from tax_advisor.svg

Dependency updates

ivy.xml

• org.openstreetmap.jmapviewer:jmapviewer: 2.20 -> 2.21 (see #23841)
• org.eclipse.parsson:parsson: 1.1.6 -> 1.1.7
• org.apache.commons:commons-compress: 1.26.2 -> 1.27.0
• org.tukaani:xz: 1.9 -> 1.10 (PD -> 0BSD)
• org.webjars.npm:tag2link: 2024.7.8 -> 2024.8.12

tools/ivy.xml

• net.sourceforge.pmd:pmd: 7.3.0 -> 7.4.0
• com.google.errorprone:error_prone: 2.29.2 -> 2.30.0

nitpicking software...

Remove/fix unused icons

rocket.svg was only used for getting people to update from WebStart to
OpenWebStart. Since we no longer support Oracle WebStart, we can remove
rocket.svg.

output the ULP factor in case of an error

Fix #22852: Add missing area rendering for emergency=lifeguard

PMD fixes

Fix #23802: Backup preferences files get overwritten by bad preference files

This validates a preferences file before copying/moving it to another file.
This should avoid cases where a file is partially written and then copied or
moved over a "good" preferences file.

fix #23849 - provide option to reduce loglevel to warnings

Fix #23846: Setting all referrers downloaded doesn't happen if the target object has been modified

This may also fix (or partially fix) #23808 and #23810.

Add/ignore documented popular tags

Add

• ​osmwiki:Tag:man_made=cairn

Remove some values from ignoretags.cfg

Add/ignore documented popular tags

Add

• ​osmwiki:Tag:leaf_type=palm is a subset of ​osmwiki:Tag:leaf_type=broadleaved
• ​osmwiki:Tag:entrance=secondary
• ​osmwiki:Tag:surface=stone
• ​osmwiki:Tag:surface=woodchips
• ​osmwiki:Tag:bicycle=customers
• ​osmwiki:Tag:building=container
• ​osmwiki:Tag:parking_space=charging
• ​osmwiki:Tag:cycleway:left:lane=exclusive
• ​osmwiki:Tag:cycleway:right:lane=exclusive
• ​osmwiki:Tag:cycleway:both:lane=exclusive
• ​osmwiki:Tag:crossing=informal
• ​osmwiki:Tag:wall=concrete
• ​osmwiki:Tag:frontage_road=yes
• ​osmwiki:Tag:barrier=wicket_gate -- image drawn by taylor.smock.
• ​osmwiki:Tag:highway=emergency_bay -- image drawn by taylor.smock.
• ​osmwiki:Tag:service=slipway
• ​osmwiki:Tag:amenity=music_school -- image drawn by taylor.smock with elements from other education svg
• ​osmwiki:Tag:amenity=vehicle_inspection -- inspection was also added to shop=car_repair service types. Note that the wiki has been changed to service:vehicle instead of service, so our preset for shop=car_repair does not match wiki docs. Additionally added alternate service tagging for shop=car_repair. vehicle_inspection.svg is from ​https://wiki.openstreetmap.org/wiki/File:Vehicle_inspection-14.svg (CC0, Geozeisig).
• ​osmwiki:Tag:amenity=social_centre -- image drawn by taylor.smock. A better icon would be much appreciated.
• ​osmwiki:Tag:amenity=trolley_bay -- image drawn by taylor.smock. A better icon would be nice.
• ​osmwiki:Tag:shop=craft -- image drawn by taylor.smock.
• ​osmwiki:Tag:shop=agrarian -- image drawn by taylor.smock
• ​osmwiki:Tag:climbing=route_bottom and ​osmwiki:Tag:climbing=route_top -- image parts taken from climbing.svg
• ​osmwiki:Tag:toilets:access=customers -- added to various presets where it may be common for there to be toilets available to customers

Ignored tags:

• ​osmwiki:Tag:valley=balka -- seems to be done primarily by one or two people, highly concentrated in Russia.
• ​osmwiki:Tag:meadow=meadow_orchard -- similar to ​osmwiki:Tag:orchard=meadow_orchard, which we also ignore.
• ​osmwiki:Tag:natural=landform and ​osmwiki:Tag:landform=esker -- primarily from the canvec import

Note:
Most gate barriers were changed to either be a node or a way, as it allows for
people to micromap.

Fix #23830: Slow selection when there is a lot of data

We were previously iterating through all nodes and ways when making a selection.
We don't have to do that since we have a way to efficiently find objects in a
bbox.

Fix #23298: Improper warning for aerialway=zip_line

Exclude aerialway from combinations check and add usage values to aerialway
presets (where someone has already used the key with the aerialway tag).

Fix #21801: Add railway junction check for missing switches and crossings (patch by gaben)

Additional notes:
If a mapper has left non-existent railways in OSM, then this will produce false positives.
With that said, non-existent railways don't belong in OSM.

See #23220: Remove jsr305 from dependencies (patch by sebastic)

I (taylor.smock) didn't remove the dependencies from the sources section in r19148.

i18n updates

Fix #23600: Replace macos-14 with macos-latest in GitHub actions for building mac release files

GitHub macos-latest is now equivalent to macos-14.

Fix tests broken by r19152

Fix #23821: Ensure that a new layer is loaded prior to loading additional data to that layer

This occurred due to a race condition, whereby the /load_and_zoom call would
return immediately prior to the download finishing for the new layer and the
next /load_and_zoom call merging onto a pre-existing layer.

This could be fixed in one of two different ways:

1. Block the RemoteControl thread
2. Have some method for ensuring that a new layer is loaded first

While we are effectively doing (1), it was easier to do (2) as well for testing
purposes. This means the RemoteControl thread could spin off a thread for each
request to /load_and_zoom and this particular issue should not reappear.

This does not control for cases where a user calls /load_and_zoom like so:

1. new_layer=true + layer_name=first
2. new_layer=true + layer_name=second
3. new_layer=false + layer_name=first
4. new_layer=false + layer_name=second

Both (1) and (2) will complete before (3) and (4) are run. However, both (3) and
(4) will be loaded into the last layer loaded.

adapt message, patch by Famlam, see #23621

Bump error prone from 2.29.0 to 2.29.1

This fixes an issue where the PBF plugin would fail to build.
For additional details, see ​https://github.com/google/error-prone/issues/4475 .

fix #23392: JOSM doesn't work well when not maximized

• use SwingUtilities.invokeLater() for the AlignImageryPanel

Fix #23721: Application hangs indefinitely if Bing API unavailable

This adds a progress monitor that the user can cancel if Bing attribution doesn't
load quickly enough. This additionally removes the need for Thread.sleep calls
by using a timer thread.

This requires an update to the JMapViewer dependency.

Fix #23804: xdg-open can return a 0 exit code when a browser doesn't open

This is alleviated by switching the default order of browser.unix to be
#DESTKOP then xdg-open. #DESKTOP is our magic value for using built-in
Java methods for opening a browser.

It appears that there is a race condition somewhere for the Brave browser.
I suspect that the process returned by the Runtime.exec and xdg-open isn't
actually complete when it says it is, and so the process is cleaned up prior to
Brave actually launching.

See #23804: Try to detect common failures with OpenBrowser.displayUrl

In #23804, the user indicated that the web browser did not open, so they were
unable to go through the automatic authentication flow. This attempts to work
around that problem by detecting caught exceptions and showing the user a dialog
that will allow them to copy the authorization URL.