#21856 reopened defect

[PATCH] Split way: Wrong position of new member in PTv2 relation splitting a loop

Reported by:	skyper	Owned by:	team
Priority:	major	Milestone:	23.09
Component:	Core	Version:	latest
Keywords:	template_report split way route relation order member loop	Cc:

Description

What steps will reproduce the problem?

Have an ordered PTv2 relation containing a small loop, see ptv2_relation_loop_split.osm.xz
Split the loop (at the node Split)

What is the expected result?

The new member is added at the correct position.

What happens instead?

The new member is added at the wrong position leading to a gap.

Please provide any additional information below. Attach a screenshot if possible.

Similar to #19288 and not new, but I stumbled over it again.
It does not matter which of the two parts keeps the existing OSM id.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-02-10 22:03:15 +0100 (Thu, 10 Feb 2022)
Revision:18379
Build-Date:2022-02-11 02:31:13
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18379 en) Linux Debian GNU/Linux 11 (bullseye)
Java version: 17.0.2+8-Debian-1deb11u1, Debian, OpenJDK 64-Bit Server VM

Change History (24)

Changed 20 months ago by skyper

Attachment:	ptv2_relation_loop_split.osm.xz added

example file

comment:1 follow-up: 7 Changed 14 months ago by skyper

Still a problem, see changeset/123863615 and changeset/124259191 fixed in changeset/124933875

comment:2 Changed 14 months ago by skyper

Priority:	normal → major

comment:3 Changed 14 months ago by taylor.smock

#19217/#18018 are also similar.

comment:4 Changed 14 months ago by skyper

At least for PTv2 #19534 would be really helpful in general and could warn the users about the current problems with loops.

Changed 14 months ago by taylor.smock

Attachment:	21856.patch added

comment:5 Changed 14 months ago by taylor.smock

Milestone:	→ 22.08
Summary:	Split way: Wrong position of new member in PTv2 relation splitting a loop → [PATCH] Split way: Wrong position of new member in PTv2 relation splitting a loop

@skyper: I believe I've got a patch for the problem. I'm going to check and see if it fixes any of the other tickets.

EDIT:

Didn't fix:

#19288 (I wasn't able to reproduce this with r18537 either)
#19217

I might see about using RelationSorter to sort the new member instead of trying to guess. But attachment:21856.patch does fix the problem for this ticket.

Last edited 14 months ago by taylor.smock (previous) (diff)

comment:6 Changed 14 months ago by taylor.smock

Resolution:	→ fixed
Status:	new → closed

In 18539/josm:

Fix #21856: Split way: Wrong position of new member in PTv2 relation splitting a loop

Changed 14 months ago by skyper

Attachment:	ptv2_relation_loop_split2.osm.xz added

second example (not fixed)

comment:7 in reply to: 1 Changed 14 months ago by skyper

Resolution:	fixed
Status:	closed → reopened

The first example is fixed but my situation of comment 1 is still not working

Please find the second example attached and split at the nodes named "Split". Problem is still the order of the last way of the loop, which is in this case twice the identical way. Note, if you change the way direction everything works fine.

Last edited 14 months ago by skyper (previous) (diff)

comment:8 Changed 14 months ago by taylor.smock

Using RelationSorter is probably going to have to be the fix. That way we aren't trying to do the same thing in different places.

comment:9 Changed 13 months ago by taylor.smock

Milestone:	22.08 → 22.09

comment:10 Changed 12 months ago by taylor.smock

Milestone:	22.09 → 22.10

comment:11 Changed 11 months ago by taylor.smock

Milestone:	22.10 → 22.11

comment:12 Changed 10 months ago by taylor.smock

Milestone:	22.11 → 22.12

Milestone renamed