Opened 17 years ago

Last modified 12 years ago

#3531 closed defect

Validator - false positives in "way end node near other way" — at Version 14

Reported by: bilbo Owned by: dmuecke
Priority: normal Milestone: 14.01
Component: Core validator Version: latest
Keywords: unconnected_way Cc: AM909, MikeyCarter

Description (last modified by mdk)

Check for "way end node near other way" is useful, however in some areas it finds many false positives.

Minimal distance to trigger this warning seems to be 10 (by default).

But what unit it is? when the preference is read, the number is divided by some arbitrary number 6378135.0
What is meaning of that number? No documentation in the source

I've collected some examples of false positives found by validator, along with some ideas how to avoid them:

validator-deadend.png - T-junction near end of way

There is branching (T-junction) close to end of way. This shows false alarm, even though the way in warning is connected to the way with the endnode.

validator-platform.png - Parallel railway tracks or platforms

Railway platforms or tracks running in parallel - these can be as close as 5 meters.
Have some smaller distance to trigger the warning, if both ways (the one with end node and the one close to the node) are parallel or very close to parallel

validator-powerline.png - highway end node close to powerline
validator-stream-road.png - highway end node close to stream

Sometimes features are running quite close to each other "by design".
Power lines often are placed with little regard of what is below them and endpoint of highway ending up near powerline is surely not connected to it.
Sometimes stream run right behind the streets (the streets are ended just before the stream) and they are also not connected

Therefore for "incompatible" features (highway vs waterway, powerline vs waterway/railway/highway) that should not be probably connected
(highway connected to the powerline does not make sense), the distance should be lower too.

I think for these cases, some lower distance threshold (one quarter by default, perhaps ....) should be used

Change History (20)

by bilbo, 17 years ago

Attachment: validator-deadend.png added

by bilbo, 17 years ago

Attachment: validator-platform.png added

Parallel railway tracks or platforms

by bilbo, 17 years ago

Attachment: validator-powerline.png added

highway end node close to powerline

by bilbo, 17 years ago

Attachment: validator-stream-road.png added

highway end node close to stream

comment:1 by dmuecke, 16 years ago

Owner: changed from team to dmuecke
Status: newassigned

comment:2 by skyper, 16 years ago

Keywords: validator added

I think in all these example there should be a warning as long as the highway does not end with noexit=yes, but it should not be refered to a way with a different layer=* .

Last edited 15 years ago by skyper (previous) (diff)

comment:3 by bastiK, 15 years ago

Ticket #4363 has been marked as a duplicate of this ticket.

comment:4 by skyper, 15 years ago

Component: Core validatorCore
Keywords: way node added

Validator is in Core now

comment:5 by skyper, 15 years ago

Component: CoreCore validator
Resolution: fixed
Status: assignedclosed

Seems to be fixed

r3992

comment:6 by skyper, 15 years ago

Resolution: fixed
Status: closedreopened

Sorry. Validator does not find any "way end node near other way" right now

comment:7 by skyper, 15 years ago

I have another example with barrier=fence

by skyper, 15 years ago

example file

comment:8 by skyper, 15 years ago

Ticket #5837 has been marked as a duplicate of this ticket.

comment:9 by skyper, 15 years ago

Validator also warns about "way end node near other way" with untagged ways which are only part of landuse-relations as "other way" . Think this is a false positiv, too.

r4074

comment:10 by skyper, 15 years ago

Ticket #4257 has been marked as a duplicate of this ticket.

in reply to:  9 comment:11 by skyper, 15 years ago

Replying to skyper:

Validator also warns about "way end node near other way" with untagged ways which are only part of landuse-relations as "other way" . Think this is a false positiv, too.

r4074

Everything except the unntagged way is still an issue. Please, do check the main tag of both ways and filter to only check for ways with the same main tag. Thanks

r4137

comment:12 by skyper, 15 years ago

Ticket #5435 has been marked as a duplicate of this ticket.

comment:13 by simon04, 15 years ago

Ticket #6313 has been marked as a duplicate of this ticket.

by mdk, 14 years ago

Attachment: falsePositive.osm added

It looks like this issue is not so clear, but it huts me every day. So I add a more clear example with a highway near a poweline, a waterway and a barrier. I hope this will help to solve the problem.

comment:14 by mdk, 14 years ago

Description: modified (diff)

Ping :-)

(BTW why dose attaching a file did not effect 'last change date' of the issue in trac?)

Note: See TracTickets for help on using tickets.