Change "Join Node to Way" to "Join Way with Node"

[Hb---]

The Tools Menu has the two commands

Join Node to Way

Joins all way segments within the catch radius of the selected nodes with them. This command changes the geometry of ways.

Move Node onto Way

Moves the selected nodes to the ways in their catch radius. This command moves nodes.

The description Join Node to Way contradicts the behaviour of the command. Because ways are the object of the change the word Way should be the second word in the description. I suggest Join Way with Node.

[simon04]

There are a few related strings that we might want to consider as well:

// DrawAction.java
                title = tr("Add node into way");
// ImproveWayAccuracyAction.java
                String text = trn("Add a new node to way",
// JoinNodeWayAction.java
                tr("Join Node to Way"), /* ICON */ "joinnodeway",
                Shortcut.registerShortcut("tools:joinnodeway", tr("Tool: {0}", tr("Join Node to Way")),
                tr("Move Node onto Way"), /* ICON*/ "movenodeontoway",
                Shortcut.registerShortcut("tools:movenodeontoway", tr("Tool: {0}", tr("Move Node onto Way")),
// SelectAction.java
                String text = trn("Add and move a virtual new node to way",

[GerdP]

Note: Since r15610 the behaviour of "Move node onto Way" is a bit different. Only the closest way is modified.

I think "Join Way with Node" isn't much clearer. One might assume that all nodes of the way are moved. What about "Bend Way to Node" or "Include Node in Way"?

[Hb---]

Reason for opening was the Subjekt-Prädikat-Objekt-Regel (Subject-todoWord-Object-Rule).

The object being handled should be on the first position in the sentence. Or at least all menu items should follow the same rule. I'll check the current behavior against the initial bug report.

[Hb---]

The commit r15610 widely improved JoinNodeWayAction.java but did not change the basic principles.

The caption Move Node onto Way is very good: Verb, subject, preposition and object (target). This sets the standard for the other captions. The tool tip Move the node onto the nearest way segments and include it repeats the preposition and says that both primitives will be modified. The keyboard shortcut N hints to "Node".

Following the verb-subject-prepositon-object rule some texts need to change:

1. For 'Join Node to Way' leads to: Join Way <preposition> Node. Which of the prepositions with, to or onto is better is outside my knowledge of the English language. The verb reflects the shortcut J and is fine.
   The tool tip 'Include a node into the nearest way segments' is bad. Suggestion is here Move the nearest way segment to the selected node and connect to it.

2. For the opposite action 'Disconnect Node from Way' the verb-subject-prepositon-object rule leads to Disconnect Way from Node.
   The tool tip 'Disconnect nodes from a way they currently belong to' needs to follow this order Disconnect a way from the selected nodes it currently refers to..

Simon04 considered about some strings for the titles in the command stack panel. Here some additional replacements are needed:

• 'Connect existing way to node' with Add an existing node to an existing way to have all titles of the Draw action beginning with 'Add'.
• 'Removed nodes from {0}' with Disconnect way {0} from nodes
• 'Add a new node to way' with Improve {0} way with a new node

[GerdP]

I don't like any of the proposed texts. For me, the node is the subject because I have to select it.

[Hb---]

The selection is a logical point to consider. But we should take the whole Tools menu in view. It has very different subjects and selections. In general the effect of the action is most important:

Split Way	Node/s
Combine Way	Ways
Reverse Ways	Way/s
Simplify Way	Way/s
Align Nodes in Circle	Way or nodes
Align Nodes in Line	Way or nodes
Distribute Nodes	Way or nodes
Orthogonalize Shape	Way/s or nodes
Mirror	Way/s or nodes
Follow Line	Other Way
Add Node ...	-
Move Node ...	-
Create Circle	Way or nodes
Merge Nodes	Nodes
Join Node to Way	Node/s and optional a way
Move Node onto Way	Node/s and optional a way
Disconnect Node from Way	Node/s and optional a way
Unglue Ways	Nodes and/or ways
Join overlapping Areas	Closed way
Create Multipolygon	Closed way
Update Multipolygon	Closed way

Current help text for Join Node to Way and Move Node onto Way miss to mention that a selected way is going to be the target and that the nearest way segment is only a substitute when no way is selected.

[tgertin]

I do not understand how to use "Join Node to Way" or "Join Way with Node" tools. Does anybody have any instructions or a video on how to use it? Thanks

[skyper]

Replying to tgertin:

I do not understand how to use "Join Node to Way" or "Join Way with Node" tools. Does anybody have any instructions or a video on how to use it? Thanks

Select the node and use the shortcut or the Help/Menu/Tools. If nothing happens, zoom out and try again. See Help/Action/JoinNodeWay and Help/Action/MoveNodeWay

[tgertin]

Do you select a node on an open way or a closed way? Or does it matter? Also, does the node need to be near another way? If so, does that node need to be open or closed? I am confused, because I am selecting a node on a way and pressing Shift + J, and nothing happens. It doesn't matter how much I zoom out. I only receive a warning message that says 'Please select at least one closed way that should be joined.' I don't know what this means.

[skyper]

Shortcuts are J or N which means small letters (j and n), no shift. Join Area is another action with shortcut Shift+J (capital letter J).

[tgertin]

ok, thanks a lot. It works for me!

[skyper]

No big deal, you are welcome. Maybe a small user info in the left corner could be added if the actions do not find a way instead of silently ignoring the user`s input. The items in the menu could even be disabled until the distance is small enough but I do not know how resource costly this would be.

[GerdP]

Reg. the shortcuts in the wiki: Would it be possible to render the keys a bit more "key like"? I think I saw images with 3d keys somewhere.