Modify

Opened 3 years ago

Last modified 4 weeks ago

#14965 new enhancement

Improve autofilters

Reported by: Don-vip Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: autofilter Cc:

Description (last modified by Klumbumbus)

Autofilters have been implemented in #14929.

The feature can be enhanced:

  • allow users to define their auto filters through the filter dialog
  • ✅ provide better/faster access to change the current autofilter (maybe in the visibility menu of the layer panel) → #18628
  • ✅ allow values with units → #18679
  • allow non-numeric values
  • remove the zoom parameter?
  • ✅ document the whole thing on the wiki - Done.
  • ✅ see #17436

Attachments (1)

AutoFilterRule.java.patch (1.1 KB) - added by Klumbumbus 9 months ago.

Download all attachments as: .zip

Change History (19)

comment:2 Changed 3 years ago by alarobric

The layer autofilter shows only the specific layer selected and does not work with multiple values.
For instance when 1 is selected, then objects with layer=1 will show, but objects with layer=1;2 or 1-2 will not.

Great new feature though - very helpful.

comment:3 Changed 3 years ago by Zverikk

Creating new objects with an autofilter enabled is impossible: they immediately disappear, since they don't have the tag. Maybe the autofilter should include also new untagged objects.

comment:4 Changed 13 months ago by Klumbumbus

Ticket #17436 has been marked as a duplicate of this ticket.

comment:5 Changed 13 months ago by Klumbumbus

Description: modified (diff)

comment:6 Changed 9 months ago by Klumbumbus

The zoom parameter doesn't work as expected. After you once reach the min zoom the filterbuttons are displayed and they stay there even if you zoom out. The only way to disable them is to zoom out, move data out of the mapview and zoom in.

Changed 9 months ago by Klumbumbus

Attachment: AutoFilterRule.java.patch added

comment:7 Changed 9 months ago by Klumbumbus

Here is a small patch that adds some more keys as autofilters and a space before the [ (for prettiness).
However buildings:levels doesn't work. When activating an error pops up. It seems the : marks the end of the key and puts e.g. :levels=3 into the value. I tried "building\:levels", "building\\:levels" and "building" + ':' + "levels" but none worked without compiling or UI errors...

incline doesn't work as well, (I copied the syntax from maxspeed), maybe % has special powers here too.

So, if someone please could review before commiting that would be nice :)

comment:8 Changed 7 months ago by Klumbumbus

Description: modified (diff)

comment:9 Changed 7 months ago by Klumbumbus

Summary: Improve autofiltersImprove autofilters [patch needs review]

comment:10 in reply to:  7 Changed 2 months ago by simon04

Description: modified (diff)
Milestone: 20.02

Replying to Klumbumbus:

Here is a small patch that adds some more keys as autofilters

Nice :)

comment:11 in reply to:  7 Changed 7 weeks ago by simon04

Replying to Klumbumbus:

Here is a small patch that adds some more keys as autofilters and a space before the [ (for prettiness).

You could simplify + " " + '[' + to + " [" + – feel free to apply your own patch.

comment:12 Changed 7 weeks ago by Klumbumbus

It didn't work correctly for me, see comment:7

comment:13 Changed 7 weeks ago by simon04

Ah, sorry, I overlooked that.

The building:levels problem is gone due to r15764. Previously, the string was compiled as a search expression, thus, new AutoFilterRule("\"building:levels\"", 17) should have worked.

I'll look into incline=...%

comment:14 in reply to:  13 Changed 7 weeks ago by simon04

Replying to simon04:

I'll look into incline=...%

#18679 (including attachment:AutoFilterRule.java.patch​)

comment:15 Changed 7 weeks ago by simon04

Description: modified (diff)
Summary: Improve autofilters [patch needs review]Improve autofilters

Support for incline=20%, i.e., value plus unit, has been integrated via #18679.

comment:16 Changed 6 weeks ago by simon04

Description: modified (diff)
Milestone: 20.02

comment:17 Changed 6 weeks ago by Klumbumbus

Description: modified (diff)

comment:18 Changed 4 weeks ago by Klumbumbus

In 15953/josm:

  • see #14965 - Sort Autofilter tags alphabetical and add a space before the zoom level
  • see #17629 - Don't warn about name=mairie|rathaus (was agreed, see ticket:17629#comment:13 et seqq. but forgotten)
  • see #15309 - Ignore more healthcare tags for now

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Don-vip
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.