Improve autofilters

[Don-vip]

Autofilters have been implemented in #14929.

The feature can be enhanced:

• allow users to define their auto filters through the filter dialog
• ✅ provide better/faster access to change the current autofilter (maybe in the visibility menu of the layer panel) → #18628
• ✅ allow values with units → #18679
• allow non-numeric values
• remove the zoom parameter?
• ✅ document the whole thing on the wiki - Done.
• ✅ see #17436

[Klumbumbus]

I startet docu at Help/Dialog/Filter#Autofilters and Help/Preferences/Display#OSMData

[alarobric]

The layer autofilter shows only the specific layer selected and does not work with multiple values.
For instance when 1 is selected, then objects with layer=1 will show, but objects with layer=1;2 or 1-2 will not.

Great new feature though - very helpful.

[Zverikk]

Creating new objects with an autofilter enabled is impossible: they immediately disappear, since they don't have the tag. Maybe the autofilter should include also new untagged objects.

[Klumbumbus]

Ticket #17436 has been marked as a duplicate of this ticket.

[Klumbumbus]

The zoom parameter doesn't work as expected. After you once reach the min zoom the filterbuttons are displayed and they stay there even if you zoom out. The only way to disable them is to zoom out, move data out of the mapview and zoom in.

[Klumbumbus]

Here is a small patch that adds some more keys as autofilters and a space before the [ (for prettiness).
However buildings:levels doesn't work. When activating an error pops up. It seems the : marks the end of the key and puts e.g. :levels=3 into the value. I tried "building\:levels", "building\\:levels" and "building" + ':' + "levels" but none worked without compiling or UI errors...

incline doesn't work as well, (I copied the syntax from maxspeed), maybe % has special powers here too.

So, if someone please could review before commiting that would be nice :)

[simon04]

Replying to Klumbumbus:

Here is a small patch that adds some more keys as autofilters

Nice :)

[simon04]

Replying to Klumbumbus:

Here is a small patch that adds some more keys as autofilters and a space before the [ (for prettiness).

You could simplify + " " + '[' + to + " [" + – feel free to apply your own patch.

[Klumbumbus]

It didn't work correctly for me, see comment:7

[simon04]

Ah, sorry, I overlooked that.

The building:levels problem is gone due to r15764. Previously, the string was compiled as a search expression, thus, new AutoFilterRule("\"building:levels\"", 17) should have worked.

I'll look into incline=...% …

[simon04]

Replying to simon04:

I'll look into incline=...% …

→ #18679 (including attachment:AutoFilterRule.java.patch​​)

[simon04]

Support for incline=20%, i.e., value plus unit, has been integrated via #18679.

[Klumbumbus]

In 15953/josm:

• see #14965 - Sort Autofilter tags alphabetical and add a space before the zoom level
• see #17629 - Don't warn about name=mairie|rathaus (was agreed, see ticket:17629#comment:13 et seqq. but forgotten)
• see #15309 - Ignore more healthcare tags for now