Modify

Opened 3 years ago

Closed 4 weeks ago

Last modified 4 weeks ago

#12281 closed enhancement (wontfix)

[Patch] Clean up massive code duplication from OSMRecPlugin plugin

Reported by: simon04 Owned by: nkaragiannakis
Priority: normal Milestone:
Component: Plugin Version:
Keywords: Cc:

Description (last modified by simon04)

wiki:DevelopersGuide/ShortcutsList revealed a massive code duplication in the OSMRecPlugin plugin.

attachment:12281-v1-core.patch​, attachment:12281-v1-plugin.patch​ are some first core+plugin patches to get rid of this. Now, after going through a 2500 lines diff, my eyes are falling out …

Attachments (2)

12281-v1-core.patch (8.4 KB) - added by simon04 3 years ago.
12281-v1-plugin.patch (31.8 KB) - added by simon04 3 years ago.

Download all attachments as: .zip

Change History (15)

Changed 3 years ago by simon04

Attachment: 12281-v1-core.patch added

comment:1 Changed 3 years ago by simon04

Description: modified (diff)

Changed 3 years ago by simon04

Attachment: 12281-v1-plugin.patch added

comment:2 Changed 3 years ago by Don-vip

Yeah, I know. It was even worse at the beginning, see https://github.com/GeoKnow/OSMRec/issues/2

comment:3 Changed 3 years ago by nkaragiannakis

I will get rid of as much as possible from the duplicate code. I will test the patch in the next days and apply the necessary changes

comment:4 Changed 3 years ago by simon04

Thank you! Feel free to request more core changes (as in attachment:12281-v1-core.patch​) in order to accomplish this. :)

comment:5 Changed 3 years ago by simon04

Owner: changed from team to nkaragiannakis

comment:6 Changed 3 years ago by Don-vip

In 9502/josm:

see #12281 - core changes to clean up massive code duplication from OSMRecPlugin plugin (patch by simon04 + javadoc/sonar fixes)

comment:7 Changed 3 years ago by Don-vip

@nkaragiannakis: the core changes are live, tell us if you need something else.

comment:8 Changed 3 years ago by nkaragiannakis

I didn' t have time to test it thoroughly, but i noticed that the "set number of recently added tags" of the core component keeps always the max number, that is 30.
The same feature seems to work ok with the plugin, i don' t know why yet.

Anyway, I 'm gonna need some time to check on it again, and remove the duplicate code from the plugin as well.

comment:9 Changed 3 years ago by Don-vip

regression fixed in r9564 see #12401 / #12419

comment:10 Changed 4 weeks ago by Don-vip

Resolution: wontfix
Status: newclosed

comment:11 Changed 4 weeks ago by GerdP

It seems that our SonarQuube is still processing the moved sources at the old location.

comment:12 Changed 4 weeks ago by Don-vip

Jenkins sometimes messes up its SVN folder, I have cleaned it and relaunched the job: https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/1541/

comment:13 Changed 4 weeks ago by GerdP

job failed, seems that SonarQube needs re-configuration.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain nkaragiannakis.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.