#12281 closed enhancement (wontfix)
[Patch] Clean up massive code duplication from OSMRecPlugin plugin
Reported by: | simon04 | Owned by: | nkaragiannakis |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Plugin | Version: | |
Keywords: | Cc: |
Description (last modified by )
wiki:DevelopersGuide/ShortcutsList revealed a massive code duplication in the OSMRecPlugin
plugin.
attachment:12281-v1-core.patch, attachment:12281-v1-plugin.patch are some first core+plugin patches to get rid of this. Now, after going through a 2500 lines diff, my eyes are falling out …
Attachments (2)
Change History (15)
Changed 8 years ago by
Attachment: | 12281-v1-core.patch added |
---|
comment:1 Changed 8 years ago by
Description: | modified (diff) |
---|
Changed 8 years ago by
Attachment: | 12281-v1-plugin.patch added |
---|
comment:2 Changed 8 years ago by
comment:3 Changed 8 years ago by
I will get rid of as much as possible from the duplicate code. I will test the patch in the next days and apply the necessary changes
comment:4 Changed 8 years ago by
Thank you! Feel free to request more core changes (as in attachment:12281-v1-core.patch) in order to accomplish this. :)
comment:5 Changed 8 years ago by
Owner: | changed from team to nkaragiannakis |
---|
comment:7 Changed 8 years ago by
@nkaragiannakis: the core changes are live, tell us if you need something else.
comment:8 Changed 8 years ago by
I didn' t have time to test it thoroughly, but i noticed that the "set number of recently added tags" of the core component keeps always the max number, that is 30.
The same feature seems to work ok with the plugin, i don' t know why yet.
Anyway, I 'm gonna need some time to check on it again, and remove the duplicate code from the plugin as well.
comment:10 Changed 5 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Plugin no longer supported and archived to https://svn.openstreetmap.org/applications/editors/josm/oldplugins/
comment:11 Changed 4 years ago by
It seems that our SonarQuube is still processing the moved sources at the old location.
comment:12 Changed 4 years ago by
Jenkins sometimes messes up its SVN folder, I have cleaned it and relaunched the job: https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/1541/
Yeah, I know. It was even worse at the beginning, see https://github.com/GeoKnow/OSMRec/issues/2