[Patch] Clean up massive code duplication from OSMRecPlugin plugin

[simon04]

wiki:DevelopersGuide/ShortcutsList revealed a massive code duplication in the OSMRecPlugin plugin.

attachment:12281-v1-core.patch​​, attachment:12281-v1-plugin.patch​​ are some first core+plugin patches to get rid of this. Now, after going through a 2500 lines diff, my eyes are falling out …

[Don-vip]

Yeah, I know. It was even worse at the beginning, see ​https://github.com/GeoKnow/OSMRec/issues/2

[nkaragiannakis]

I will get rid of as much as possible from the duplicate code. I will test the patch in the next days and apply the necessary changes

[simon04]

Thank you! Feel free to request more core changes (as in attachment:12281-v1-core.patch​​) in order to accomplish this. :)

[Don-vip]

In 9502/josm:

see #12281 - core changes to clean up massive code duplication from OSMRecPlugin plugin (patch by simon04 + javadoc/sonar fixes)

[Don-vip]

@nkaragiannakis: the core changes are live, tell us if you need something else.

[nkaragiannakis]

I didn' t have time to test it thoroughly, but i noticed that the "set number of recently added tags" of the core component keeps always the max number, that is 30.
The same feature seems to work ok with the plugin, i don' t know why yet.

Anyway, I 'm gonna need some time to check on it again, and remove the duplicate code from the plugin as well.

[Don-vip]

regression fixed in r9564 see #12401 / #12419

[Don-vip]

Plugin no longer supported and archived to ​https://svn.openstreetmap.org/applications/editors/josm/oldplugins/

[GerdP]

It seems that our SonarQuube is still processing the moved sources at the old location.

[Don-vip]

Jenkins sometimes messes up its SVN folder, I have cleaned it and relaunched the job: https://josm.openstreetmap.de/jenkins/job/JOSM-Plugins/1541/

[GerdP]

job failed, seems that SonarQube needs re-configuration.