support urls in notes

[skyper]

Not sure if it is within the scope of the plugin. If not it would be an enhancement of "Core notes".

I often find URLs within a note but cannot click nor copy it to open in a web browser.

[simon04]

An idea would be to copy the note URL to the clipboard when right clicking the tooltip, see attachment:11217.patch​

[bastiK]

Can we use GettingStarted.LinkGeneral?

[simon04]

First attempt using GettingStarted.LinkGeneral: does not look as expected …

[ToeBee]

Technically speaking, the patch and this ticket are solving two different problems. The ticket is asking for URLs in the note text to be clickable. The patch makes it easier to open a given note on osm.org. If note text could be made clickable, the "note xxx" link at the top of the note could be turned into a URL to open on osm.org. The problem I ran into is that the note text is rendered as a tooltip which isn't really intended to be clicked on.

[Don-vip]

skip milestone 15.06

[simon04]

In 8503/josm:

see #11217 - Notes: copy note URL to clipboard when right clicking tooltip

[simon04]

comment:6 still applies: links within notes can still not be opened/copied.

[Klumbumbus]

Replying to simon04:

In 8503/josm:

see #11217 - Notes: copy note URL to clipboard when right clicking tooltip

This copies the api url. Wouldn't it be better if it copies the url, which opens the note at osm.org?

So,

​http://www.openstreetmap.org/note/377327

instead of

​https://api.openstreetmap.org/api/0.6/notes/377327

[Don-vip]

Milestone renamed

[simon04]

I don't plan implementing this any time soon …

[Don-vip]

In 13111/josm:

fix #11217, fix #12623 - major rework of notes tooltips:

• display clickable links
• allow to copy text from notes, including comments

[Don-vip]

Here's the result:

[Klumbumbus]

This means copying the notes api url (via right click on the popup) is no longer available, right?
(Just for updating Help/Dialog/Notes.)

[Klumbumbus]

The notes Popup is now somehow on top of the JOSM window and can be moved out of the mapview, which looks a bit weird.

[Don-vip]

I'm not sure I can display it behind the toolbars and panels with the new system. I could however hide the popup if displayed outside of JOSM...

[Don-vip]

In 13117/josm:

see #11217, fix #15541 - hide note tooltip when selected note is no longer visible + drop old url copy code (does not work anymore with new system)

[Klumbumbus]

There is one more regression. It is not possible anmore to cycle through the notes list with the arrow keys. I work a lot on handling and closing notes and this feature is pretty helpful as then you can quickly see the full texts of all the notes in the list.

[Klumbumbus]

And one more regression is that shortcuts don't work anymore after clicking on a note. So my work flow is often:

1. double click a note
2. press shortcut for Help/Action/DownloadOsmInView

The shortcut doesn't work, you need to click somewhere else first.

[Don-vip]

In 13118/josm:

fix #11217 - do not steel focus when the selected note changes

[Klumbumbus]

Replying to Don-vip:

In 13118/josm:

fix #11217 - do not steel focus when the selected note changes

Mouse scroll to zoom the mapview doesn't work if the mousepointer is on the note tooltip. Can this be fixed easily too?

[Don-vip]

In 13126/josm:

see #11217 - forward note tooltips mouse wheel scroll events to map frame

[Don-vip]

In 13128/josm:

see #15550, see #11217 - better detection of URLs in notes