Modify

Opened 8 years ago

Closed 6 years ago

Last modified 6 years ago

#12623 closed enhancement (fixed)

allow copying any text from note comments

Reported by: richlv Owned by: team
Priority: normal Milestone: 17.11
Component: Core notes Version: tested
Keywords: Cc:

Description (last modified by stoecker)

#12268 added basic note text copying, which is great :)

it would be even better if we could select the text in the popup, shown in the map view when we click a note.
clicking a specific comment there would allow selecting any text from it, ctrl+c would copy it.

a usecase i have right now - some 5th or so comment to a note has school names i would like to copy. that's still not possible in josm, i have to open the web map a this position & copy the names from there.

Attachments (2)

josm_notes.png (9.8 KB ) - added by Don-vip 6 years ago.
josm_note_selection.png (7.8 KB ) - added by richlv 6 years ago.
invisible selection

Download all attachments as: .zip

Change History (16)

comment:1 by Don-vip, 8 years ago

Ticket #13367 has been marked as a duplicate of this ticket.

comment:2 by stoecker, 8 years ago

Description: modified (diff)

comment:3 by anonymous, 7 years ago

Still not working on version 11283

comment:4 by anonymous, 7 years ago

wrong call on "Still not working on version 11283" sorry

comment:5 by Don-vip, 6 years ago

Milestone: 17.11

comment:6 by Don-vip, 6 years ago

Resolution: fixed
Status: newclosed

In 13111/josm:

fix #11217, fix #12623 - major rework of notes tooltips:

  • display clickable links
  • allow to copy text from notes, including comments

by Don-vip, 6 years ago

Attachment: josm_notes.png added

comment:7 by Don-vip, 6 years ago

Here's the result:


comment:8 by richlv, 6 years ago

testing with 13115, i still get the old style popups - cannot select any text. how so ?

comment:9 by Don-vip, 6 years ago

status report, note id and screenshot please :)

by richlv, 6 years ago

Attachment: josm_note_selection.png added

invisible selection

comment:10 by richlv, 6 years ago

oh damn. turns out i can select the text, but on my platform (linux, java 1.8.0_121) the highlight colour is invisible. see josm_note_selection.png, word "clock" is selected there.

invisible selection

can this be handled in this ticket, or should a new one be filed ?

Last edited 6 years ago by Don-vip (previous) (diff)

comment:11 by Don-vip, 6 years ago

What look and feel are you using?

comment:12 by richlv, 6 years ago

josm settings say "Metal"

comment:13 by Don-vip, 6 years ago

Metal defines the same color for tooltip background and text selection color... I don't plan to change this, it's a very minor problem, you can see the selected text changes from black to grey, and it works. You can also use a better look and feel (Gtk for example).

comment:14 by richlv, 6 years ago

thanks. is it work reporting this a separate problem for the metal theme ?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.