#9027 closed defect (fixed)
[patch] Error in Internal Preset
Reported by: | andygol | Owned by: | Don-vip |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Internal preset | Version: | latest |
Keywords: | Cc: |
Description (last modified by )
Attachments (4)
Change History (20)
Changed 9 years ago by
Attachment: | internal_preset_err.png added |
---|
comment:1 Changed 9 years ago by
Description: | modified (diff) |
---|
Changed 9 years ago by
Attachment: | 9027.patch added |
---|
comment:2 follow-up: 4 Changed 9 years ago by
Summary: | Error in Internal Preset → [patch] Error in Internal Preset |
---|
comment:3 follow-up: 6 Changed 9 years ago by
Sorry about that :( We need to update build.xml to make it fail in case of a validation error of presets file. It is possible with SchemaValidate.
comment:4 follow-up: 5 Changed 9 years ago by
comment:5 follow-up: 7 Changed 9 years ago by
Changed 9 years ago by
Attachment: | 9027-prevention.patch added |
---|
validate default presets internally in unit tests and externally in build.xml
comment:6 Changed 9 years ago by
Replying to Don-vip:
Sorry about that :( We need to update build.xml to make it fail in case of a validation error of presets file. It is possible with SchemaValidate.
I've attached 9027-prevention.patch that checks that.
comment:7 follow-up: 8 Changed 9 years ago by
Replying to AlfonZ:
As far as I know,
key
doesn't display anything to the user in the preset dialog, it directly sets the tag.
Yes, sorry, you are right.
Well, than the problem is the label above which needs text_context
.
comment:8 follow-up: 9 Changed 9 years ago by
comment:9 follow-up: 10 Changed 9 years ago by
Replying to skyper:
Replying to skyper:
Replying to AlfonZ:
As far as I know,
key
doesn't display anything to the user in the preset dialog, it directly sets the tag.
Yes, sorry, you are right.
Well, than the problem is the label above which needs
text_context
.
Looking at other items having text_context
on label - e.g. (railway) Station, I wonder if there should be name_context
on item
as well.
comment:10 Changed 9 years ago by
Replying to AlfonZ:
Replying to skyper:
Replying to skyper:
Replying to AlfonZ:
As far as I know,
key
doesn't display anything to the user in the preset dialog, it directly sets the tag.
Yes, sorry, you are right.
Well, than the problem is the label above which needs
text_context
.
Looking at other items having
text_context
on label - e.g. (railway) Station, I wonder if there should bename_context
onitem
as well.
Does translation work case-sensitive ?
In general you are right, but I have to admit that I was too fast and your first patch should be sufficient as for labels the whole text is translated and I only find "Skating" at one place in the whole file.
For station you are right that there are some *_context missing.
comment:11 Changed 9 years ago by
Owner: | changed from team to Don-vip |
---|---|
Status: | new → assigned |
comment:12 follow-up: 14 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
In 6208/josm:
comment:14 Changed 9 years ago by
comment:15 follow-up: 16 Changed 9 years ago by
Because it was late and I didn't notice. Ok for taking care of that in #9029 :)
Caused by r6195.