Ticket #9027: 9027-prevention.patch

File 9027-prevention.patch, 1.8 KB (added by AlfonZ, 11 years ago)

validate default presets internally in unit tests and externally in build.xml

  • build.xml

     
    6161Build-Date: ${build.tstamp}
    6262</echo>
    6363    </target>
    64     <target name="dist" depends="compile,create-revision">
     64    <target name="check-schemas">
     65        <schemavalidate file="data/defaultpresets.xml" >
     66            <schema namespace="http://josm.openstreetmap.de/tagging-preset-1.0" file="data/tagging-preset.xsd" />
     67        </schemavalidate>
     68        <schemavalidate file="styles/standard/elemstyles.xml" >
     69            <schema namespace="http://josm.openstreetmap.de/mappaint-style-1.0" file="data/mappaint-style.xsd" />
     70        </schemavalidate>
     71    </target>
     72    <target name="dist" depends="compile,create-revision,check-schemas">
    6573        <exec append="false" output="REVISION" executable="svn" failifexecutionfails="false">
    6674            <env key="LANG" value="C"/>
    6775            <arg value="info"/>
  • test/unit/org/openstreetmap/josm/gui/tagging/TaggingPresetReaderTest.java

     
    6363        Assert.assertTrue("Entry is not checkbox", item instanceof TaggingPresetItems.Check);
    6464    }
    6565
     66    /**
     67     * Validate internal presets
     68     * See #9027
     69     */
     70    @Test
     71    public void readDefaulPresets() throws SAXException, IOException {
     72        String presetfile = "resource://data/defaultpresets.xml";
     73        final Collection<TaggingPreset> presets = TaggingPresetReader.readAll(presetfile, true);
     74        Assert.assertTrue("Default presets are empty", presets.size()>0);
     75    }
     76   
    6677}