Modify

Opened 11 years ago

Closed 11 years ago

Last modified 3 years ago

#9029 closed enhancement (fixed)

[patch] "*_context" update + format unification + minor misc

Reported by: skyper Owned by: team
Priority: normal Milestone: 13.11
Component: Internal preset Version:
Keywords: space context Cc: stoecker, bastiK, akks, simon04

Description (last modified by skyper)

Regarding AlfonZ comment on #9027, I did some updates of *_context.

On the way, I did a format unification regarding spaces and order + adding/updating some tags.

Lots of removing/adding spaces + moving lines up/down

Please find attached patch.
Note: This patch reverts part of r6208 as it is not needed for now.

Attachments (4)

josm_9029.diff (209.1 KB ) - added by skyper 11 years ago.
patch
josm_9029_v2.diff (209.5 KB ) - added by skyper 11 years ago.
patch version 2
josm_9029_v3.diff (209.5 KB ) - added by skyper 11 years ago.
patch version 3
josm_9029_v4.1.diff (206.4 KB ) - added by skyper 11 years ago.
patch version 4

Download all attachments as: .zip

Change History (24)

by skyper, 11 years ago

Attachment: josm_9029.diff added

patch

comment:1 by skyper, 11 years ago

Description: modified (diff)

comment:2 by skyper, 11 years ago

Description: modified (diff)

comment:3 by aceman, 11 years ago

Nice, but why removing values_context="display" for Clock, and context for gaelic_games and Bollard type and why are some values_context values lowercase and some start with capital letter?

by skyper, 11 years ago

Attachment: josm_9029_v2.diff added

patch version 2

in reply to:  3 comment:4 by skyper, 11 years ago

Replying to aceman:

Thanks for reviewing

Nice, but why removing values_context="display" for Clock, and context for gaelic_games

Cause they are not needed as the strings are only used in one context.

and Bollard type

I did move this up out of the optional block.

and why are some values_context values lowercase and some start with capital letter?

You are right I did change it to use only lower case plus two small issues.
Find attached patch version 2.

by skyper, 11 years ago

Attachment: josm_9029_v3.diff added

patch version 3

comment:5 by skyper, 11 years ago

Damn, I reintroduced a non-sense separator.
Well this is version 3.

comment:6 by skyper, 11 years ago

Is there any release in September ?

in reply to:  6 comment:7 by Don-vip, 11 years ago

Cc: stoecker bastiK akks simon04 added

Replying to skyper:

Is there any release in September ?

Lack of time + major problems with my Ubuntu laptop prevent me to do i18n update. Is there someone available to do it ? If not we can release tomorrow (in order to include #9084 in tested). Current latest must very stable as no notable defect has been created in days.

comment:8 by stoecker, 11 years ago

Hmm, I did an i18n update now, but it is incomplete anyway. The preset convert script failed due to new entries and the svn was locked, so for about one month (2013-08-04) no new texts have been uploaded. About 200 strings are missing :-)

Regarding the patch: don't change the context uppercase/lowercase unless really necessary. It causes a complete loss of all translated strings.

in reply to:  8 comment:9 by Don-vip, 11 years ago

Replying to stoecker:

The preset convert script failed due to new entries

Sorry to hear that. What exactly caused this ? To avoid future same mistake.

in reply to:  8 ; comment:10 by skyper, 11 years ago

Replying to stoecker:

Regarding the patch: don't change the context uppercase/lowercase unless really necessary. It causes a complete loss of all translated strings.

Is it ok to have one default meaning without context and only second, third ... context with *_context or do we need it for all strings with different context ?

in reply to:  10 ; comment:11 by stoecker, 11 years ago

Replying to Don-vip:

Replying to stoecker:

The preset convert script failed due to new entries

Sorry to hear that. What exactly caused this ? To avoid future same mistake.

It reports an error, when it does not know how to convert lines in the file. It needs adaption to detect new line types.

Replying to skyper:

Replying to stoecker:

Regarding the patch: don't change the context uppercase/lowercase unless really necessary. It causes a complete loss of all translated strings.

Is it ok to have one default meaning without context and only second, third ... context with *_context or do we need it for all strings with different context ?

It is only necessary to separate them. Whether one is default or not is a matter of style. And separation should only take place if required in any existing language due to conflicts, not only because it looks better.

in reply to:  11 comment:12 by skyper, 11 years ago

Replying to stoecker:

Replying to skyper:

Replying to stoecker:

Regarding the patch: don't change the context uppercase/lowercase unless really necessary. It causes a complete loss of all translated strings.

Is it ok to have one default meaning without context and only second, third ... context with *_context or do we need it for all strings with different context ?

It is only necessary to separate them. Whether one is default or not is a matter of style.

Mmh, in 90% you will have first one context and later add another one. E.g. we mostly have some primary case and later introduces extra cases. Considering translation we should not add a *_context to the primary case. Well, this question was bothering me some time but forgot to ask it directly.

And separation should only take place if required in any existing language due to conflicts, not only because it looks better.

I am not sure if you are talking about "gaelic", "running" <-> "racing" or was this simply a general statement ?

Sorry, but I only speak some western languages. How should I know different context in all languages ? How can I change it without mistakes under this condition ? Do we need a list about *_context in the wiki or code ?

I gonna try to rework the patch, maybe separate *_context, next week.

in reply to:  11 comment:13 by Don-vip, 11 years ago

Replying to stoecker:

Replying to Don-vip:

Replying to stoecker:

The preset convert script failed due to new entries

Sorry to hear that. What exactly caused this ? To avoid future same mistake.

It reports an error, when it does not know how to convert lines in the file. It needs adaption to detect new line types.

Does it make the new tested release fail as well ? I updated TestedVersion 5 hours ago and nothing has changed yet.

comment:14 by stoecker, 11 years ago

I am not sure if you are talking about "gaelic", "running" <-> "racing" or was this simply a general statement ?

General statement. When I don't like specific things I usually says so :-)

Sorry, but I only speak some western languages. How should I know different context in all languages ? How can I change it without mistakes under this condition ? Do we need a list about *_context in the wiki or code ?

Nobody says this is easy. But if a language has troubles, they should report it and we add contexts when required :-)

Does it make the new tested release fail as well ? I updated TestedVersion 5 hours ago and nothing has changed yet.

No, that was another issue. Seems the server crash happened during a josm cron run and the lockfile prevented a new start. Although already designed, the current cron-job design does not really test for stale lockfile. Works usually for months without trouble, so nobody spends the necessary time to fix it. :-)

in reply to:  14 comment:15 by Don-vip, 11 years ago

Replying to stoecker:

Does it make the new tested release fail as well ? I updated TestedVersion 5 hours ago and nothing has changed yet.

No, that was another issue. Seems the server crash happened during a josm cron run and the lockfile prevented a new start. Although already designed, the current cron-job design does not really test for stale lockfile. Works usually for months without trouble, so nobody spends the necessary time to fix it. :-)

OK thanks :) I just have run it manually and it seems to have worked :) New tested is live !

comment:16 by stoecker, 11 years ago

Summary: [patch] "*_context" update + format unification + minor misc[patch needs rework] "*_context" update + format unification + minor misc

by skyper, 11 years ago

Attachment: josm_9029_v4.1.diff added

patch version 4

comment:17 by skyper, 11 years ago

Summary: [patch needs rework] "*_context" update + format unification + minor misc[patch] "*_context" update + format unification + minor misc

Please find an updated patch attached. I tried to change/add not that many *_context but did remove some unneeded.

comment:18 by stoecker, 11 years ago

Resolution: fixed
Status: newclosed

In 6259/josm:

large cleanup of presets - patch by skyper - fix #9029

comment:19 by Don-vip, 10 years ago

Milestone: 13.11 (6383)

comment:20 by stoecker, 7 years ago

Milestone: 13.11 (6383)13.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.