Modify

Opened 8 years ago

Closed 8 years ago

Last modified 6 weeks ago

#7184 closed enhancement (fixed)

Integrate ImproveWayAccuracy to core?

Reported by: simon04 Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: ImproveWayAccuracy Cc: stoecker, bastiK, skyper

Description

When are (good) plugins usually integrated to the JOSM core (e.g., the validator plugin)?

I consider the ImproveWayAccuracy plugin to be very useful for a broad audience (not only due to a broad availability of areal imagery). AFAIK, there haven't been any bugs nor changes to the plugin since 2011-05. The plugin only consists of 4 files and a total 871 loc.

Thus, I suggest to integrate ImproveWayAccuracy to the core.

Attachments (2)

7184_hide.patch (2.7 KB) - added by simon04 8 years ago.
7184.patch (36.3 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (40)

comment:1 Changed 8 years ago by akks

Yes, it would be good (is harder for author to make changes in core, but there were almost no changes).

comment:2 Changed 8 years ago by simon04

Cc: stoecker bastiK added

@stoecker, @bastiK: What do you think?

comment:3 Changed 8 years ago by bastiK

I'm not opposed, it's on par with "parallel way" and "extrude". The plugin doesn't rank very hight in the statistics, but this shouldn't be the only criterion.

comment:4 Changed 8 years ago by stoecker

Probably this is one of the cases, where a full working mode may be "expert"?

comment:5 Changed 8 years ago by simon04

Replying to bastiK:

The plugin doesn't rank very hight in the statistics, but this shouldn't be the only criterion.

It took me very long (too long) long to find this plugin myself. This is not a kind of plugin, one actively searches for. As written above, due to the increasing availability of areal imagery, this plugin gets steadily more useful, IMHO.

Replying to stoecker:

Probably this is one of the cases, where a full working mode may be "expert"?

Is it? I would not consider improving the accuracy of existing OSM objects as "expert". To perform this task efficiently, this mode is very helpful.

Last edited 8 years ago by simon04 (previous) (diff)

comment:6 Changed 8 years ago by stoecker

Expert mode has the basic idea to ease the user interface for beginners. So a tool which allows a working mode, which also can be reached relatively easy with the standard methods clearly is "expert".

Actually the mode is "not beginner", but when labeling the normal mode "beginner" nearly everybody would click this off on the second day and the effect would be void.

The tool here is only interesting for people who no longer ask "Is this possible", but who ask "Can this be done faster" --> experts. :-)

comment:7 in reply to:  6 ; Changed 8 years ago by simon04

Replying to stoecker:

The tool here is only interesting for people who no longer ask "Is this possible", but who ask "Can this be done faster" --> experts. :-)

Good point.

However, I consider the tools "create area" and "parallel copies" more advanced/complicated to use than "improve way accuracy". For beginners, there's probably also no need to have the mode "delete" as this can be done with [Del] as well.

So we could add "improve way accuracy" to core first, and solve the (non-)expert classification of modes then?

comment:8 Changed 8 years ago by bastiK

I'd agree, that extrude mode and even delete mode are more "expert" then "improve way accuracy". I think it is crucial, to improve the expert mode switching - without restart and it should be easier to find (main menu).

comment:9 in reply to:  7 Changed 8 years ago by stoecker

Replying to simon04:

However, I consider the tools "create area" and "parallel copies" more advanced/complicated to use than "improve way accuracy". For beginners, there's probably also no need to have the mode "delete" as this can be done with [Del] as well.

All three should be expert options as well.

Changed 8 years ago by simon04

Attachment: 7184_hide.patch added

comment:10 Changed 8 years ago by simon04

Patch hides DeleteAction, ExtrudeAction, ParallelWayAction by default. The shortcuts still work and the icons on the left hand side can be made visible by clicking on >>.

Similarly, some of the toggle dialogs could be hidden on the left hand side (see also #6909).

What about my original question concerning ImproveWayAccuracy?

comment:11 Changed 8 years ago by stoecker

Go on with this patch and integration I would say.

comment:12 in reply to:  11 ; Changed 8 years ago by simon04

Replying to stoecker:

Go on with this patch and integration I would say.

When integrating ImproveWayAccuracy, does one have to look out for something?

comment:13 in reply to:  12 Changed 8 years ago by stoecker

Replying to simon04:

When integrating ImproveWayAccuracy, does one have to look out for something?

It should work :-)

Place stuff in proper directories, so it fits JOSM structure. I recently found a class in validator dirs, which actually belonged into commands.

comment:14 Changed 8 years ago by simon04

In [4835/josm]:

see #7184 - hide DeleteAction, ExtrudeAction, ParallelWayAction by default for non-expert users

comment:15 Changed 8 years ago by simon04

I'd add the following files for the plugin (besides images):

  • src/org/openstreetmap/josm/actions/mapmode/IWAGeometry.java
  • src/org/openstreetmap/josm/actions/mapmode/IWATargetWayHelper.java
  • src/org/openstreetmap/josm/actions/mapmode/ImproveWayAccuracyAction.java

Or is it better to have inner classes for the helper classes IWAGeometry, IWATargetWayHelper?

Is there a way to trigger an automatic uninstallation of the plugin ImproveWayAccuracy?

comment:16 Changed 8 years ago by stoecker

There is a list of outdated plugins in PluginHandler.java.

Changed 8 years ago by simon04

Attachment: 7184.patch added

comment:17 Changed 8 years ago by simon04

Thank you for your guiding help. :-)

Here's the patch for integrating ImproveWayAccuracy. If it looks all right, I'll commit it tonight or tomorrow morning …

comment:18 Changed 8 years ago by bastiK

I'd rename IWATargetWayHelper.java to ImproveWayAccuracyHelper.java and merge IWAGeometry.java into org/openstreetmap/josm/tools/Geometry.java.

comment:19 Changed 8 years ago by simon04

In [4846/josm]:

see #7184 - Added ImproveWayAccuracy plugin to josm core. This plugin was initially written by Alexander Kachkaev (kachkaev).

comment:20 Changed 8 years ago by simon04

In [4847/josm]:

see #7184 - ImproveWayAccuracyAction: rename mapmode button

comment:21 Changed 8 years ago by stoecker

Please if possible also copy the help from OSM wiki to the online help at Help/Action/ImproveWayAccuracy and link to this page instead to OSM wiki from StartupPageSource.

comment:22 Changed 8 years ago by stoecker

Cc: skyper added

comment:23 in reply to:  21 Changed 8 years ago by simon04

Replying to stoecker:

Please if possible also copy the help from OSM wiki to the online help at Help/Action/ImproveWayAccuracy and link to this page instead to OSM wiki from StartupPageSource.

Done.

comment:24 Changed 8 years ago by simon04

Remaining: delete the plugin from the plugin SVN repository and from Plugins.

For the former, just issue a svn rm?

comment:25 in reply to:  24 Changed 8 years ago by stoecker

Replying to simon04:

Remaining: delete the plugin from the plugin SVN repository

Already done.

and from Plugins.

In a few weeks, when tested is out and used.

Simply "svn rm" the jar-file here as well.

comment:26 Changed 8 years ago by simon04

Documentation needs to be updated due to r4850. When changing the shortcut, I prefer a key that is easily accessible with the left hand on a QWERT*-keyboard, e.g., [W] would make sense, but then the building tool plugin shortcut has to move (see DevelopersGuide/ShortcutsList).

comment:27 Changed 8 years ago by bastiK

Ok, makes sense.

comment:28 Changed 8 years ago by simon04

What should be the new shortcut for the building tool? It's challenging to find a free combination. [Shift]+[B]?

comment:29 in reply to:  28 Changed 8 years ago by akks

Replying to simon04:

What should be the new shortcut for the building tool? It's challenging to find a free combination. [Shift]+[B]?

Why do not you use E instead of I then for ImproveWayAccuracy?
Also Utilsplugin2 action, used rarely (I added it), left side of keyboard. W is used very intensively when adding buildings.

comment:30 Changed 8 years ago by simon04

The idea was to make the mapping more logical. [W] has not much to do with buildings, and [E] not much with improving way accuracy. I am aware that this way/will break the habit of users, but I expect that it may be beneficial for the long term.

comment:31 in reply to:  30 ; Changed 8 years ago by akks

Replying to simon04:

The idea was to make the mapping more logical. [W] has not much to do with buildings, and [E] not much with improving way accuracy. I am aware that this way/will break the habit of users, but I expect that it may be beneficial for the long term.

Then a possible solution is to use W for improveWayaccuracy, leave B for buildingtools and move rarely used "Distibute nodes" to Shift-B.

comment:32 in reply to:  31 Changed 8 years ago by simon04

Replying to akks:

Then a possible solution is to use W for improveWayaccuracy, leave B for buildingtools and move rarely used "Distibute nodes" to Shift-B.

That sounds good to me. The plugin buildingtools also has a shortcut for setting the building size.

comment:33 Changed 8 years ago by simon04

In [4855/josm]:

see #7184 - remap shortcuts of ImproveWayAccuracyAction ([W]), DistributeAction ([Shift]+[B])

comment:34 Changed 8 years ago by simon04

[o27587] - buildings_tools: remap shortcuts ([B], [Ctrl]+[B]) due to integration of ImproveWayAccuracy in JOSM core

comment:35 Changed 8 years ago by akks

I have commited building_tools binary from your source, setting JOSM version to 4855. There will be less shortcut conflicts...

comment:36 Changed 8 years ago by joshdoe

Resolution: fixed
Status: newclosed

This seems to be fully finished.

comment:37 in reply to:  36 Changed 8 years ago by skyper

Resolution: fixed
Status: closedreopened

Replying to joshdoe:

This seems to be fully finished.

Plugin needs to be marked depreciated under wiki:/Plugins

comment:38 Changed 8 years ago by stoecker

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.