Modify

Opened 15 years ago

Closed 14 years ago

#3386 closed defect (fixed)

Upload dialog has empty areas when the changeset doesn't include all of add/modify/delete operations

Reported by: avarab@… Owned by: team
Priority: trivial Milestone:
Component: Core Version: latest
Keywords: Cc:

Description

When uploading a changeset there's an area of the upload dialog reserved for add/modify/delete operations. It used to be the case that if you didn't have all of these the remaining operations would expand to fill the empty area. But not anymore.

See attached screenshots.

Attachments (5)

changeset-1.png (32.0 KB ) - added by avarab@… 15 years ago.
Only modify operations. Empty area on both sides
changeset-2.png (30.9 KB ) - added by avarab@… 15 years ago.
Add/modify operations. Delete area still empty
changeset-3.png (36.6 KB ) - added by avarab@… 15 years ago.
The dialog only looks normal when it has add/modify/delete operations
upload-dialog-1.png (144.2 KB ) - added by avarab@… 14 years ago.
Opening upload dialog on r2532
upload-dialog-2.png (142.4 KB ) - added by avarab@… 14 years ago.
Upload dialog after resizing on r2532

Download all attachments as: .zip

Change History (8)

by avarab@…, 15 years ago

Attachment: changeset-1.png added

Only modify operations. Empty area on both sides

by avarab@…, 15 years ago

Attachment: changeset-2.png added

Add/modify operations. Delete area still empty

by avarab@…, 15 years ago

Attachment: changeset-3.png added

The dialog only looks normal when it has add/modify/delete operations

comment:1 by Gubaer, 15 years ago

Resolution: fixed
Status: newclosed

(In [2045]) fixed #3386: Upload dialog has empty areas when the changeset doesn't include all of add/modify/delete operations

comment:2 by avarab@…, 14 years ago

Priority: normaltrivial
Resolution: fixed
Status: closedreopened

Reopening. Thus bug is happening on r2532 in a different manner than before. Now it's the changeset area that's expanding to fill the dialog sometimes instead of the uploaded object.

  1. Open JOSM
  2. Make changes by only adding objects
  3. Open upload dialog
  4. Resize the dialog, you may have to do this a few times, usually happens after 1-5 times
  5. Changeset area expands to take up the space modified/deleted objects would normally take

Instead of #5 the area with the added objects should always take up the remaining space.

by avarab@…, 14 years ago

Attachment: upload-dialog-1.png added

Opening upload dialog on r2532

by avarab@…, 14 years ago

Attachment: upload-dialog-2.png added

Upload dialog after resizing on r2532

comment:3 by Gubaer, 14 years ago

Resolution: fixed
Status: reopenedclosed

(In [2599]) fixed #4130: Chunked upload mode counter is wrong
fixed #4118: Upload dialog too complicated
fixed #4129: Hide the new "Upload data in one request/chunks/individually" behind an expanding "Upload method" box
fixed #2075: API 0.6: don't upload more than 50K edits at once
fixed #4044: Huge uploads never end [should be solved with chunked upload mode]
fixed #4110: Upload dialog spacing wrong
fixed #3386: Upload dialog has empty areas when the changeset doesn't include all of add/modify/delete operations
see #3369: bulk import helper [JOSM now supports multi changesets uploads]

See online help for more details.

Completes r2598

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.