Modify

Opened 3 months ago

Last modified 3 months ago

#20419 new defect

Map Paint Style icons are duplicated

Reported by: JeroenHoek Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: Cc:

Description (last modified by JeroenHoek)

With two Map Paint Styles in use that both have an icon called 'icon.svg' attached to their respective Trac-pages, JOSM shows them correctly in the Map paint preferences dialog where they can be downloaded, but uses the same icon from one of them for both in the menu and preferences window.

It looks like the icons get conflated if the name is the same. The icon name should probably be prefixed with the Map Paint Style name.

Reproduction

  • Go to the Map paint preferences, and refresh the list of styles
  • See that Parking lanes and Sidewalks and footways (with knobs on) both have distinct icons
  • Enable them both
  • See that the same icon is reused for both

Correct

Map paint preferences. This is as it should be.

Incorrect

Map Paint Styles menu. Icon of Parking lanes is reused for Sidewalks and footways.

Versions tested

Seen in version 17428 and 17475.

Attachments (5)

Screenshot from 2021-01-23 14-28-08.png (72.3 KB) - added by JeroenHoek 3 months ago.
Map paint preferences. This is as it should be.
2021-01-23-142850_2560x1440_scrot.png (24.0 KB) - added by JeroenHoek 3 months ago.
Map Paint Styles menu. Icon of Parking lanes is reused for Sidewalks and footways.
test-a.mapcss.zip (1.9 KB) - added by JeroenHoek 3 months ago.
Test A
test-b.mapcss.zip (1.9 KB) - added by JeroenHoek 3 months ago.
Test B
Screenshot from 2021-01-31 09-49-25.png (18.4 KB) - added by JeroenHoek 3 months ago.
Manifestation of bug.

Download all attachments as: .zip

Change History (9)

Changed 3 months ago by JeroenHoek

Map paint preferences. This is as it should be.

Changed 3 months ago by JeroenHoek

Map Paint Styles menu. Icon of Parking lanes is reused for Sidewalks and footways.

comment:1 Changed 3 months ago by JeroenHoek

Description: modified (diff)

comment:3 Changed 3 months ago by JeroenHoek

I can reproduce this with two local dummy Map Paint Styles as well. I have attached them in their zipped forms.

When I add both test A and B in their unzipped forms (selecting their mapcss files), the one added later gets the icon of the one loaded first.

When I add both as zip-files, they both get the icon from the Parking lanes style already present.

I am going to give the affected Map Paint Styles differently named icons to prevent JOSM users from seeing this bug: the attached files should reproduce it.

Changed 3 months ago by JeroenHoek

Attachment: test-a.mapcss.zip added

Test A

Changed 3 months ago by JeroenHoek

Attachment: test-b.mapcss.zip added

Test B

Changed 3 months ago by JeroenHoek

Manifestation of bug.

comment:4 Changed 3 months ago by JeroenHoek

Manifestation of bug.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to JeroenHoek
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.