Parallel ways tool: bottom toolbar unusable to view offset measurement

[Squizie3]

Parallel ways tool: the bottom toolbar 'offset measurement' switches almost instantly to show the 'way length measurement', meaning you can't determine the offset you're at anymore, making the parallel way tool very hard to use. This is most likely caused by stable release 17084 which included a fix for ticket #19830 as a 'medium enhancement', but has an unintented side effect on the parallel ways tool.

What steps will reproduce the problem?

1. Activate the parallel ways tool in the sidebar
2. Select a random way with your mouse and drag it to the side to create a parallel way
3. Watch the bottom toolbar's measurement box flicker between the offset you're making and the way length while you're dragging the mouse, making it extremely hard to see the offset you're dragging it at.

What is the expected result?

The offset being shown in the measurement box while using the parallel ways tool, until you deselect that way or select another way. This was the behaviour before the update to version 17084. Or at least keep the offset shown until you release the mouse button when dragging.

What happens instead?

The offset is only shown for literal milliseconds and gets overridden by the way's length constantly, making it almost impossible to see the offset you're making.

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Build-Date:2020-10-04 01:30:47
Revision:17084
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17084 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 824 MB / 1820 MB (667 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1280x768 (scaling 1.0x1.0)
Maximum Screen Size: 1280x768
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-7bd2a134, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=60643, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35499)
+ PicLayer (35405)
+ buildings_tools (35563)
+ log4j (35092)
+ measurement (35405)
+ pbf (35446)
+ public_transport (35405)
+ reverter (35556)
+ routing (35405)
+ splinex (35454)
+ turnrestrictions (35515)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1

[GerdP]

prevent unwanted update of status line

[GerdP]

I am not happy with this patch, I think it is more a hack than a solution.
Unlike DrawAction or DrawBuildingAction the ParallelWayAction first creates a new way and then frequently updates its nodes while dragging.

[stoecker]

I think the general idea is ok. But it should be generic. Like with a stopAutoLength() and startAutoLength() call or something similar.

[GerdP]

Replying to stoecker:

I think the general idea is ok. But it should be generic. Like with a stopAutoLength() and startAutoLength() call or something similar.

Like in the new patch? Do we need code to handle the risk that ParallelWayAction.exitMode() is not called and thus the update is not enabled again?

[stoecker]

Replying to GerdP:

Replying to stoecker:

I think the general idea is ok. But it should be generic. Like with a stopAutoLength() and startAutoLength() call or something similar.

Like in the new patch?

Let's try.

Do we need code to handle the risk that ParallelWayAction.exitMode() is not called and thus the update is not enabled again?

Yes. But I'd keep it simple: Add setAutoLength(true) in the most important of the standard mapmodes :-)

[GerdP]

In 17108/josm:

fix #19887: Parallel ways tool: bottom toolbar unusable to view offset measurement

• implememt new method MapStatus.setAutoLength()
• ParallelWayAction calls it with false in enterMode()
• call it in MapMode.enterMode() to make sure that it is reenabled even if ParallelWayAction.exitMode() is not called.

[Squizie3]

Hi all,

Thanks for fixing this bug so quickly. However, I encountered similar problems with a few more tools, so I have opened a new bug report here: #19906. Thanks for looking at that one too.

Greetings,

Squizie3

[stoecker]

Ticket #19921 has been marked as a duplicate of this ticket.

[GerdP]

Ticket #20010 has been marked as a duplicate of this ticket.

[Don-vip]

Milestone renamed

[GerdP]

Ticket #20175 has been marked as a duplicate of this ticket.