Modify

Opened 2 weeks ago

Last modified 2 weeks ago

#19906 needinfo defect

Scale, rotate & create areas tool: bottom toolbar unusable to view angle/scale factor/offset measurement

Reported by: Squizie3 Owned by: Squizie3
Priority: normal Milestone: 20.10
Component: Core Version: latest
Keywords: template_report status_bar measurement scale rotate create_areas tool regression Cc: GerdP

Description

This bug is very similar to #19887: after the update to stable release 17084 which included the enhancement #19830, you can't properly view the measurement of the action you're doing anymore, instead the length of the way you're performing the action on is shown. While for the parallel ways tool this should now be fixed, I discovered the bug also exists for the scale, rotate and create areas tools (and maybe even more). That last one works correctly for it's default tool behaviour, but not when you need to perform actions using the Ctrl button pressed.

What steps will reproduce the problem?

Rotation tool:

  1. Activate the selection tool in the sidebar
  2. Use the keyboard shortcut combination to activate the rotation tool (usually Ctrl+Shift)
  3. Start rotating a random object
  4. You cannot see any angle measurement like before. It used to show values in degrees in one of the bottom status bar's boxes (don't know exactly which one in particular anymore).

Scale tool:

  1. Activate the selection tool in the sidebar
  2. Use the keyboard shortcut combination to activate the scale tool (usually Ctrl+Alt)
  3. Start scaling a random object
  4. You cannot see any scale factor measurement like before. If I'm correct (not entirely sure about this one to be honest), it used to show values of what factor you were scaling at (e.g. 0.87) in one of the bottom status bar's boxes (don't know exactly which one in particular anymore).

Create areas tool:

  1. Make sure you are in 'expert mode' in JOSM's preferences
  2. Activate the create areas tool in the sidebar
  3. Press the Ctrl key (to move nodes or line segments, instead of the default tool's behaviour)
  4. Start moving a random object, being it a node you're moving alongside one of it's connecting lines, or a line segment.
  5. Watch the bottom status bar's measurement box flicker.

What is the expected result?

Showing the angle, scale factor or offset measurement from the tools you're using.

What happens instead?

The angle or scale factors aren't visible at all, the offset measurement flickers and is constantly overwritten by the way's length.

Please provide any additional information below. Attach a screenshot if possible.

Please take a look at #19887 for a very similar problem, that should now have been resolved.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-03 13:42:38 +0200 (Sat, 03 Oct 2020)
Build-Date:2020-10-04 01:30:47
Revision:17084
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17084 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 831 MB / 1820 MB (596 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1280x768 (scaling 1.0x1.0)
Maximum Screen Size: 1280x768
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-7bd2a134, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Djnlpx.splashport=7488, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

Plugins:
+ FastDraw (35499)
+ PicLayer (35405)
+ buildings_tools (35563)
+ log4j (35092)
+ measurement (35405)
+ pbf (35446)
+ public_transport (35405)
+ reverter (35556)
+ routing (35405)
+ splinex (35454)
+ turnrestrictions (35515)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransportV2&zip=1

Attachments (0)

Change History (4)

comment:1 Changed 2 weeks ago by GerdP

Owner: changed from team to GerdP
Status: newassigned

comment:2 Changed 2 weeks ago by GerdP

Owner: changed from GerdP to Squizie3
Status: assignedneedinfo

I cannot yet reproduce the expected behaviour for rotation tool or scaling tool with r16812 (started with skip-plugins). Can you tell me a version that showed the expected behaviour? The changes for #19830 should not have any influence on the angle field in the status line. I see you have the measurement plugin installed, maybe you refer to its panel?

I am working on a fix for the Create areas tool.

comment:3 Changed 2 weeks ago by GerdP

In 17157/josm:

see #19906: Scale, rotate & create areas tool: bottom toolbar unusable to view angle/scale factor/offset measurement

  • Let Create areas tool manage the distance field in the status line
  • enable autoupdate of the distance field in MapMode.exitMode()

comment:4 Changed 2 weeks ago by Squizie3

Thanks GerdP for the fix of the create areas tool. I will update you on the scale and rotation as soon as possible, hopefully in a few days, when I have a little time to install and check it in a previous version.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as needinfo The owner will remain Squizie3.
as The resolution will be set.
to The owner will be changed from Squizie3 to the specified user.
to The owner will be changed from Squizie3 to the specified user.
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from Squizie3 to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.