Modify

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#19573 closed enhancement (fixed)

[WIP-Patch] add some more barrier values

Reported by: skyper Owned by: team
Priority: normal Milestone: 21.10
Component: Internal preset Version:
Keywords: template_report barrier Cc: FrankOverman, Szem

Description

This is a follow-up of #17750.

Myself (comment 13):

I have attached first version of a possible patch, josm_17750.patch., which:

  • adds barrier=height_restrictor wiki

Did not make it into final patch


I was unsure about adding:

barrier=full-height_turnstile was approved but still has low numbers in use. The other three are "in use" with higher numbers.

Major job is creating/finding nice icons.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-07-21 21:39:54 +0200 (Tue, 21 Jul 2020)
Revision:16801
Build-Date:2020-07-22 01:30:52
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (3)

full-height_turnstile.svg (1.7 KB ) - added by skyper 3 years ago.
icon self created
full-height_turnstile2.svg (1.9 KB ) - added by skyper 3 years ago.
update with several colors in gradients and round bottom and top ; optimized
josm_19573.patch (5.5 KB ) - added by skyper 3 years ago.
preset and style patch; log icon missing so far

Download all attachments as: .zip

Change History (18)

in reply to:  description comment:1 by Klumbumbus, 4 years ago

Replying to skyper:

Major job is creating/finding nice icons.

Recently I stumpled over https://github.com/gravitystorm/openstreetmap-carto/issues/3638 but did not yet check if we could need some. License "use it for whatever you want"

comment:2 by skyper, 4 years ago

Ticket #20271 has been marked as a duplicate of this ticket.

comment:3 by skyper, 4 years ago

Cc: FrankOverman added

comment:4 by skyper, 3 years ago

Ticket #21440 has been marked as a duplicate of this ticket.

comment:5 by skyper, 3 years ago

Cc: Szem added

comment:6 by skyper, 3 years ago

Ok, in #21440 we are working on an icon for height_restrictor.
For full-height_turnstile we could use the icon from the wiki and enhance it with little color and gradients.
Do we find a nice icon for log?

The other two values still have low numbers and are not approved, therefore I would not include them, atm.

by skyper, 3 years ago

Attachment: full-height_turnstile.svg added

icon self created

comment:7 by skyper, 3 years ago

I have created icon self created ; icon self created

but I am not 100% satisfied.

comment:8 by skyper, 3 years ago

I have updated update with several colors in gradients and round bottom and top ; optimized ; update with several colors in gradients and round bottom and top ; optimized

My final version. Own work, I am fine with GPL3.

by skyper, 3 years ago

Attachment: full-height_turnstile2.svg added

update with several colors in gradients and round bottom and top ; optimized

comment:9 by skyper, 3 years ago

Working on the new presets I see that we also miss icons for barrier=ditch, barrier=hampshire_gate and barrier=bump_gate.

by skyper, 3 years ago

Attachment: josm_19573.patch added

preset and style patch; log icon missing so far

comment:10 by skyper, 3 years ago

Summary: add some more barrier values[WIP-Patch] add some more barrier values

Please, find attached patch for presets and style. Still, WIP as the icon for log is missing.

comment:11 by Klumbumbus, 3 years ago

Milestone: 21.10

comment:12 by Klumbumbus, 3 years ago

Resolution: fixed
Status: newclosed

In 18296/josm:

fix #19573, see #21440 - Add some more barrier values (patch by skyper):

  • barrier=log (icon derived from https://openclipart.org/detail/252925/log, PD and CC0 licensed)
  • barrier=full-height_turnstile (icon created by skyper, GPL3 licensed)
  • barrier=height_restrictor (icon created by Szem and skyper, GPL3 licensed)

comment:13 by Klumbumbus, 3 years ago

The log icon is not perfect but at least something ;)

comment:14 by Klumbumbus, 3 years ago

skyper, could you create a smaller version of update with several colors in gradients and round bottom and top ; optimized with only one horizontal bar for barrier=turnstile?

in reply to:  14 comment:15 by skyper, 3 years ago

Replying to Klumbumbus:

skyper, could you create a smaller version of update with several colors in gradients and round bottom and top ; optimized with only one horizontal bar for barrier=turnstile?

I can try but I am not sure if it will look nice (recognizable) and it is not high on my priority list.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.