[PATCH] Add a color setting for MapCSS

[taylor.smock]

Subpart of #10435.

Possibly significant modifications for plugins:

• NamedColorProperty extends AbstractToStringProperty<Color>. I'm waiting for a find to get all the instances of NamedColorProperty in plugins, but it is taking awhile (find . -name '*.java' -exec grep -li "NamedColorProperty" {} \;). I don't know if this will require a recompile of any plugins.

Notes:

• Overrode storeDefaultValue to avoid an NPE. This is required since required final variables are not yet set (a different fix would be to make them non-final).
• Color boxes are not in the same column as the check marks (I'm not certain this is possible without a lot of work, or even desirable -- there might be a case for a colorboolean setting in the future, for example).

[taylor.smock]

Initial colors setting for mapcss

[taylor.smock]

It looks like there are no binary compatibility issues. Or the published Mapillary/UtilsPlugin2 jars didn't throw errors anyway.

Plugins that use NamedColorProperty:

• splinex
• FastDraw
• Mapillary
• graphview
• CommandLine
• cadastre-fr
• mapwithai
• utilsplugin2
• routing
• buildings_tools
• MicrosoftStreetside
• livegps
• improveway

[simon04]

In 16843/josm:

fix #19574 - Add a color setting for MapCSS (patch by taylor.smock)

[simon04]

@taylor.smock, can you please update Help/Styles/MapCSSImplementation#Stylesettings – thanks!

[taylor.smock]

Done, see https://josm.openstreetmap.de/wiki/Help/Styles/MapCSSImplementation?action=diff&version=186

[Klumbumbus]

By a color setting a key is created in the color preferences in the format:
"Paint style" + file name + key used for displaying

Could it use the same format as the "traditional" colors of mappaint styles, i.e. the style name from the preferences instead of the file name?
"Paint style" + style name + key used for displaying

[taylor.smock]

I've copied the logic from https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSParser.jj?rev=16843#L1165 (mostly). I'm doing a null check on the title variable (SourceEntry may initialize title as null -- this.title = "".equals(title) ? null : title;

[taylor.smock]

Use logic from MapCSSParser to create the NamedColorProperty

[Klumbumbus]

In 16857/josm:

see #19574 - MapCSS color setting: Use logic from MapCSSParser to create the NamedColorProperty (patch by taylor.smock)