Opened 4 years ago

Closed 4 years ago

Last modified 20 months ago

#18374 closed enhancement (fixed)

warn if collection_times is used instead of opening_hours on amenity=recycling

Reported by: Klumbumbus Owned by: Klumbumbus
Priority: normal Milestone: 20.01
Component: Core validator Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

opening_hours - when you are allowed to enter trash to containers
collection_times - when the operator empties the container

see #18373

If collection_times is a time span the it is much likely the wrong key. Some regex should be used, e.g. collection_times=~/[0-9]-[0-9]/.

overpass wizard: amenity=recycling and collection_times=* global

Attachments (0)

Change History (8)

comment:1 by Klumbumbus, 4 years ago

Description: modified (diff)

comment:2 by Klumbumbus, 4 years ago

Description: modified (diff)

comment:3 by Klumbumbus, 4 years ago

Owner: changed from team to Klumbumbus
Status: newassigned

comment:4 by Klumbumbus, 4 years ago

Milestone: 19.1220.01

comment:5 by Klumbumbus, 4 years ago

Resolution: fixed
Status: assignedclosed

In 15648/josm:

comment:6 by Klumbumbus, 4 years ago

For some cases it is not clearly detectable without local knowledge if collection_times or opening_hours is meant, so the rules are written on the safer side to avoid false positives at the cost of a few undetected cases which usually have opening hours syntax errors anyway.

comment:7 by Klumbumbus, 4 years ago

In 15765/josm:

see #17555, see #18374 - enable asserts

comment:8 by Klumbumbus, 20 months ago

In 18546/josm:

Fix #22295, see #18374 - Don't warn about "collection_times together with amenity=recycling. Probably opening_hours is meant." for cases when also opening_hours is set.

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment

E-mail address and name can be saved in the Preferences .
Note: See TracTickets for help on using tickets.