collection_times together with amenity=recycling

[kapazao]

I do not think a warning should be thrown in this case.

suspicious tag combination
collection_times together with amenity=recycling. Probably opening_hours is meant.

Key:collection_times in OSM Wiki: ​https://wiki.openstreetmap.org/wiki/Key:collection_times
"The collection times of a post box, recycling container or other fixed location drop-off facility. The syntax is the same as for opening hours, including the hyphen because there are post boxes which are emptied several (undefined) times or one (undefined) time in a certain time frame."

Taginfo: ​https://taginfo.openstreetmap.org/keys/collection_times

https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L869

[Klumbumbus]

This ticket comes from ​https://github.com/osm-fr/osmose-backend/issues/1491.
The object is ​https://www.openstreetmap.org/node/9471356346 which has these tags:

amenity=recycling
collection_times=Mo-Su,PH 20:00-23:00
operator=Ecovidrio
recycling:glass_bottles=yes
recycling_type=container
ref=692

This warning for amenity=recycling appears only when collection_times is a time span like in this case, because usually collection_timesis a single point in time while opening_hours is a time span.

I would keep this warning to find cases of opening_hours wrongly tagged as collection_times, but we could remove it when both tags are set. From mappping point of view it seems unlikely that collection_times is known, but not opening_hours.

[Klumbumbus]

In 18546/josm:

Fix #22295, see #18374 - Don't warn about "collection_times together with amenity=recycling. Probably opening_hours is meant." for cases when also opening_hours is set.