Modify

Opened 2 years ago

Last modified 12 months ago

#18375 new enhancement

warn on waterway and highway shared node that is not a ford

Reported by: aceman Owned by: team
Priority: minor Milestone:
Component: Core validator Version: latest
Keywords: connected ford Cc:

Description

Currently JOSM properly warns when a waterway and a highway with the same layer intersect without a shared node. The user is supposed to make a bridge, culvert or a ford. But it is possible to silence this warning by adding a shared node, without any tags. Such a 'fake ford' makes JOSM happy, but introduces invalid data. Waterway and highway aren't normally supposed to meet in the same vertical level. One exception is a ford, but then it needs a ford=yes tag.

I suggest JOSM also issues a warning if that shared node has no tags.
Maybe there are other cases different from ford where the ways meet in a shared node (maybe e.g. a weir) so it is up to you whether any tag is enough to fix the warning, or it must be ford=yes specifically.

Also note the ford=yes can be tagged on the way inside the riverbanks, in which case the shared node will still exist, but not have the ford=yes tag itself. JOSM shold cover this case and not issue the warning either.

See https://wiki.openstreetmap.org/wiki/Tag:ford%3Dyes .

Attachments (1)

josm_18375_ford_examples.osm (7.2 KB) - added by skyper 12 months ago.
some virtual examples

Download all attachments as: .zip

Change History (5)

comment:1 in reply to:  description Changed 2 years ago by Hb---

Replying to aceman:

Also note the ford=yes can be tagged on the way inside the riverbanks, in which case the shared node will still exist, but not have the ford=yes tag itself.

This sentence is not understandable. When you tag a ford you have a ford.

Currently JOSM warns even when a riverbank is crossed. This case should throw no warning.

comment:2 Changed 2 years ago by aceman

I say there is a difference when the ford=yes is on a common node and when it is on a way, that shares a node with the waterway, but should not have the ford=yes tag.

Last edited 2 years ago by aceman (previous) (diff)

Changed 12 months ago by skyper

some virtual examples

comment:3 Changed 12 months ago by skyper

Ok, for railway=* this should always be a warning. There are no fords for railways, are there?
For highway=* there is a similar problem as the railway crossings in #17074. What to do with end nodes of highways and touching or multiple highways connected from only one side?
I made up some examples: josm_18375_ford_examples.osm

comment:4 Changed 12 months ago by skyper

Keywords: connected ford added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to aceman
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.