Modify

Opened 2 years ago

Closed 2 years ago

#18172 closed enhancement (fixed)

Add new imagery categories "elevation" and "qa"

Reported by: simon04 Owned by: team
Priority: normal Milestone: 20.01
Component: Core imagery Version:
Keywords: terrain elevation category qa Cc:

Description

In Maps/Austria we have at least five layers related to terrain (hillshade, surface, contour lines). Let's put those in a <category>terrain</category>.

Attachments (0)

Change History (43)

comment:1 Changed 2 years ago by Don-vip

ok, but we need an icon :)

comment:2 Changed 2 years ago by stoecker

What's the purpose of terrain and why does this not fit in any other category. There was a reason that we have so few categories!

comment:3 Changed 2 years ago by Klumbumbus

The number of sources in the category "other" is pretty high and "terrain" sources might be the biggest group in "other", so I'm not opposed to this change.

comment:5 Changed 2 years ago by Don-vip

+1, we have way too many "other" entries. Should we call this one "terrain" or "elevation"? On wikipedia, digital terrain model and digital surface model all redirect to "digital elevation model" article which looks like the more common/generic term. We also have the elevation plugin, so it might be consistent.

comment:6 Changed 2 years ago by Don-vip

Keywords: terrain elevation category added
Milestone: 19.10

comment:7 Changed 2 years ago by stoecker

Not totally on topic, but near enough :-)

ELI thinks about adapting JOSM category and wants a "qa" group, see https://github.com/osmlab/editor-layer-index/issues/136. I find the idea of qa useful, but have a bit trouble with a new category for this. For me this is more like a flag, but that OTOH would make the category idea more complicated. Ideas, comments (also about the terrain idea of this ticket)?

I think we shouldn't have too fine-grained categories, but keeping a very low category number when there is need is also not the best way.

comment:8 Changed 2 years ago by Klumbumbus

I'm in favor of adding "QA" and "elevation" as new categories.

comment:9 Changed 2 years ago by stoecker

  • How many for each would we have?
  • Coming from where (I assume QA mainly from osmbased and elevation from other)?
  • Any images?

comment:10 Changed 2 years ago by Klumbumbus

No, all QA are currently in "other" too.

comment:11 Changed 2 years ago by Klumbumbus

On a quick look I count:
QA: 19 (11 osm inspector, 4 QA poole.ch, 4 tiger roads)
elevation: 26

comment:12 Changed 2 years ago by Klumbumbus

comment:13 in reply to:  12 ; Changed 2 years ago by stoecker

Replying to Klumbumbus:

icons:
QA: our validator icon?

I found checkmarks surrounded by circles, wheels and so on for qa. In terms of OSM the validator checkmark seems a very good idea.

Name: QA, qa, quality or validation? There are valid arguments for each. I'd tend to one of the nouns as they are more like the others.

elevation: something like https://www.ideaspectrum.com/help/2016/arch/ImagesExt/landscape-design-contour-line-plan.jpg?

I had a similar idea. Probably a cut of this with the outline of our josm map logo and no numbers or other finer details?

Last edited 2 years ago by stoecker (previous) (diff)

comment:14 in reply to:  10 Changed 2 years ago by stoecker

Replying to Klumbumbus:

No, all QA are currently in "other" too.

Well that makes it easier. ☺️

comment:15 in reply to:  13 Changed 2 years ago by Klumbumbus

Replying to stoecker:

I'd tend to one of the nouns as they are more like the others.

Then maybe "quality assurance" is the best choice.

comment:16 Changed 2 years ago by simon04

Milestone: 20.01

comment:17 Changed 2 years ago by simon04

Resolution: fixed
Status: newclosed

In 15658/josm:

fix #18172 - Add new imagery categories "elevation" and "qa"

comment:18 Changed 2 years ago by Don-vip

Welcome back! \o/

comment:19 Changed 2 years ago by Don-vip

Keywords: qa added
Summary: Add new imagery category "terrain"Add new imagery categories "elevation" and "qa"

comment:20 Changed 2 years ago by stoecker

New icons really should be SVG!

comment:21 Changed 2 years ago by stoecker

Resolution: fixed
Status: closedreopened

Documentation missing: Maps

comment:22 Changed 2 years ago by Klumbumbus

Should we update the categories in the wiki already or does this break current josm-tested?

comment:23 in reply to:  22 Changed 2 years ago by stoecker

Replying to Klumbumbus:

Should we update the categories in the wiki already or does this break current josm-tested?

It does not.

comment:24 Changed 2 years ago by stoecker

Or better: It should not :-)

comment:25 Changed 2 years ago by Klumbumbus

Yes, every unknown category is handled the same as category "other".

comment:28 Changed 2 years ago by Klumbumbus

Regarding icons, the validator icon can be handled easily later in the cource of #15240, but Simon do you have a svg variant of the elevation icon?

comment:29 Changed 2 years ago by Klumbumbus

In 15685/josm:

see #18172 - contour lines should go into category elevation too

comment:30 in reply to:  28 Changed 2 years ago by simon04

Replying to Klumbumbus:

Simon do you have a svg variant of the elevation icon?

No, I took the ​ElevationProfile icon from Plugins.

comment:31 Changed 2 years ago by Don-vip

In 15692/josm:

see #18172 - compare ELI and JOSM categories + fix missed @since xxx

comment:32 Changed 2 years ago by Klumbumbus

There is one false positive on ImageryCompare.

comment:33 Changed 2 years ago by Don-vip

In 15693/josm:

see #18172 - don't forget categoryOriginalString in copy constructor

comment:34 Changed 2 years ago by Klumbumbus

In 15698/josm:

see #18172 - fix script: "Different categories" should be red

comment:35 Changed 2 years ago by stoecker

Why should Waymarked Trails be no map?

comment:36 Changed 2 years ago by stoecker

Different categories Output should contain both categories in the message.

comment:37 in reply to:  35 Changed 2 years ago by Klumbumbus

Replying to stoecker:

Why should Waymarked Trails be no map?

Because it only shows one special object type. wiki:Maps: "If a source is specialized on one or two features e.g. shows only landuses or only roads and rivers or only buildings use other rather than map."

comment:38 Changed 2 years ago by Klumbumbus

In 15699/josm:

see #18172 - fix typo in message, include actual categories in message

comment:39 Changed 2 years ago by stoecker

I added category support to the maps geojson output.

comment:40 in reply to:  39 Changed 2 years ago by Klumbumbus

Replying to stoecker:

I added category support to the maps geojson output.

There is one thing that could be improved in the ELI-> xml conversion script (imagery_eliout.imagery.xml): If a URL contains a & (often in wms URLs) then <![CDATA[ ]]> should be added around. Currently that needs to be done manually when copying new entries from ELI to JOSM.

comment:41 Changed 2 years ago by stoecker

In 15712/josm:

see #18172 - reactivate cdata, seems Groovy and Java handle RegExp differently

comment:42 in reply to:  41 Changed 2 years ago by Klumbumbus

Replying to stoecker:

In 15712/josm:

see #18172 - reactivate cdata, seems Groovy and Java handle RegExp differently

Thx.

comment:43 Changed 2 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

Ticket is fixed. A svg elevation icon is still welcome.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.