Add new imagery categories "elevation" and "qa"

[simon04]

In Maps/Austria we have at least five layers related to terrain (hillshade, surface, contour lines). Let's put those in a <category>terrain</category>.

[Don-vip]

ok, but we need an icon :)

[stoecker]

What's the purpose of terrain and why does this not fit in any other category. There was a reason that we have so few categories!

[Klumbumbus]

The number of sources in the category "other" is pretty high and "terrain" sources might be the biggest group in "other", so I'm not opposed to this change.

[Klumbumbus]

references:

• #16103
• ticket:16301#comment:29
• ticket:16301#comment:32

[Don-vip]

+1, we have way too many "other" entries. Should we call this one "terrain" or "elevation"? On wikipedia, digital terrain model and digital surface model all redirect to "digital elevation model" article which looks like the more common/generic term. We also have the elevation plugin, so it might be consistent.

[stoecker]

Not totally on topic, but near enough :-)

ELI thinks about adapting JOSM category and wants a "qa" group, see ​https://github.com/osmlab/editor-layer-index/issues/136. I find the idea of qa useful, but have a bit trouble with a new category for this. For me this is more like a flag, but that OTOH would make the category idea more complicated. Ideas, comments (also about the terrain idea of this ticket)?

I think we shouldn't have too fine-grained categories, but keeping a very low category number when there is need is also not the best way.

[Klumbumbus]

I'm in favor of adding "QA" and "elevation" as new categories.

[stoecker]

• How many for each would we have?
• Coming from where (I assume QA mainly from osmbased and elevation from other)?
• Any images?

[Klumbumbus]

No, all QA are currently in "other" too.

[Klumbumbus]

On a quick look I count:
QA: 19 (11 osm inspector, 4 QA poole.ch, 4 tiger roads)
elevation: 26

[Klumbumbus]

icons:
QA: our validator icon?
elevation: something like ​https://www.ideaspectrum.com/help/2016/arch/ImagesExt/landscape-design-contour-line-plan.jpg?

[stoecker]

Replying to Klumbumbus:

icons:
QA: our validator icon?

I found checkmarks surrounded by circles, wheels and so on for qa. In terms of OSM the validator checkmark seems a very good idea.

Name: QA, qa, quality or validation? There are valid arguments for each. I'd tend to one of the nouns as they are more like the others.

elevation: something like ​https://www.ideaspectrum.com/help/2016/arch/ImagesExt/landscape-design-contour-line-plan.jpg?

I had a similar idea. Probably a cut of this with the outline of our josm map logo and no numbers or other finer details?

[stoecker]

Replying to Klumbumbus:

No, all QA are currently in "other" too.

Well that makes it easier. ☺️

[Klumbumbus]

Replying to stoecker:

I'd tend to one of the nouns as they are more like the others.

Then maybe "quality assurance" is the best choice.

[simon04]

don-vip in ​https://github.com/osmlab/editor-layer-index/issues/136#issuecomment-549375398

I'm ok with qa :)

[simon04]

In 15658/josm:

fix #18172 - Add new imagery categories "elevation" and "qa"

[Don-vip]

Welcome back! \o/

[stoecker]

New icons really should be SVG!

[stoecker]

Documentation missing: Maps

[Klumbumbus]

Should we update the categories in the wiki already or does this break current josm-tested?

[stoecker]

Replying to Klumbumbus:

Should we update the categories in the wiki already or does this break current josm-tested?

It does not.

[stoecker]

Or better: It should not :-)

[Klumbumbus]

Yes, every unknown category is handled the same as category "other".

[Klumbumbus]

I changed all affected categories: https://josm.openstreetmap.de/timeline?from=2020-01-11&daysback=1&authors=Klumbumbus&wiki=on&sfp_email=&sfph_mail=&update=Aktualisieren
19 qa and 30 elevation

[Klumbumbus]

docu added:

• https://josm.openstreetmap.de/wiki/Maps?action=diff&version=568
• https://josm.openstreetmap.de/wiki/Help/Menu/Imagery?action=diff&version=63
• https://josm.openstreetmap.de/wiki/Help/Preferences/Imagery?action=diff&version=32

[Klumbumbus]

Regarding icons, the validator icon can be handled easily later in the cource of #15240, but Simon do you have a svg variant of the elevation icon?

[Klumbumbus]

In 15685/josm:

see #18172 - contour lines should go into category elevation too

[simon04]

Replying to Klumbumbus:

Simon do you have a svg variant of the elevation icon?

No, I took the ​ElevationProfile icon from Plugins.

[Don-vip]

In 15692/josm:

see #18172 - compare ELI and JOSM categories + fix missed @since xxx

[Klumbumbus]

There is one false positive on ImageryCompare.

[Don-vip]

In 15693/josm:

see #18172 - don't forget categoryOriginalString in copy constructor

[Klumbumbus]

In 15698/josm:

see #18172 - fix script: "Different categories" should be red

[stoecker]

Why should Waymarked Trails be no map?

[stoecker]

Different categories Output should contain both categories in the message.

[Klumbumbus]

Replying to stoecker:

Why should Waymarked Trails be no map?

Because it only shows one special object type. wiki:Maps: "If a source is specialized on one or two features e.g. shows only landuses or only roads and rivers or only buildings use other rather than map."

[Klumbumbus]

In 15699/josm:

see #18172 - fix typo in message, include actual categories in message

[stoecker]

I added category support to the maps geojson output.

[Klumbumbus]

Replying to stoecker:

I added category support to the maps geojson output.

There is one thing that could be improved in the ELI-> xml conversion script (imagery_eliout.imagery.xml): If a URL contains a & (often in wms URLs) then <![CDATA[ ]]> should be added around. Currently that needs to be done manually when copying new entries from ELI to JOSM.

[stoecker]

In 15712/josm:

see #18172 - reactivate cdata, seems Groovy and Java handle RegExp differently

[Klumbumbus]

Replying to stoecker:

In 15712/josm:

see #18172 - reactivate cdata, seems Groovy and Java handle RegExp differently

Thx.

[Klumbumbus]

Ticket is fixed. A svg elevation icon is still welcome.