Opened 4 years ago
Closed 4 years ago
#18172 closed enhancement (fixed)
Add new imagery categories "elevation" and "qa"
Reported by: | simon04 | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 20.01 |
Component: | Core imagery | Version: | |
Keywords: | terrain elevation category qa | Cc: |
Description
In Maps/Austria we have at least five layers related to terrain (hillshade, surface, contour lines). Let's put those in a <category>terrain</category>
.
Attachments (0)
Change History (43)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
What's the purpose of terrain and why does this not fit in any other category. There was a reason that we have so few categories!
comment:3 Changed 4 years ago by
The number of sources in the category "other" is pretty high and "terrain" sources might be the biggest group in "other", so I'm not opposed to this change.
comment:5 Changed 4 years ago by
+1, we have way too many "other" entries. Should we call this one "terrain" or "elevation"? On wikipedia, digital terrain model and digital surface model all redirect to "digital elevation model" article which looks like the more common/generic term. We also have the elevation plugin, so it might be consistent.
comment:6 Changed 4 years ago by
Keywords: | terrain elevation category added |
---|---|
Milestone: | 19.10 |
comment:7 Changed 4 years ago by
Not totally on topic, but near enough :-)
ELI thinks about adapting JOSM category and wants a "qa" group, see https://github.com/osmlab/editor-layer-index/issues/136. I find the idea of qa useful, but have a bit trouble with a new category for this. For me this is more like a flag, but that OTOH would make the category idea more complicated. Ideas, comments (also about the terrain idea of this ticket)?
I think we shouldn't have too fine-grained categories, but keeping a very low category number when there is need is also not the best way.
comment:9 Changed 4 years ago by
- How many for each would we have?
- Coming from where (I assume QA mainly from osmbased and elevation from other)?
- Any images?
comment:11 Changed 4 years ago by
On a quick look I count:
QA: 19 (11 osm inspector, 4 QA poole.ch, 4 tiger roads)
elevation: 26
comment:12 follow-up: 13 Changed 4 years ago by
icons:
QA: our validator icon?
elevation: something like https://www.ideaspectrum.com/help/2016/arch/ImagesExt/landscape-design-contour-line-plan.jpg?
comment:13 follow-up: 15 Changed 4 years ago by
Replying to Klumbumbus:
icons:
QA: our validator icon?
I found checkmarks surrounded by circles, wheels and so on for qa. In terms of OSM the validator checkmark seems a very good idea.
Name: QA, qa, quality or validation? There are valid arguments for each. I'd tend to one of the nouns as they are more like the others.
elevation: something like https://www.ideaspectrum.com/help/2016/arch/ImagesExt/landscape-design-contour-line-plan.jpg?
I had a similar idea. Probably a cut of this with the outline of our josm map logo and no numbers or other finer details?
comment:14 Changed 4 years ago by
comment:15 Changed 4 years ago by
Replying to stoecker:
I'd tend to one of the nouns as they are more like the others.
Then maybe "quality assurance" is the best choice.
comment:16 Changed 4 years ago by
Milestone: | → 20.01 |
---|
don-vip in https://github.com/osmlab/editor-layer-index/issues/136#issuecomment-549375398
I'm ok with
qa
:)
comment:19 Changed 4 years ago by
Keywords: | qa added |
---|---|
Summary: | Add new imagery category "terrain" → Add new imagery categories "elevation" and "qa" |
comment:21 Changed 4 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Documentation missing: Maps
comment:22 follow-up: 23 Changed 4 years ago by
Should we update the categories in the wiki already or does this break current josm-tested?
comment:23 Changed 4 years ago by
Replying to Klumbumbus:
Should we update the categories in the wiki already or does this break current josm-tested?
It does not.
comment:25 Changed 4 years ago by
Yes, every unknown category is handled the same as category "other".
comment:26 Changed 4 years ago by
I changed all affected categories: https://josm.openstreetmap.de/timeline?from=2020-01-11&daysback=1&authors=Klumbumbus&wiki=on&sfp_email=&sfph_mail=&update=Aktualisieren
19 qa and 30 elevation
comment:28 follow-up: 30 Changed 4 years ago by
Regarding icons, the validator icon can be handled easily later in the cource of #15240, but Simon do you have a svg variant of the elevation icon?
comment:30 Changed 4 years ago by
Replying to Klumbumbus:
Simon do you have a svg variant of the elevation icon?
No, I took the ElevationProfile icon from Plugins.
comment:36 Changed 4 years ago by
Different categories Output should contain both categories in the message.
comment:37 Changed 4 years ago by
comment:39 follow-up: 40 Changed 4 years ago by
I added category support to the maps geojson output.
comment:40 Changed 4 years ago by
Replying to stoecker:
I added category support to the maps geojson output.
There is one thing that could be improved in the ELI-> xml conversion script (imagery_eliout.imagery.xml): If a URL contains a &
(often in wms URLs) then <![CDATA[
]]>
should be added around. Currently that needs to be done manually when copying new entries from ELI to JOSM.
comment:43 Changed 4 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Ticket is fixed. A svg elevation icon is still welcome.
ok, but we need an icon :)