Modify

Opened 10 months ago

Last modified 4 weeks ago

#16301 new enhancement

Add filter and icon for map types

Reported by: stoecker Owned by: team
Priority: normal Milestone: 19.03
Component: Core imagery Version:
Keywords: Cc:

Description (last modified by Klumbumbus)

See #16103

The list of imagery in prefs should allow to filter for the types.

If possible the different types should be displayed with a small icon.

Category is already added to all entries in the wiki.

Attachments (0)

Change History (42)

comment:1 Changed 10 months ago by Klumbumbus

And a filter by text please too, (similar to the filterbox for projections), which allows to e.g. filter entries by country (filtertext "de") or city (filtertext "berlin").

comment:2 Changed 10 months ago by Klumbumbus

Ticket #16136 has been marked as a duplicate of this ticket.

comment:3 Changed 10 months ago by Don-vip

Why 18.08?

comment:4 Changed 10 months ago by stoecker

June is too early (first data needs to be added to Maps) and in July I will have no time...

comment:5 Changed 9 months ago by Klumbumbus

The wiki doesn't yet allow the category attribute.
Warnung: Ungültige Wiki-Seite: XML validation for map failed: Element '{http://josm.openstreetmap.de/maps-1.0}entry', attribute 'category': The attribute 'category' is not allowed.

comment:6 in reply to:  5 Changed 9 months ago by stoecker

Replying to Klumbumbus:

The wiki doesn't yet allow the category attribute.
Warnung: Ungültige Wiki-Seite: XML validation for map failed: Element '{http://josm.openstreetmap.de/maps-1.0}entry', attribute 'category': The attribute 'category' is not allowed.

Tried
<category>xxx</category>
and it worked fine. Where exactly did you try?

comment:7 Changed 9 months ago by Klumbumbus

I tried <entry category="photo"> cause it is listed under attributes at wiki:Maps

comment:9 Changed 9 months ago by Klumbumbus

Description: modified (diff)

comment:10 Changed 9 months ago by Don-vip

Description: modified (diff)

comment:11 Changed 9 months ago by Don-vip

Description: modified (diff)

comment:12 Changed 9 months ago by Klumbumbus

Description: modified (diff)

comment:13 Changed 9 months ago by Klumbumbus

Description: modified (diff)

comment:14 Changed 8 months ago by Klumbumbus

Description: modified (diff)

comment:15 Changed 7 months ago by Don-vip

Milestone: 18.0818.09

comment:16 Changed 6 months ago by Don-vip

Milestone: 18.0918.10

comment:17 Changed 5 months ago by Don-vip

Milestone: 18.1018.11

comment:18 Changed 5 months ago by Klumbumbus

Description: modified (diff)

comment:19 Changed 5 months ago by Klumbumbus

Description: modified (diff)

comment:20 Changed 5 months ago by Klumbumbus

Description: modified (diff)

comment:21 Changed 4 months ago by Don-vip

Milestone: 18.1118.12

comment:22 Changed 4 months ago by stoecker

We should icons now (also to honor Klumbumbus work). Any proposals for icons?

comment:23 Changed 4 months ago by Don-vip

Ideas. Licenses to check:

  • https://cdn0.iconfinder.com/data/icons/internet-line/512/Internet_Line-16-512.png photo aerial or satellite photo
  • https://cdn2.iconfinder.com/data/icons/essential-web-5/50/map-direction-diagram-path-route-512.png map a map
  • https://cdn1.iconfinder.com/data/icons/airline-flight-booking-mobile-app/15/recent-time-search-reload-time-512.png historicmap historic or otherwise outdated map
  • https://josm.openstreetmap.de/export/14475/josm/trunk/images/layer/osmdata_small.png osmbasedmap map based on OSM data
  • https://cdn1.iconfinder.com/data/icons/circus-element/64/Balloon-hot-transportation-transport-circus-512.png historicphoto historic or otherwise outdated aerial or satellite photo
  • https://cdn0.iconfinder.com/data/icons/glyphpack/34/question-circle-512.png other any other type
Last edited 4 months ago by Don-vip (previous) (diff)

comment:24 in reply to:  23 ; Changed 4 months ago by Klumbumbus

Replying to Don-vip:

Ideas.

Nice.
That one is not recognizable at 16px though. https://cdn1.iconfinder.com/data/icons/circus-element/64/Balloon-hot-transportation-transport-circus-512.png At least I didn't understand what that is until I opened the full size.

What about using the same icons for photo and historicphoto and for map and historicmap while the normal variant is coloured and the historic variant greyscale?

comment:25 in reply to:  24 Changed 4 months ago by stoecker

Replying to Klumbumbus:

Replying to Don-vip:

Ideas.

Nice.
That one is not recognizable at 16px though. https://cdn1.iconfinder.com/data/icons/circus-element/64/Balloon-hot-transportation-transport-circus-512.png At least I didn't understand what that is until I opened the full size.

Same for me. Also the historicmap is not really obvious.

What about using the same icons for photo and historicphoto and for map and historicmap while the normal variant is coloured and the historic variant greyscale?

I like that.

comment:26 Changed 4 months ago by Klumbumbus

Description: modified (diff)

comment:27 Changed 4 months ago by Klumbumbus

Description: modified (diff)

comment:28 Changed 3 months ago by Klumbumbus

Description: modified (diff)

comment:29 Changed 3 months ago by Klumbumbus

All categories are added. We have:

303x photo
70x historicphoto
63x map
93x historicmap
42x osmbasedmap
154x other

In total 725 active (i.e. not disabled) entries.

comment:30 Changed 3 months ago by Klumbumbus

Can we please have a check either in SyncEditorLayerIndex.groovy or make it mandatory in the xml checks in the wiki that every entry has an category property?

comment:31 Changed 3 months ago by Don-vip

154 other? That's a huge number, do you think we could add a new category? What are all these sources about?

comment:32 in reply to:  31 Changed 3 months ago by Klumbumbus

Replying to Don-vip:

154 other? That's a huge number, do you think we could add a new category? What are all these sources about?

Mostly overlays of one feature (streets, buildings, administrative boundaries,...), but also elevation modells (hill shading), contour lines, OSM validation overlays, WMTS/wms_endpoint sources containing layers of different categories.

comment:33 Changed 3 months ago by Don-vip

In 14541/josm:

see #16301 - make category mandatory

comment:34 Changed 3 months ago by Klumbumbus

In 14552/josm:

  • see #16301 - make id mandatory
  • see #17058 - add asserts to territories.mapcss

comment:35 Changed 3 months ago by stoecker

I'm not so happy to make these attributes mandatory. That may be true for our wiki, but not necessary elsewhere. Making them mandatory prevents loading when the attributes aren't there.

I'd rather test them with the Sync script.

comment:36 Changed 3 months ago by stoecker

Hmm, seems minOccurs does not do anything at all. You can remove all these arguments without an error.

comment:37 Changed 3 months ago by stoecker

In 14554/josm:

see #16301 - make sync script stable against missing data

comment:38 in reply to:  35 ; Changed 3 months ago by Klumbumbus

Replying to stoecker:

I'm not so happy to make these attributes mandatory.

OK, I thought maps.xsd is only for the wiki. Please change it to a better solution.

comment:39 in reply to:  38 Changed 3 months ago by stoecker

Replying to Klumbumbus:

Replying to stoecker:

I'm not so happy to make these attributes mandatory.

OK, I thought maps.xsd is only for the wiki. Please change it to a better solution.

No. These XSD are the files JOSM uses for validation.

But as said it seems minOccurs doesn't have an effect. The Sync script now screams if these fields are missing :-)

comment:40 Changed 3 months ago by Don-vip

Milestone: 18.1219.01

comment:41 Changed 8 weeks ago by Don-vip

Milestone: 19.0119.02

comment:42 Changed 4 weeks ago by Don-vip

Milestone: 19.0219.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to stoecker
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.