Modify

Opened 8 years ago

Last modified 4 years ago

#13706 new defect

History browser: color moved relation members differently

Reported by: openstreetmap.org-user-d1g Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: ObjectHistory background highlight children Cc:

Description (last modified by skyper)

What steps will reproduce the problem?

  1. open https://www.openstreetmap.org/api/0.6/relation/380531/201, download incomplete members
  2. open Help/Dialog/RelationEditor, move first 7 nameless highways one item below
  3. close RE
  4. open History window of relation Help/Action/ObjectHistory
  5. wait for API response, scroll down to see latest changes

What is the expected result?

way 117849711 couldn't be red or green as none of relation members were removed or added

What happens instead?

see that way 117849711 is both: red (on the left) and green (on the right)

Please provide any additional information below. Attach a screenshot if possible.


URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-09-06 00:16:07 +0200 (Tue, 06 Sep 2016)
Build-Date:2016-09-05 22:21:00
Revision:10966
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10966 en) Linux Ubuntu 16.04.1 LTS
Memory Usage: 179 MB / 1774 MB (32 MB allocated, but free)
Java version: 1.8.0_91-8u91-b14-3ubuntu1~16.04.1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u91-b14-3ubuntu1~16.04.1
WebStart package: icedtea-netx:amd64-1.6.2-3ubuntu1
VM arguments: [-Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Plugins:
+ ShapeTools (1220)

Last errors/warnings:
- W: Unable to get color from '' for color preference 'extrude.main.line'
- W: Unable to get color from '' for color preference 'improve.way.accuracy.helper.line'
- W: Unable to get color from '' for color preference 'make.parallel.helper.line'
- W: Unsaved changes - <html>The relation has been changed.<br><br>Do you want to save your changes?</html>

Attachments (2)

relation-380531-201 edited.osm (660.0 KB ) - added by openstreetmap.org-user-d1g 8 years ago.
relation-380531-201 in 10966.png (31.1 KB ) - added by openstreetmap.org-user-d1g 8 years ago.

Download all attachments as: .zip

Change History (6)

by openstreetmap.org-user-d1g, 8 years ago

by openstreetmap.org-user-d1g, 8 years ago

comment:1 by skyper, 8 years ago

Description: modified (diff)

comment:2 by simon04, 8 years ago

Summary: Wrong colours in the history browser, Members tabHistory browser: color moved relation members differently
Type: defectenhancement

The member has been removed from position 8, and added to position 1. An improvement would be to detect moved relation members and color them differently.

comment:3 by skyper, 4 years ago

Keywords: background highlight children added
Type: enhancementdefect

This is a defect now, as it gives false information. The right side has often the wrong background as the color depends on the row (left side) and not the object and its id. Working with a long list of 1000+ members, it is almost impossible to find the member which changed position on the right side as background and selection highlighting does not work. See #12548 for the ticket about way's children.

Still present in latest:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-29 21:11:25 +0200 (Fri, 29 May 2020)
Revision:16523
Build-Date:2020-05-30 01:30:48
URL:https://josm.openstreetmap.de/svn/trunk

comment:4 by skyper, 4 years ago

The problem is that the coloring is bounded to the rows and not the id. I had really difficulties to find a way with orange on the left side on the right side. Compare version 11 with version 23 of relation 71647.

For a small example have a look at relation 3375525 and compare version 3 with 4. This is only a change of order but:

  • left side:
    1. 274008802 should be orange
  • right side
    1. 274008802 should be orange

Even if you only look at the left side the red for 274008802 is wrong as it is still a member.

small example of problem

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to openstreetmap.org-user-d1g.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.