Modify

Opened 5 years ago

Last modified 9 months ago

#12548 new defect

Proper colors for modified nodes in way history

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Core Version: tested
Keywords: ObjectHistory background highlight children Cc:

Description

I was noticing that the colors in the history viewer sometimes makes us wrongly understand what happened.
For example:

http://i.imgur.com/SyTNvry.png

Looking at this somebody will think that 4 nodes were deleted and 12 new nodes were created, while, in fact, the 4 nodes in red where only reorganized/reordered.

Shouldn't they be represented in yellow for cases like this?

JOSM:

Build-Date:2016-02-20 18:51:33
Revision:9843
Is-Local-Build:true

Identification: JOSM/1.5 (9843 SVN pt_BR) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 1089 MB / 3641 MB (914 MB allocated, but free)
Java version: 1.8.0_72-internal-b15, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (3)

colours.PNG (43.1 KB) - added by GerdP 9 months ago.
josm_history_node_list.png (69.0 KB) - added by skyper 9 months ago.
screenshot of confusing colors
josm_history_node_list_example.joz (2.0 KB) - added by skyper 9 months ago.
example session for screenshot

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 months ago by skyper

Keywords: ObjectHistory background highlight children added
Type: enhancementdefect
Version: tested

For me this is a defect, now, as it gives false information. The right side has often the wrong background as the color depends on the row (left side) and not the object and its id. See #13706 for the ticket about relation's children.

Still present in latest:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-29 21:11:25 +0200 (Fri, 29 May 2020)
Revision:16523
Build-Date:2020-05-30 01:30:48
URL:https://josm.openstreetmap.de/svn/trunk

Changed 9 months ago by GerdP

Attachment: colours.PNG added

comment:2 Changed 9 months ago by GerdP

Do we have a legend that explains the meaning of the colours? I don't understand the meaning of the light red colour.
My understanding is that the last two nodes of version 5 where deleted and node 5634875611 was added.
So, I would expect two red rows on the left and one green row on the right
Screenshot of way 278014028 was made with tested r16239, r16523 is similar.

Last edited 9 months ago by GerdP (previous) (diff)

comment:3 Changed 9 months ago by Klumbumbus

IIRC the colors compare the content of the lines. The second last is orange because the node id in that line changed. The last is red because the node in that line was removed. This is probably not the most intuitive way. A little legend is at wiki:/Help/Action/ObjectHistory#Overview

comment:4 Changed 9 months ago by simon04

The diff types (DiffItemType) and their corresponding colors are defined in trunk/src/org/openstreetmap/josm/gui/history/TwoColumnDiff.java

The workflow is as follows:

  • diff the two relation members → DiffItemType
  • take the corresponding color → red/orange/yellow/green/gray
  • display as table
  • possibly highlight the current table row (see comment ticket:19253#comment:4)

Changed 9 months ago by skyper

Attachment: josm_history_node_list.png added

screenshot of confusing colors

Changed 9 months ago by skyper

example session for screenshot

comment:5 Changed 9 months ago by skyper

See josm_history_node_list_example.joz as an example for what can happen and which produces the following confusing colors:

  • left side:
    1. 2045169571 was deleted, should be red
    2. 2045169488 was moved, should be orange(yellow?)
  • right side
    1. new node show be green (own row?)
    2. 2045169488 was moved, should be orange(yellow?)
    3. new node is green. Only correct color in my eyes except the unchanged nodes

Even if only the left side is taken into account the color and possibly the row placement do not fit.

screenshot of confusing colors

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to naoliv
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.