consistency between preset and default mappaint style

[Klumbumbus]

This ticket can be used to refer to, when changes are made regarding to this topic.

The goal is:

1. same icon for one feature
2. support of the same geometries (node,way,closedway,relation)

in preset and mappaint style.

Also every item in the preset menu should have its own icon.

Deprecated icons should be moved to images_nodist folder.

So far the following changes have already been made:

[7717] - landuse=orchard, barrier=spikes, man_made=groyne, man_made=breakwater
[7711] - landuse
[7724] - sport
[7728] - generator:source
[7729] - golf
[7735] - natural
[7738] - amenity=drinking_water
[7744] - restriction
[7668][7736][7739] - move deprecated icons to images_nodist/presets folder

​related osm svn changes

...more will come...

[bastiK]

TODO: barrier=bollard

[Klumbumbus]

In 7821/josm:

see #10835 - icon unification and geometry consistency for barrier=*

[Klumbumbus]

In 7854/josm:

see #10835 - icon unification and geometry consistency for highway waypoints

[Klumbumbus]

In 7877/josm:

see #10835 - remove highway=unsurfaced from mapaint style

[Klumbumbus]

There is still some work to do. I will do it in next milestone.

[Klumbumbus]

todo: aerialway=t-bar

[Don-vip]

You can do it now if you want :)

[Klumbumbus]

Replying to Don-vip:

You can do it now if you want :)

No, I want to do it in the next days and check the whole aerialway group. This was just a reminder, that I do not forget this :)

[Don-vip]

allright!

[Klumbumbus]

In 7915/josm:

see #10835 - icon unification and geometry consistency for aerialway

[Klumbumbus]

Ticket #10914 has been marked as a duplicate of this ticket.

[Klumbumbus]

In 7927/josm:

see #10835 - icon unification and geometry consistency for whole facilities preset group

[aceman]

amenity=ice_cream has no preset, but has an icon if created as a node.

[Don-vip]

See 9125#comment:6

[Klumbumbus]

In 7940/josm:

see #10835 - icon unification for place=*

[Klumbumbus]

In 7942/josm:

see #10835 - icon unification and geometry consistency for some naturaltags. add validator warnings for some node features on ways

[Klumbumbus]

In 7950/josm:

see #10835 - icon unification and geometry consistency for some shop tags. add own icon for shop=alcohol

[rickmastfan67]

Some icons got broken in the [7950] changeset. Saw this in the CL in Windows 7 with the newest 'latest'.

ERROR: Failed to locate image 'styles/standard/shop/rental/library.png'
WARNING: Could not get presets icon styles/standard/shop/rental/library.png

[Klumbumbus]

In 7952/josm:

see #10835 - fix icon path

[Klumbumbus]

Replying to rickmastfan67:

Some icons got broken in the [7950] changeset.

Thanks. Fixed.

[Klumbumbus]

In 7953/josm:

see #10835 - new icon for shop=books

[Klumbumbus]

In 7960/josm:

see #10835 - icon unification and geometry consistency for some man_made, historic amd bridge tags.

[Klumbumbus]

In 7962/josm:

see #10835 - move deprecated icons to nodist, see [o30914]

[Klumbumbus]

In 7963/josm:

see #10835 - fix regression of r7960

[rickmastfan67]

Replying to Klumbumbus:

In 7960/josm:

see #10835 - icon unification and geometry consistency for some man_made, historic amd bridge tags.

Missed one. Saw this in the CL on startup of the new 'latest' r7963.

ERROR: Failed to locate image 'styles/standard/bridge/support.svg'
WARNING: Could not get presets icon styles/standard/bridge/support.svg

[Klumbumbus]

In 7964/josm:

see #10835 - fix typo

[Klumbumbus]

In 7967/josm:

see #10835 - icon unification and geometry consistency for some power tags. add validator warnings

[skyper]

Replying to Klumbumbus:

In 7967/josm:

see #10835 - icon unification and geometry consistency for some power tags. add validator warnings

Better use ​https://wiki.openstreetmap.org/wiki/Tag:power=substation#Switchgear and no redirects as redirects do not support languages and the wiki already includes four languages besides English.

[Klumbumbus]

Replying to skyper:

Better use ​https://wiki.openstreetmap.org/wiki/Tag:power=substation#Switchgear and no redirects as redirects do not support languages and the wiki already includes four languages besides English.

But this would also not work for russian and polish, since they do not have a heading "Switchgear". And if one day someone creates the page power=switchgear, we will likely not notice for the JOSM preset and change power=substation#Switchgear to power=switchgear.

[skyper]

Guess we do not get around in these cases to do the job manually for each language as the script to automatically check/include the links will fail here, too.

[Klumbumbus]

In 7975/josm:

see #10835 - icon unification and geometry consistency for some water related tags. add validator warnings

[Klumbumbus]

Replying to skyper:

Guess we do not get around in these cases to do the job manually for each language as the script to automatically check/include the links will fail here, too.

I think the script will override manual edits each time it is executed.

[Klumbumbus]

In 7977/josm:

see #10835 - icon unification and geometry consistency for some transport related tags (railway, aeroway,...). add validator warnings

[Klumbumbus]

In 7978/josm:

see #10835 - fix hangar

[Klumbumbus]

This is all I plan to do for now. Public transport is missing. I created an own ticket for this #11006.

Please report here or create new tickets, if you notice more inconsistecies between preset/mappaint/validator/wiki.

[bastiK]

Great work, thanks!

[skyper]

screenshot

[skyper]

Replying to Klumbumbus:

In 7960/josm:

see #10835 - icon unification and geometry consistency for some man_made, historic amd bridge tags.

Now the top panel icon for historic=* is to small compared to the rest and the space around historic=boundary_stone is less than all the other icons which looks somehow off.

[Klumbumbus]

Replying to skyper:

Now the top panel icon for historic=* is to small compared to the rest

I think this should better be handled by the JOSM code. It should upscale atleast svg icons in this case, maybe also png icons. There are some icon scaling related tickets in the next milestone. Please add a comment there. (ticket:10688#comment:7)
As this is a default toolbar icon and the scaling will not be fixed in 15.01 I try to upolad the icon at a default size of 32px again. I already planed to do it this way, but it didn't correct downscale to 16px in Mapview (seems some special svg incompatibility again).

and the space around historic=boundary_stone is less than all the other icons which looks somehow off.

This schould also be handled by the JOSM code. It should align the icons centered. Adding transparent or white space around the icons is no clean solution. Please also add a comment at another ticket for this problem. Btw, I didn't touch this icon. It was already this way probably since it was added to preset some day.

[skyper]

Ok, I did add my comments to #10688. Feel free to close this ticket again.

[Klumbumbus]

Replaced castle icon in [o30926] with a default size of 160px. This way scaling works as expected in toolbar and mapview.

[Klumbumbus]

In 7996/josm:

see #10835 - improve mappaint and validator for tourism=information

[Klumbumbus]

In 7997/josm:

see #10835 - own icon for generator:source=geothermal

[Klumbumbus]

In 8004/josm:

see #10835 - add icon for description=*

[Klumbumbus]

In 8009/josm:

see #10835 - update boundary preset and mappaint

[Klumbumbus]

In 8010/josm:

see #10835 - improve boundary preset, add maritime