Include icons in auto-created table of (external) plugin/style/preset/validator page

[skyper]

Would be nice if the icons would be included on the automatically created table of external components, similar to the GUI under preferences

[stoecker]

I don't understand what you want.

[Klumbumbus]

E.g. here: Styles/ one more column on the left with the icon of the style.

[stoecker]

Ah ok. Well. That's a lot of work. I'll see what I can do.

Didn't know that we have icons for the style, presets and validator rules now.

[stoecker]

Actually for the XML types icon does not yet exists :-)

[skyper]

Replying to stoecker:

Ah ok. Well. That's a lot of work. I'll see what I can do.

Well, then it should be on low priority.

[stoecker]

See r7593.

[Don-vip]

and r7594 after ​automatic build. I love Jenkins :)

[stoecker]

I thought before commit "Do you need to test it or is it easy enough". Well - now I know the answer :-)

[stoecker]

Ok. For external links the icons are now displayed (only Styles have some).

This does not mean to add external links to styles now to fix the others!

It simply means now the real work to extract the icons needs to be done - i.e. that "a lot of work part". This is a little more complicated than for plugins.

[Klumbumbus]

Replying to stoecker:

(only Styles have some).

Also Presets/StolpersteineLight has an external linked icon for example. It is in the <item> part. Does it also need to be outside of it?

[stoecker]

Replying to Klumbumbus:

Replying to stoecker:

(only Styles have some).

Also Presets/StolpersteineLight has an external linked icon for example. It is in the <item> part. Does it also need to be outside of it?

Yes. A global icon must be in <presets ... icon="..."> like all the other global informations.

[stoecker]

Note: also inline encoded "data:" is supported now, but needs a preliminary trac patch (​ticket:11773).

[stoecker]

External icons in zip files now also supported. Missing the wiki pages (i.e. the majority) and links to JOSM internal icons.

[stoecker]

In 7654/josm:

support data: style URL's for icon in plugin list, see #10581

[Klumbumbus]

I don't know what is wrong here. I changed the icon for Styles/Maxspeed to svg. It is no longer displayed in the list at Styles/ (list works again) and in JOSM. (I first uploaded the icon with (NOZIP) and later replaced it without (NOZIP).)

While for Styles/sac_scale the icon is displayed in the list but not in JOSM.

[Klumbumbus]

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-10-26 02:33:42
Last Changed Author: Klumbumbus
Revision: 7653
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-10-25 16:39:46 +0200 (Sat, 25 Oct 2014)
Last Changed Rev: 7653

Identification: JOSM/1.5 (7653 en) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (187 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=57535, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Program arguments: [--debug]

Plugins:
- DirectUpload (30737)
- HouseNumberTaggingTool (30762)
- OpeningHoursEditor (30737)
- PicLayer (30762)
- Tracer2 (30762)
- buildings_tools (30762)
- download_along (30762)
- editgpx (30737)
- imagery_offset_db (30762)
- measurement (30737)
- notes (v0.9.4)
- public_transport (30762)
- reltoolbox (30762)
- reverter (30737)
- tag2link (30719)
- terracer (30737)
- turnrestrictions (30762)
- undelete (30762)
- utilsplugin2 (30762)

Last errors/warnings:
- E: Failed to locate image 'maxspeed_icon.svg'
- W: Mappaint style "standard" (Höchstgeschwindigkeit) icon "maxspeed_icon.svg" not found.
- E: Failed to locate image 'sac_scale_icon.svg'
- W: Mappaint style "standard" (sac_scale) icon "sac_scale_icon.svg" not found.

[stoecker]

In 7655/josm:

support data: style URL's for icon in plugin list, see #10581, drop old style loading

[stoecker]

You need to remove the styles in JOSM and readd it, because your link still goes to the XML variant, whereas together with icon it is now ZIP. To prevent this in future all links to the wiki are now ZIP (saves also bandwidth).

[Klumbumbus]

Replying to stoecker:

You need to remove the styles in JOSM and readd it, because your link still goes to the XML variant, whereas together with icon it is now ZIP. To prevent this in future all links to the wiki are now ZIP (saves also bandwidth).

Thanks. Works now. I thought clearing the cache for this style would be enough.

[Klumbumbus]

Replying to stoecker:

You need to remove the styles in JOSM and readd it, because your link still goes to the XML variant, whereas together with icon it is now ZIP. To prevent this in future all links to the wiki are now ZIP (saves also bandwidth).

As you can see I still have missing icons and their warnings after some weeks.
I also saw some of these errors in other tickets (e.g. #10764, #10753, #10735)
The update should be an automatic task. Otherwise every user needs to remove and readd all styles manually, to get the icon!?

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-11-24 02:33:57
Last Changed Author: Don-vip
Revision: 7743
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-11-23 23:54:40 +0100 (Sun, 23 Nov 2014)
Last Changed Rev: 7743

Identification: JOSM/1.5 (7743 de) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (169 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=63678, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'josm_small.png'
- W: Mappaint style "standard" (JOSM default (XML; old version)) icon "josm_small.png" not found.
- E: Fehler beim Laden des Bildes 'error_small.png'
- W: Mappaint style "standard" (FIXME Highlight Warnings) icon "error_small.png" not found.

[stoecker]

Would require rewriting all the URL's of installed josm server presets and styles by adding "&zip=1" if not yet added. Probably a task for our config updater possibility.

[Don-vip]

move tickets that have not been treated this month to next milestone

[stoecker]

In 8100/josm:

fix #10581 - rewrite old URL's to JOSM server