Better OS X integration

[Don-vip]

Thanks to Stereo I have successfully setup a "Hackintosh" that finally allows me to test JOSM on OS X, in a virtual Machine, by following this guide:

​http://www.macbreaker.com/2014/05/os-x-mavericks-in-virtualbox-with-niresh.html

I find a lot minor issues that I'll try to fix through this ticket:

1. JOSM does not use OS X native LAF by default: fixed in r7480
2. 7u67: Hyperlinks do not work (left click) if Safari is still the default browser: mouse integration issue of VirtualBox
3. 7u67: Right click on hyperlinks do not copy the link to clipboard: idem
4. 7u67: Toggle dialogs do not collapse when we left-click on their title bar: idem
5. 7u67: The vertical toolbar is too wide: horizontal space wasted: fixed in r7483
6. 7u67: The horizontal status bar is too large: vertical space wasted: idem
7. 7u67: The icons in preferences dialog are ridiculously small. From ​documentation it is stated "JTabbedPane objects in OS X [...] have a standard size. If you put an image in a tab, the image is scaled to fit the tab instead of the tab to the image.": too complicated. Dialog will change with #7548.
8. 7u67: Java dock icon is displayed instead of JOSM one if launched with java -jar: fixed in r7485
9. 7u67: Restart does not work with OSX package: fixed in r7487
10. Icon paths are wrong in Info.plist: fixed in r7487
11. No fullscreen: fixed with #7021

12. We should use the ​Window-Modified Indicator (putClientProperty("Window.documentModified", Boolean.TRUE)): fixed in r7484

13. File dialogs not native: fixed with #10024:

Before:

After:

[Don-vip]

In 7483/josm:

see #10455 - cross-platform UI tuning to avoid waste of space with platform-dependant native layouts (seen on OS X)

[Don-vip]

In 7484/josm:

see #10455 - use OS X Window-Modified Indicator with Window.documentModified

[Don-vip]

It's too complicated (if not even impossible) to change the icons in preferences tab, they will stay as it until we change the dialog completely through #7548.

[Don-vip]

In 7485/josm:

see #10455 - OS X: show correct dock icon if run with java-jar

[mdk]

For the last open point (restart) may help this:

​Restarting Application using Applescript from Java

[Don-vip]

Thanks. I can't make it work yet but this may be useful as well: ​http://www.macdevcenter.com/pub/a/mac/2004/10/22/cocoa.html

[Don-vip]

In 7487/josm:

see #10455 - fix restart of OS X package + file icons

[Don-vip]

In 7539/josm:

fix #5957, fix #10458, see #10455: fix various focus/shortcuts issues:

• proper use of "Command" modifier on OS X instead of "Ctrl"
• fix related focus issue on OS X in layer list dialog (copy/paste between layers not working)
• fix non-working commands after a layer selection: Ctrl-A, Tab, Ctrl-Down/Up/Left/Right, F8
• fix impossibility to use 'A', 'S' or 'X' keys in relation filter or when renaming layer

[Don-vip]

In 7543/josm:

fix #9897, see #10455 - fix map moving issue when moving node with ctrl

[Don-vip]

In 7585/josm:

see #10024, see #10455 - use native file dialogs by default on OS X

[anonymous]

Great job. Those "tiny" issues can be really frustrating ! Thanks !

[M-Rick <m.rick@…>]

Since this new GUI? the Mac OS X version is definitely better !

But now we cannot save in the numerous formats supported by JOSM like in previous versions. For example, I am needing to save in JSON and it is not working, the file is save as OSM by defaut…

Should a small icon file could be created, because JSOM will attach the application icon instead.

[Don-vip]

You can, just uncheck the "use native dialogs" option in josm preferences.