Modify

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#10455 closed enhancement (fixed)

Better OS X integration

Reported by: Don-vip Owned by: Don-vip
Priority: normal Milestone: 14.09
Component: Core Version:
Keywords: macosx Cc: cquest, Stereo

Description (last modified by Don-vip)

Thanks to Stereo I have successfully setup a "Hackintosh" that finally allows me to test JOSM on OS X, in a virtual Machine, by following this guide:

http://www.macbreaker.com/2014/05/os-x-mavericks-in-virtualbox-with-niresh.html

I find a lot minor issues that I'll try to fix through this ticket:

  1. JOSM does not use OS X native LAF by default: fixed in r7480
  2. 7u67: Hyperlinks do not work (left click) if Safari is still the default browser: mouse integration issue of VirtualBox
  3. 7u67: Right click on hyperlinks do not copy the link to clipboard: idem
  4. 7u67: Toggle dialogs do not collapse when we left-click on their title bar: idem
  5. 7u67: The vertical toolbar is too wide: horizontal space wasted: fixed in r7483
  6. 7u67: The horizontal status bar is too large: vertical space wasted: idem
  7. 7u67: The icons in preferences dialog are ridiculously small. From documentation it is stated "JTabbedPane objects in OS X [...] have a standard size. If you put an image in a tab, the image is scaled to fit the tab instead of the tab to the image.": too complicated. Dialog will change with #7548.
  8. 7u67: Java dock icon is displayed instead of JOSM one if launched with java -jar: fixed in r7485
  9. 7u67: Restart does not work with OSX package: fixed in r7487
  10. Icon paths are wrong in Info.plist: fixed in r7487
  11. No fullscreen: fixed with #7021

http://support.apple.com/library/APPLE/APPLECARE_ALLGEOS/Product_Help/en_US/PUBLIC_USERS/133741/S0001_FullScreenEnter.png

  1. We should use the Window-Modified Indicator (putClientProperty("Window.documentModified", Boolean.TRUE)): fixed in r7484

https://developer.apple.com/library/mac/technotes/tn2007/images/tn2196_modified.png

  1. File dialogs not native: fixed with #10024:

https://developer.apple.com/library/mac/documentation/Java/Conceptual/Java14Development/art/awtfilechooser.jpg

Before:

After:

Attachments (4)

osx_before.png (362.4 KB) - added by Don-vip 4 years ago.
osx_after.png (305.5 KB) - added by Don-vip 4 years ago.
Capture d’écran 2015-01-18 à 00.55.42.png (29.7 KB) - added by M-Rick <m.rick@…> 3 years ago.
Capture d’écran 2015-01-18 à 00.55.59.png (17.7 KB) - added by M-Rick <m.rick@…> 3 years ago.

Download all attachments as: .zip

Change History (37)

comment:1 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:2 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:3 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:4 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:5 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:6 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:7 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:8 Changed 4 years ago by Don-vip

Description: modified (diff)

Changed 4 years ago by Don-vip

Attachment: osx_before.png added

comment:9 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:10 Changed 4 years ago by Don-vip

In 7483/josm:

see #10455 - cross-platform UI tuning to avoid waste of space with platform-dependant native layouts (seen on OS X)

comment:11 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:12 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:13 Changed 4 years ago by Don-vip

In 7484/josm:

see #10455 - use OS X Window-Modified Indicator with Window.documentModified

comment:14 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:15 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:16 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:17 Changed 4 years ago by Don-vip

It's too complicated (if not even impossible) to change the icons in preferences tab, they will stay as it until we change the dialog completely through #7548.

comment:18 Changed 4 years ago by Don-vip

In 7485/josm:

see #10455 - OS X: show correct dock icon if run with java-jar

comment:19 Changed 4 years ago by Don-vip

Description: modified (diff)

Changed 4 years ago by Don-vip

Attachment: osx_after.png added

comment:20 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:21 Changed 4 years ago by mdk

For the last open point (restart) may help this:

Restarting Application using Applescript from Java

comment:22 Changed 4 years ago by Don-vip

Thanks. I can't make it work yet but this may be useful as well: http://www.macdevcenter.com/pub/a/mac/2004/10/22/cocoa.html

comment:23 Changed 4 years ago by Don-vip

In 7487/josm:

see #10455 - fix restart of OS X package + file icons

comment:24 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:25 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:26 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

comment:27 Changed 4 years ago by Don-vip

In 7539/josm:

fix #5957, fix #10458, see #10455: fix various focus/shortcuts issues:

  • proper use of "Command" modifier on OS X instead of "Ctrl"
  • fix related focus issue on OS X in layer list dialog (copy/paste between layers not working)
  • fix non-working commands after a layer selection: Ctrl-A, Tab, Ctrl-Down/Up/Left/Right, F8
  • fix impossibility to use 'A', 'S' or 'X' keys in relation filter or when renaming layer

comment:28 Changed 4 years ago by Don-vip

In 7543/josm:

fix #9897, see #10455 - fix map moving issue when moving node with ctrl

comment:29 Changed 4 years ago by Don-vip

In 7585/josm:

see #10024, see #10455 - use native file dialogs by default on OS X

comment:30 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:31 Changed 4 years ago by anonymous

Great job. Those "tiny" issues can be really frustrating ! Thanks !

comment:32 Changed 3 years ago by M-Rick <m.rick@…>

Since this new GUI? the Mac OS X version is definitely better !

But now we cannot save in the numerous formats supported by JOSM like in previous versions. For example, I am needing to save in JSON and it is not working, the file is save as OSM by defaut…

Should a small icon file could be created, because JSOM will attach the application icon instead.

Changed 3 years ago by M-Rick <m.rick@…>

Changed 3 years ago by M-Rick <m.rick@…>

comment:33 Changed 3 years ago by Don-vip

You can, just uncheck the "use native dialogs" option in josm preferences.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.