Modify

Opened 6 years ago

Closed 5 years ago

#9897 closed defect (fixed)

Move map no longer works on OSX

Reported by: escada Owned by: team
Priority: blocker Milestone: 14.04
Component: Core Version: tested
Keywords: Cc: Stereo

Description

I've just downloaded josm.jpnl version 6950. I work on OSX 10.9.2
The ctrl-click to move the map no longer works. I just get the select rectangle.

The same problem was also reported by another user on the forum: http://forum.openstreetmap.org/viewtopic.php?id=24885

Attachments (3)

6950-webstart-java7.txt (55.1 KB) - added by escada 6 years ago.
Java 7 Webstart JOSM 6950
6891-java6.txt (54.4 KB) - added by escada 6 years ago.
Java 6 jar-file JOSM 6891
jar-java7-6950.txt (54.2 KB) - added by escada 6 years ago.
JOSM 6950 - Java 7 - jar file

Download all attachments as: .zip

Change History (39)

comment:1 Changed 6 years ago by bastiK

What was the last version that worked? Did you run it on the same system?

(Older JOSM versions can be downloaded here.)

comment:2 Changed 6 years ago by Don-vip

Owner: changed from team to escada
Status: newneedinfo

Please post your status report.

comment:3 Changed 6 years ago by anonymous

The last version that I used that worked was 6891. However, that was the application (thus not via Java Web Start) and was running under Java 6.
I was running that version on the same OS.

comment:4 in reply to:  2 Changed 6 years ago by bastiK

Replying to Don-vip:

Please post your status report.

It is good that you can restrict the problem to 6891-6950. Very little happened between these versions, that might have affected the mouse handling. This makes it more likely that the switch from Java 6 to Java 7 or the switch from the downloaded version to Java Web Start has caused the problem.

In any case, it would be nice to sort out this problem, in particular as you are not the only affected user.

Therefore could you please post a status report, as Don-vip requested? In addition, please download the *.jar file for JOSM 6950 and 6891 and try both versions again with Java 7. (See here InstallNotes in case you are having problems to start the *.jar file.)

Changed 6 years ago by escada

Attachment: 6950-webstart-java7.txt added

Java 7 Webstart JOSM 6950

Changed 6 years ago by escada

Attachment: 6891-java6.txt added

Java 6 jar-file JOSM 6891

Changed 6 years ago by escada

Attachment: jar-java7-6950.txt added

JOSM 6950 - Java 7 - jar file

comment:5 Changed 6 years ago by anonymous

I have the same problem with JOSM 6891 (downloaded the snapshot jar) under java 7. Do you need the status report for this as well ?
The OSX Java app 6891 running under Java 6 works fine.
jar 6891 also works fine under Java 6

comment:6 Changed 6 years ago by bastiK

Thanks for the reports. It seems that the JOSM version does not matter, neither the way you launch it (webstart, OSX app or jar file). But the way how ctrl+left mouse button is handled has changed in Java 7 compared to Java 6.

Could you please check if ctrl+click map move works in the Download dialog? Does the context menu pop up if you ctrl+click the main map with a TMS-layer (e.g. Bing) present?

comment:7 Changed 6 years ago by Don-vip

In 6957/josm:

see #9897 - refactor OSX stuff

comment:8 Changed 6 years ago by Don-vip

Milestone: 14.04

comment:9 Changed 6 years ago by anonymous

Could you please check if ctrl+click map move works in the Download dialog?

It doesn't.

Does the context menu pop up if you ctrl+click the main map with a TMS-layer (e.g. Bing) present?

It doesn't.

comment:10 Changed 6 years ago by escada

ctrl+click in the download dialog does not work neither.
As soon as I right+click on the main map with a TMS-layer, the help text for the selection appears in the bottom right. No context menu

comment:11 Changed 6 years ago by anonymous

A temporary workaround is to use the ^-arrow shortcuts to move the map.

comment:12 Changed 6 years ago by Stereo

Cc: Stereo added

comment:13 Changed 6 years ago by Don-vip

Owner: changed from escada to team
Status: needinfonew

comment:14 Changed 6 years ago by bastiK

In [6988] - debug output for #9897 (also in ​[o30403])

comment:15 Changed 6 years ago by bastiK

I've added some debugging output to investigate the problem. Please download version 6988 or later and start it with the --debug command line option.

$ java -jar josm-latest.jar --debug

Then open the Download dialog and try to move the map with the mouse, as if it would work. Report the command line output (the lines starting with (#9897). It should look something like this:

(#9897) DefaultMapController.mousePressed: Button 3 Modifiers: 1000000000000
(#9897) DefaultMapController.mouseDragged: Button 0 Modifiers: 1000000000000
(#9897) DefaultMapController.mouseDragged: Button 0 Modifiers: 1000000000000
(#9897) DefaultMapController.mouseDragged: Button 0 Modifiers: 1000000000000
(#9897) DefaultMapController.mouseDragged: Button 0 Modifiers: 1000000000000
(#9897) DefaultMapController.mouseDragged: Button 0 Modifiers: 1000000000000
(#9897) DefaultMapController.mouseReleased: Button 3 Modifiers: 100000000

Most important for Java 7, but also for Java 6, if it's not too much trouble.

comment:16 Changed 5 years ago by Stereo

This is [6988] on Java 7:

(#9897) DefaultMapController.mousePressed: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseReleased: Button 1 Modifiers: 10000000
(#9897) DefaultMapController.mousePressed: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseReleased: Button 1 Modifiers: 10000000
(#9897) DefaultMapController.mousePressed: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseReleased: Button 1 Modifiers: 10000000
(#9897) DefaultMapController.mousePressed: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) DefaultMapController.mouseReleased: Button 1 Modifiers: 10000000
Last edited 5 years ago by skyper (previous) (diff)

comment:17 Changed 5 years ago by bastiK

In [o30406], [6989]. Should work now, please try.

Last edited 5 years ago by Don-vip (previous) (diff)

comment:18 Changed 5 years ago by Don-vip

@Stereo, escada: is the problem fixed with latest version?

comment:19 Changed 5 years ago by Stereo

I've just tried the latest build, and it's, well, almost but not entirely not fixed. The map now moves, but the selection rectangle still appears.

comment:20 Changed 5 years ago by bastiK

In 6993/josm:
see #9897 - Move map no longer works on OSX (fix selection rectagle on map move)

comment:21 Changed 5 years ago by Don-vip

can you confirm it's working now?

comment:22 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

comment:23 Changed 5 years ago by Stereo

Resolution: fixed
Status: closedreopened

Sorry for the delay. I confirm it's still drawing the unwanted selection rectangle when ctrl-dragging the map in 6997/josm

comment:24 Changed 5 years ago by Stereo

If it helps, here is the debug output for a move.

(#9897) DefaultMapController.mousePressed: Button 1 Modifiers: 10010000000
(#9897) move start
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseDragged: Button 1 Modifiers: 10010000000
(#9897) moving
(#9897) DefaultMapController.mouseReleased: Button 1 Modifiers: 10000000
(#9897) move stop

comment:25 Changed 5 years ago by Don-vip

Do you have the same behaviour if you:

  • first press control key, then click & move mouse
  • first click, then press control key, then move mouse ?

comment:26 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 7000/josm:

fix #9897 - avoid unwanted rectangle painting when moving map on Mac OS X

comment:27 in reply to:  23 Changed 5 years ago by bastiK

Resolution: fixed
Status: closedreopened

Replying to Stereo:

Sorry for the delay. I confirm it's still drawing the unwanted selection rectangle when ctrl-dragging the map in 6997/josm

Thanks for the feedback! As I don't have access to a Mac, it takes a few iterations to get this right.

  • Do you get selection rectangle in the download dialog, when moving the map?
  • What about Draw nodes (A) map mode? Does it start a new line when you end the map movement?

comment:28 Changed 5 years ago by Stereo

Do you have the same behaviour if you:

  • first press control key, then click & move mouse
  • first click, then press control key, then move mouse ?

In the download dialog, I don't. The map isn't dragged when I click-ctrl. It is dragged when I ctrl-click. The rectangle is drawn in both cases.

In the map data display, the issue is solved. The map is dragged when I ctrl-click, and turns from a selection rectangle to a dragging pointer when I click-ctrl. In any case, it turns back into a normal pointer when I release ctrl but keep dragging, but I'm not sure what behaviour I would expect in this case anyway.

  • Do you get selection rectangle in the download dialog, when moving the map?

When ctrl-dragging in the download dialog, and, as you'd expect, when dragging with no modifier key in both the download dialog and the map data display.

comment:29 Changed 5 years ago by bastiK

In 7011/josm:

see #9897 - Move map no longer works on OSX (do not drag a rectangle when ctrl+left-click moving the map in download dialog)

comment:30 Changed 5 years ago by bastiK

Could you please check if the selection rectangle for ctrl-drag moving in download dialog is fixed in r7011?

I'm still interested in this:

  • What about Draw nodes (A) map mode? Does it start a new line when you end the map movement?

comment:31 Changed 5 years ago by cquest

In download dialog (under OSX 10.9.2, JOSM 7056):

  • clic+drag: select
  • ctrl+right-clic+drag: select + drag
  • right-clic+drag: drag

Same behavior with trackpad and a real mouse.

In draw mode (A):

  • right-click: it behaves normally (no node created).
  • ctrl-click: a node is created... :(

Another annoying "new" (at least back to version 7000) thing in the edit window: ctrl-drag used to "snap" objects to closest one, now it does drag the map (and try to snap too if you're close enough) :(

Last edited 5 years ago by cquest (previous) (diff)

comment:32 Changed 5 years ago by anonymous

What about Draw nodes (A) map mode? Does it start a new line when you end the map movement?

It doesn't start a new line, but it does draw a point when I ctrl-click to start dragging. It would be nice if ctrl-clicking just started dragging without adding a point.

(I'm not 100% sure I understood your question)

comment:33 in reply to:  31 ; Changed 5 years ago by bastiK

Hi cquest, thank you for taking the time and testing on OSX. Can you verify that in r6988 and earlier you had the same problems as described at the top of this ticket?

Replying to cquest:

In download dialog (under OSX 10.9.2, JOSM 7056):

  • clic+drag: select
  • ctrl+right-clic+drag: select + drag
  • right-clic+drag: drag

I may not understand correctly, but I thought that a regular Mac mouse has no right button and you instead use the single mouse button with Ctrl pressed. So what I really would be interested in is ctrl+click-drag.

What about Draw nodes (A) map mode? Does it start a new line when you end the map movement?

It doesn't start a new line, but it does draw a point when I ctrl-click to start dragging. It would be nice if ctrl-clicking just started dragging without adding a point.

Are you sure you don't get a rubber band after releasing Ctrl and mouse button (like you would if you click without Ctrl)?

Another annoying "new" (at least back to version 7000) thing in the edit window: ctrl-drag used to "snap" objects to closest one, now it does drag the map (and try to snap too if you're close enough) :(

You are right, the snapping should probably be turned off for OSX then, thanks for reporting the problem.

comment:34 in reply to:  33 Changed 5 years ago by anonymous

Replying to bastiK:

Hi cquest, thank you for taking the time and testing on OSX. Can you verify that in r6988 and earlier you had the same problems as described at the top of this ticket?

Replying to cquest:

In download dialog (under OSX 10.9.2, JOSM 7056):

  • clic+drag: select
  • ctrl+right-clic+drag: select + drag
  • right-clic+drag: drag

I may not understand correctly, but I thought that a regular Mac mouse has no right button and you instead use the single mouse button with Ctrl pressed. So what I really would be interested in is ctrl+click-drag.

Laptops have trackpads, which do provide "right click" (double finger click), so you can do ctrl+right-click
Desktops using apple mouse also provide right-click
I'm using a basic USB logitech mouse on my desktop, and the trackpad or same kind of mouse on my laptop.

ctrl-click-drag looks better in today's latest (7120) but not perfect.
When ctrl-click happens near an objet, it get selected and moved slightly which was not happening in past versions (like for example 6502).

After testing in both select (S) and add (A) modes, it looks like releasing the mouse (mouse-up) is acting like a mouse-down.

What about Draw nodes (A) map mode? Does it start a new line when you end the map movement?

It doesn't start a new line, but it does draw a point when I ctrl-click to start dragging. It would be nice if ctrl-clicking just started dragging without adding a point.

Are you sure you don't get a rubber band after releasing Ctrl and mouse button (like you would if you click without Ctrl)?

Another annoying "new" (at least back to version 7000) thing in the edit window: ctrl-drag used to "snap" objects to closest one, now it does drag the map (and try to snap too if you're close enough) :(

You are right, the snapping should probably be turned off for OSX then, thanks for reporting the problem.

This is not fixed in 7120.

comment:35 Changed 5 years ago by Stereo

I wanted to try to reproduce this, but am not even sure I can understand what the remaining bug is anymore. Cquest, if you can still reproduce unwanted behaviour, would opening a new ticket be ok with you?

comment:36 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 7543/josm:

fix #9897, see #10455 - fix map moving issue when moving node with ctrl

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.