Modify

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#10043 closed enhancement (fixed)

Improvements to the main map style after switching to MapCSS

Reported by: bastiK Owned by: team
Priority: normal Milestone: 14.06
Component: Internal mappaint style Version:
Keywords: Cc: skyper, simon04

Description

After the main mappaint style has been converted to MapCSS (see #9691), we can use the new options to improve it.

Please add your ideas, mapcss styles, patches, etc. below.

Attachments (2)

elemstyles7428_more_streetnames.mapcss (83.4 KB) - added by Klumbumbus 5 years ago.
names.png (17.3 KB) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (40)

comment:1 Changed 5 years ago by bastiK

Rough ideas:

  • repeat-image to draw cliffs as they appear in Mapnik (e.g. here)
  • housenumber rendering (#9357)
  • use zoom levels

comment:2 Changed 5 years ago by bastiK

from ticket #9691 by Klumbumbus:

When the migration is done, you could maybe think about replace the default maxspeed icon on nodes (which shows always 60 for every maxspeed value) by a dynamic display of the real maxspeed value. There was already a discussion some years ago in #5859. I think it is better to show the real value instead of always 60. The code which could be integrated in the elemstyle.mapcss could look like this:

node[maxspeed<100]::maxbg
{
	symbol-shape: circle;
	symbol-size: 18;
	symbol-fill-color: white;
}
node[maxspeed<100]::maxfg
{
	symbol-shape: circle;
	symbol-size: 16;
	symbol-stroke-color: crimson;
	symbol-stroke-width: 2;
	text: "maxspeed";
	font-size: 9;
	text-color: black;
	text-anchor-horizontal: center;
	text-anchor-vertical: center;
	text-offset-x: 0;
	text-offset-y: 0;
}
node[maxspeed>=100]::maxbg
{
	symbol-shape: circle;
	symbol-size: 20;
	symbol-fill-color: white;
}
node[maxspeed>=100]::maxfg
{
	symbol-shape: circle;
	symbol-size: 18;
	symbol-stroke-color: crimson;
	symbol-stroke-width: 2;
	text: "maxspeed";
	font-size: 9;
	text-color: black;
	text-anchor-horizontal: center;
	text-anchor-vertical: center;
	text-offset-x: 0;
	text-offset-y: 0;
}

comment:3 Changed 5 years ago by mkoniecz

#9319 Lines with higher layer value should be drawn on top of lines of lower layer value

comment:4 Changed 5 years ago by naoliv

Could leisure=swimming_pool have a blueish color, instead the current green color?

comment:5 Changed 5 years ago by skyper

Cc: skyper added

comment:6 Changed 5 years ago by Klumbumbus

Don't display the building icon on nodes for building=no Example

comment:7 Changed 5 years ago by bastiK

see #10044 - Bridges and tunnels are rendered in exactly the same way

comment:8 Changed 5 years ago by bastiK

In 7147/josm:

see #10043 - Don't display the building icon on nodes for building=no

comment:9 Changed 5 years ago by bastiK

In 7148/josm:

see #10043 - let leisure=swimming_pool have a blueish color, instead the current green color

comment:10 Changed 5 years ago by Don-vip

Milestone: 14.05

comment:11 Changed 5 years ago by Klumbumbus

Move the area styles of piste:difficulty=* from default layer also to "core_piste" layer (like piste way styles).

Then you can easily deactivate these styles from other mappaint styles (e.g. with area[piste:difficulty]:closed::core_piste {fill-opacity: 0;}) without to fear to break any other area fill color style in the default layer.

Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:12 Changed 5 years ago by skyper

How about #9144 ?

comment:13 Changed 5 years ago by skyper

Support cycleway:left/right=* and use casing. See #10057

comment:14 Changed 5 years ago by mkoniecz

#9258 display bicycle=yes; foot=designated; highway=path in default paint style

#9385 colour of arrows on oneway paths with bicycle=designated, foot=designated

I suggested "repeat-image to draw cliffs as they appear in Mapnik" as #9427

#9834 barrier=guard_rail is not rendered as barrier

comment:15 Changed 5 years ago by bastiK

In 7155/josm:

see #10043 - move the area styles of piste:difficulty=* from default layer to "core_piste" layer

comment:16 Changed 5 years ago by bastiK

In 7156/josm:

fixed #9427 - natural=cliff is not displaying that upper side is on left and lower on the right (see #10043)

comment:17 Changed 5 years ago by bastiK

In 7157/josm:

fixed #9834 - barrier=guard_rail is not rendered as barrier (see #10043)

comment:18 Changed 5 years ago by Klumbumbus

see #10064 - realwidth and priority in elemstyle.mapcss

comment:19 Changed 5 years ago by Don-vip

Cc: simon04 added

Paul, Simon, don't forget to update Help/Styles/MapCSSImplementation when adding new MapCSS functions :)

comment:20 Changed 5 years ago by Klumbumbus

see #10067 - elemstyle.mapcss: text is displayd twice because of text:auto of fixme

comment:21 Changed 5 years ago by naoliv

There is one problem with [7148]: if the area has only leisure=swimming_pool then it's properly displayed with a blue color.
However, if you also add sport=swimming, the color gets back to green.

comment:22 Changed 5 years ago by Klumbumbus

Should sport=swimming always have blue colour, also without leisure=swimming_pool?

comment:23 Changed 5 years ago by skyper

Found another one: #8869.

At least do not render both on the same spot.

comment:24 Changed 5 years ago by bastiK

In 7199/josm:

switch to correct mini_roundout icon in areas with left-hand traffic (see #10043)

comment:25 Changed 5 years ago by bastiK

In 7201/josm:

see #10057 - Better support for cycleway

comment:26 Changed 5 years ago by bastiK

In 7202/josm:

see #10043 - water color for sport=swimming

comment:27 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

comment:28 Changed 5 years ago by bastiK

In 7386/josm:

see #10043 - Mappaint: print name of street along residential

comment:29 Changed 5 years ago by bastiK

In 7390/josm:

see #10043 - more prominent label for place=*

comment:30 in reply to:  28 Changed 5 years ago by aceman

Replying to bastiK:

In 7386/josm:

see #10043 - Mappaint: print name of street along residential

There are also roads of class primary/secondary/tertiary with names inside cities (where they act instead of highway=residential). Should they also be shown? Or only when abutters is set on the ways?

Changed 5 years ago by Klumbumbus

Changed 5 years ago by Klumbumbus

Attachment: names.png added

comment:31 Changed 5 years ago by Klumbumbus

I also think that only residential is not the best way. I modified the style so the names for residential, living_street, motorway*, trunk*, primary*, secondary*, tertiary*, unclassified, service and track are shown. All with the halo color of the street. Since motorways and trunks often do not have names, but refs, the ref is shown. I think it looks nice. Try it out yourself.
Here is the modified style: elemstyles7428_more_streetnames.mapcss
What do you think?


Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:32 Changed 5 years ago by bastiK

In 7439/josm:

applied #10043 - render street name for more highway types (patch by Klumbumbus)

comment:33 Changed 5 years ago by bastiK

Yes, it looks nice, thanks Klumbumbus! (please add patch file next time, if possible)

Last edited 5 years ago by bastiK (previous) (diff)

comment:34 Changed 5 years ago by Klumbumbus

Name display for highway=pedestrian was added in [7457]

For maxspeed nodes see #10301
For zoom levels see #10363

comment:35 Changed 3 years ago by baditaflorin

Ability to show different colors per user

comment:36 in reply to:  35 ; Changed 3 years ago by naoliv

Replying to baditaflorin@…:

Ability to show different colors per user

What exactly do you mean/need here?

comment:37 in reply to:  36 ; Changed 3 years ago by skyper

Replying to naoliv:

Replying to baditaflorin@…:

Ability to show different colors per user

What exactly do you mean/need here?

How about an option to manually give a specific search/filter a colour ?

comment:38 in reply to:  37 Changed 3 years ago by Klumbumbus

Replying to skyper:

Replying to naoliv:

Replying to baditaflorin@…:

Ability to show different colors per user

What exactly do you mean/need here?

How about an option to manually give a specific search/filter a colour ?

Now discussed in #13661

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.