Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10067 closed defect (fixed)

elemstyle.mapcss: text is displayd twice because of text:auto of fixme

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 14.05
Component: Internal mappaint style Version:
Keywords: Cc:

Description

Look at this node in JOSM. It has addr:housenumber and fixme=* (because addr:street is not clear). With the new elemstyle.mapcss the housenumber is displayed twice, see screenshot:

I suggest either to remove the text from the fixme, because it is not needed, or to move the fixme from core_fixme layer to default layer. (The second one would also prevent to display the fixme icon together with other icons. I'm not sure if this is good or bad.)

Attachments (6)

fixme.png (2.2 KB) - added by Klumbumbus 5 years ago.
fixme2.png (2.9 KB) - added by Klumbumbus 5 years ago.
fixme with question mark.png (4.0 KB) - added by Klumbumbus 5 years ago.
fixme with question mark, big without icon.png (4.2 KB) - added by Klumbumbus 5 years ago.
fixme with question mark big without icon.png (4.2 KB) - added by Klumbumbus 5 years ago.
fixme result.png (8.4 KB) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (21)

Changed 5 years ago by Klumbumbus

Attachment: fixme.png added

Changed 5 years ago by Klumbumbus

Attachment: fixme2.png added

comment:1 Changed 5 years ago by Klumbumbus

I just tested some more icons. I think it would be the best to move fixme to default layer, because it looks ugly this way:

comment:2 Changed 5 years ago by bastiK

For the text, I agree.

Would you suggest to show only the icon or only the fixme symbol?

The idea with this overlay is, that you see the fixme tag immediately, but also the normal feature. What about a smaller symbol, slightly displaced from the center?

comment:3 in reply to:  2 Changed 5 years ago by Klumbumbus

Replying to bastiK:

For the text, I agree.

Would you suggest to show only the icon or only the fixme symbol?

only the fixme symbol

What about a smaller symbol, slightly displaced from the center?

That would also be a good solution. Currently it looks bad in my opinion, espacially for shop=curtain (down right in the example picture).

comment:4 Changed 5 years ago by skyper

How about a red circle (triangle) around the icon with a small, red f symbole on one side ?

I always hated the lack of information due to the missing icon for the main tag.

Changed 5 years ago by Klumbumbus

comment:5 Changed 5 years ago by Klumbumbus

I tried some styles with circle, square and triangle, but they all look not so good in combination with different icons. So my suggestion is now:


comment:6 in reply to:  5 ; Changed 5 years ago by skyper

Replying to Klumbumbus:

I tried some styles with circle, square and triangle, but they all look not so good in combination with different icons. So my suggestion is now:


Is it possible to only use it if there is an additional icon but leave it big and centered without additional icon ?

Changed 5 years ago by Klumbumbus

Changed 5 years ago by Klumbumbus

comment:7 in reply to:  6 ; Changed 5 years ago by Klumbumbus

(sorry, uploaded same picture twice; didnt know comma not supportet in [[Image()]].)

Replying to skyper:

Is it possible to only use it if there is an additional icon but leave it big and centered without additional icon ?

This way?


comment:8 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7173/josm:

fixed #10067 - elemstyle.mapcss: text is displayd twice because of text:auto of fixme

comment:9 Changed 5 years ago by bastiK

In [o30472].

Please try again, I also changed note=*.

Changed 5 years ago by Klumbumbus

Attachment: fixme result.png added

comment:10 Changed 5 years ago by Klumbumbus

The result:


comment:11 in reply to:  7 Changed 5 years ago by skyper

Replying to Klumbumbus:

Replying to skyper:

Is it possible to only use it if there is an additional icon but leave it big and centered without additional icon ?

This way?


Nice, that's what I had in mind. Logically the same is true for note=*.

comment:12 Changed 5 years ago by Klumbumbus

I think the solution from bastiK is good. If you want to display a big symbol if there is no other icon then we need big versions of the F and N annotation which can be displayed centered. I think using different symbols for the same thing would be bad (old and new fixme symbol and old and new note symbol).

comment:13 in reply to:  12 Changed 5 years ago by skyper

Replying to Klumbumbus:

I think the solution from bastiK is good. If you want to display a big symbol if there is no other icon then we need big versions of the F and N annotation which can be displayed centered. I think using different symbols for the same thing would be bad (old and new fixme symbol and old and new note symbol).

We should use .svg icons then.

comment:14 Changed 5 years ago by Klumbumbus

I don't know if you can put symbols on nodes displaced from the centre in mapcss. At least it is only documented for text at Help/Styles/MapCSSImplementation.

comment:15 in reply to:  6 Changed 5 years ago by bastiK

Replying to skyper:

Is it possible to only use it if there is an additional icon but leave it big and centered without additional icon ?

This is technically possible (with the caveat that it wouldn't work well with a second style file that overrides some icons). I tried both options and decided that the current solution looks more consistent.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.