Modify

Opened 6 years ago

Closed 5 years ago

#9144 closed defect (fixed)

Always treat multipolygons as area

Reported by: skyper Owned by: team
Priority: normal Milestone: 14.05
Component: Internal mappaint style Version: latest
Keywords: multipolygon area Cc:

Description

Multipolygons should be always treated as areas despite being tagged with area=*.

Just try public_transport=platform or any highway=* without area=yes.

Attachments (0)

Change History (12)

comment:1 Changed 5 years ago by bastiK

In 7154/josm:

see #9144 - Always treat multipolygons as area

comment:2 Changed 5 years ago by bastiK

I suggest to remove the general style for area=yes. The style should come from additional tags that have a concrete meaning.

comment:3 Changed 5 years ago by aceman

But area=yes/no can modify the specific tags' meaning. So it should be rendered visibly that highway=pedestrian+area=yes is different from highway=pedestrian. Or leisure=track+area=no different from leisure=track.

Also, I've created some polygons just having area=yes+surface=*, those getting the nice filled in style. What is the right way to tag those, when it is not some specific object, just concrete or sandy surface on the ground?

comment:4 in reply to:  1 ; Changed 5 years ago by skyper

Replying to bastiK:

In 7154/josm:

see #9144 - Always treat multipolygons as area

Why did you change the rendering for public_transport=platform closed ways ? They are always an area.

Replying to bastiK:

I suggest to remove the general style for area=yes. The style should come from additional tags that have a concrete meaning.

+1

In 95% the geometry is enough and a polygon is an area. area=yes might be needed only in rare cases and even for highway=* area:highway=* was proposed. I would say area=no would be the appropriate tag to mark a polygon which is no area.

Replying to aceman:

But area=yes/no can modify the specific tags' meaning. So it should be rendered visibly that highway=pedestrian+area=yes is different from highway=pedestrian. Or leisure=track+area=no different from leisure=track.

Also, I've created some polygons just having area=yes+surface=*, those getting the nice filled in style. What is the right way to tag those, when it is not some specific object, just concrete or sandy surface on the ground?

How about landcover=* with out any area=*.

comment:5 Changed 5 years ago by bastiK

In 7159/josm:

see #9144 - remove generic style for area=yes. refinements for tags where area=yes/no is meaningful

comment:6 Changed 5 years ago by bastiK

In 7160/josm:

see #9144 - another small fix

comment:7 in reply to:  4 Changed 5 years ago by bastiK

Replying to skyper:

Why did you change the rendering for public_transport=platform closed ways ? They are always an area.

I've changed it back.

Replying to bastiK:

I suggest to remove the general style for area=yes. The style should come from additional tags that have a concrete meaning.

+1

In 95% the geometry is enough and a polygon is an area. area=yes might be needed only in rare cases and even for highway=* area:highway=* was proposed. I would say area=no would be the appropriate tag to mark a polygon which is no area.

Done. We should now handle each tag separately if area=yes/no impacts the styling.

comment:8 in reply to:  3 ; Changed 5 years ago by bastiK

Replying to aceman:

But area=yes/no can modify the specific tags' meaning. So it should be rendered visibly that highway=pedestrian+area=yes is different from highway=pedestrian. Or leisure=track+area=no different from leisure=track.

Should work now, please note all tags that require special handling.

Also, I've created some polygons just having area=yes+surface=*, those getting the nice filled in style. What is the right way to tag those, when it is not some specific object, just concrete or sandy surface on the ground?

Perhaps add a style that visualizes surface? There are several in the repository. :)

comment:9 in reply to:  8 Changed 5 years ago by anonymous

Replying to bastiK:

Replying to aceman:

But area=yes/no can modify the specific tags' meaning. So it should be rendered visibly that highway=pedestrian+area=yes is different from highway=pedestrian. Or leisure=track+area=no different from leisure=track.

Should work now, please note all tags that require special handling.

I am not sure why there would be only some tags where area=yes/no would be meaningful. On the wiki there is no distinction, only the defaults are listed. But those defaults can be overriden in either way. So even landuse=*+area=no should be possible even though that really is probably not very useful. But maybe somebody find a use :) So the handling should be universal and allow all combinations as the theory says.

comment:10 Changed 5 years ago by Don-vip

Milestone: 14.05

comment:11 Changed 5 years ago by bastiK

In 7161/josm:

see #9144 - don't match area base selector for primitives with tag area=no

comment:12 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

area=no should now work universally.

For area=yes, the question is whether a generic light gray is really that helpful.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.