Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10044 closed enhancement (fixed)

Bridges and tunnels are rendered in exactly the same way [patch]

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.06
Component: Internal mappaint style Version:
Keywords: Cc: Klumbumbus

Description (last modified by mkoniecz)

Maybe at least different shades of blue? Or brown for tunnels?

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-05-11 01:36:45
Last Changed Author: bastiK
Revision: 7105
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-05-11 01:48:28 +0200 (Sun, 11 May 2014)
Last Changed Rev: 7105

Identification: JOSM/1.5 (7105 en) Windows 7 32-Bit
Memory Usage: 73 MB / 247 MB (34 MB allocated, but free)
Java version: 1.7.0_55, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30416)
Plugin: RoadSigns (30438)
Plugin: buildings_tools (30416)
Plugin: continuosDownload (28565)
Plugin: lakewalker (30416)
Plugin: measurement (30416)
Plugin: notes (v0.9.2)
Plugin: wikipedia (30416)

Attachments (5)

example.osm (2.3 KB ) - added by mkoniecz 10 years ago.
example of situation where it would be useful
pl2-tunnel_and_bridge.png (13.1 KB ) - added by bastiK 10 years ago.
Brown tunnel.PNG (36.6 KB ) - added by mkoniecz 10 years ago.
with patch
tunnel.diff (343 bytes ) - added by mkoniecz 10 years ago.
patch
Blue tunnel.PNG (33.7 KB ) - added by mkoniecz 10 years ago.
without patch

Download all attachments as: .zip

Change History (18)

by mkoniecz, 10 years ago

Attachment: example.osm added

example of situation where it would be useful

comment:1 by mkoniecz, 10 years ago

Description: modified (diff)

comment:2 by bastiK, 10 years ago

Component: Core mappaintInternal mappaint style

comment:3 by Don-vip, 10 years ago

@Bulwersator: some clarification on our components:

  • Core mappaint: involves Java changes in the process of rendering data (example: we add a new feature to MapCSS support)
  • Internal mappaint style: updating the default map style to change colors, icons, so on

comment:4 by mkoniecz, 10 years ago

Thanks, I will now tag it correctly.

by bastiK, 10 years ago

Attachment: pl2-tunnel_and_bridge.png added

comment:5 by bastiK, 10 years ago

PL2 style:

I guess a dashed line of some kind makes sense for a tunnel.

comment:6 by Klumbumbus, 10 years ago

Cc: Klumbumbus added

comment:7 by bastiK, 10 years ago

Some suggestions would be welcome (image or style).

comment:8 by skyper, 10 years ago

Think I would prefer little color change and keeping the side for other stuff.

  • darker for bridges and lighter for tunnels
    • only problem is with white highways which can not be displayed lighter.
  • have a concave/convex half circle at the end nodes.

in reply to:  8 comment:9 by Klumbumbus, 10 years ago

Replying to skyper:

  • have a concave/convex half circle at the end nodes.

This is maybe not perfect for long tunnels like way/200282918 because you need to zoom out far to see if it is a tunnel or not.
There is also a problem if the tunnel is splitted like the tunnel from above and way/200399876. There would be two half circles at the split point.

comment:10 by mkoniecz, 10 years ago

I finally tested my idea with brown tunnels and IMHO it works. I will attach patch, how example works with it and without it.

by mkoniecz, 10 years ago

Attachment: Brown tunnel.PNG added

with patch

by mkoniecz, 10 years ago

Attachment: tunnel.diff added

patch

by mkoniecz, 10 years ago

Attachment: Blue tunnel.PNG added

without patch

comment:11 by mkoniecz, 10 years ago

Summary: Bridges and tunnels are rendered in exactly the same wayBridges and tunnels are rendered in exactly the same way [patch]

comment:12 by bastiK, 10 years ago

Resolution: fixed
Status: newclosed

In 7255/josm:

applied #10044 Bridges and tunnels are rendered in exactly the same way (based on patch by Bulwersator)

comment:13 by Don-vip, 10 years ago

Milestone: 14.06

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.