Modify

Opened 7 years ago

Last modified 4 years ago

#9819 new defect

stricter checking for highways crossing waterways without bridges

Reported by: RicoZ Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: crossing layer bridge tunnel Cc: Penegal

Description

Currently many mappers tag whole rivers with layer=-1 because it is an easy way to avoid validator warnings of the type "highway crossing waterway".

Enhance the check so that keepright warns whenever a highway crosses a waterway where there is no bridge or tunnel even if the layer is different. A layer tag itself does not make a valid crossing.

This has been discussed in the wiki ( https://wiki.openstreetmap.org/wiki/Talk:Key:layer#layer.3D-1_erroneously_used_for_many_italian_rivers ) and previously the update to https://wiki.openstreetmap.org/wiki/Key:layer has been discussed in the mailing list ( https://lists.openstreetmap.org/pipermail/talk/2014-March/069219.html )

Related but more general: #9182

Attachments (1)

nowarn.osm (358.7 KB) - added by ssprunk 4 years ago.
example of missing crossing ways warnings

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by mkoniecz

It may be more general - with multiple crossing highway=* with different layers no more than one should be without tunnel=*/bridge=*

comment:2 Changed 4 years ago by ssprunk

I agree it should be stricter. However, even the basic checking appears to be broken now; I removed layer=-1 from several waterways near me, resulting in dozens of same-layer crossings, yet I still get no warnings. I know it worked a few months ago because I spent hours fixing all the warnings I got (in a different part of town).

comment:3 Changed 4 years ago by RicoZ

@ssprunk: I believe this warning message was reclassified to "info" message so you may need to enable it explicitly. There were just too many of them and many are unfixable without local knowledge but were annoying and repeatedly prompted users to hide the messages by adding layer=-1 to whole rivers. Running in circles.

comment:4 in reply to:  3 ; Changed 4 years ago by ssprunk

@RicoZ: I enabled "info" messages and still didn't get anything. I did get one "warning" yesterday, but only one; there were dozens of bad crossings in the current layer. High-res satellite (available everywhere I map) is enough to decide bridge vs culvert, so I had no problem quickly fixing hundreds of other problems before the warnings disappeared a while back.

comment:5 in reply to:  4 ; Changed 4 years ago by skyper

Replying to ssprunk:

@RicoZ: I enabled "info" messages and still didn't get anything. I did get one "warning" yesterday, but only one; there were dozens of bad crossings in the current layer. High-res satellite (available everywhere I map) is enough to decide bridge vs culvert, so I had no problem quickly fixing hundreds of other problems before the warnings disappeared a while back.

Did you make sure to run validator manually and on the whole data layer (nothing selected) ?
Please upload an example file where validator is not producing any warning or info about the two crossing ways. Thanks

Changed 4 years ago by ssprunk

Attachment: nowarn.osm added

example of missing crossing ways warnings

comment:6 in reply to:  5 ; Changed 4 years ago by ssprunk

Replying to skyper:

Did you make sure to run validator manually and on the whole data layer (nothing selected) ?
Please upload an example file where validator is not producing any warning or info about the two crossing ways. Thanks

Yes, I did it with nothing selected (or all selected). I've uploaded a file (nowarn.osm) that has lots of crossings that should warn but don't; it took me a while to find some I hadn't already fixed. Confirmed again that it doesn't warn, even with such a small dataset.

comment:7 in reply to:  6 ; Changed 4 years ago by Klumbumbus

Replying to ssprunk:

Yes, I did it with nothing selected (or all selected). I've uploaded a file (nowarn.osm) that has lots of crossings that should warn but don't; it took me a while to find some I hadn't already fixed. Confirmed again that it doesn't warn, even with such a small dataset.

Atm JOSM doesn't warn for crossing ways if a layer tag is present. However in your attached file for the most of crossings there is neither a layer tag nor a bridge/tunnel tag. These are reported by validator. I get 39 warnings about crossing highway/waterway. If it doesn't warn for you check the following

  • use the newest stable version of JOSM
  • check all the checkboxes at the validator preferences
  • check that the file ignorederrors in your JOSM preference folder is empty

comment:8 in reply to:  7 ; Changed 4 years ago by ssprunk

Replying to Klumbumbus:

  • check that the file ignorederrors in your JOSM preference folder is empty

Doh! That was it, thanks. It finds most of the problems now, including where someone put bridge=* or tunnel=* with no layer=*, but I'm guessing (back to the original point) it's still missing cases where there is a layer=* with no bridge=* or tunnel=*.

comment:9 in reply to:  8 ; Changed 4 years ago by skyper

Replying to ssprunk:

(back to the original point) it's still missing cases where there is a layer=* with no bridge=* or tunnel=*.

#11256 seems to be a duplicate, then.

comment:10 Changed 4 years ago by Klumbumbus

Ticket #11256 has been marked as a duplicate of this ticket.

comment:11 in reply to:  9 Changed 4 years ago by Klumbumbus

Replying to skyper:

Replying to ssprunk:

(back to the original point) it's still missing cases where there is a layer=* with no bridge=* or tunnel=*.

#11256 seems to be a duplicate, then.

yes

comment:12 Changed 4 years ago by skyper

Cc: Penegal added

comment:13 Changed 4 years ago by skyper

Keywords: crossing layer bridge tunnel added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to RicoZ
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.