Opened 11 years ago
Closed 10 years ago
#9208 closed enhancement (fixed)
add building=supermarket to presets, consider building=supermarket as a building
Reported by: | jphilipz | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 15.05 |
Component: | Internal preset | Version: | |
Keywords: | building | Cc: |
Description (last modified by )
- would like to suggest the addition of the building drop down in the supermarket preset, because if the supermarket is drawn as a way, it will not be rendered as a building without a building entry.
2. public buildings seem to be incorrectly presetted as stated in the wiki. < http://wiki.openstreetmap.org/wiki/Tag:amenity%3Dpublic_building > Duplicate of #8978
Attachments (0)
Change History (23)
comment:1 by , 11 years ago
comment:3 by , 11 years ago
Keywords: | building added |
---|
comment:4 by , 11 years ago
Description: | modified (diff) |
---|---|
Summary: | preset issues - supermarket, public building → preset : add building to supermarket |
Type: | defect → enhancement |
follow-up: 17 comment:5 by , 11 years ago
As a more general enhancement, we could automatically set building=yes
for shops/amenities/… if they are applied to a closed way. And refrain from doing that on nodes.
In addition, supermarket ways without building=yes
should be identified by the validator as "Area style way without building=yes".
What do you think?
comment:6 by , 11 years ago
I like it, with these remarks:
a closed way
... without any existing "building=*" tag of course
"Area style way without building=yes"
+1 on the idea but not on the wording. "Area style way" can be a landuse or a natural land. But I'm bad at proposing better wordings :(
comment:7 by , 11 years ago
Milestone: | → 14.02 |
---|
comment:8 by , 11 years ago
Milestone: | 14.02 → 14.03 |
---|
comment:9 by , 11 years ago
Milestone: | 14.03 → 14.04 |
---|
comment:11 by , 11 years ago
Milestone: | 14.05 |
---|
comment:13 by , 11 years ago
Summary: | preset : add building to supermarket → add building=supermarket to presets, consider building=supermarket as a building |
---|
comment:15 by , 10 years ago
Milestone: | → 15.05 |
---|
follow-up: 19 comment:16 by , 10 years ago
I do not agree with adding building=supermarket. The wiki page is empty so you do not know when to use that tag. So it is undocumented. Then, why is building=retail not enough for shop=supermarket? Values of "civic" and "public" are used much more and at least have wiki descriptions and those were not added to JOSM.
comment:17 by , 10 years ago
Replying to simon04:
As a more general enhancement, we could automatically set
building=yes
for shops/amenities/… if they are applied to a closed way. And refrain from doing that on nodes.
Beware that some amenities should not be put on the building itself, but the area around the buildings. So you would again have to maintain some list of which amenities are of which type.
comment:18 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:19 by , 10 years ago
Replying to aceman:
I do not agree with adding building=supermarket. The wiki page is empty so you do not know when to use that tag. So it is undocumented. Then, why is building=retail not enough for shop=supermarket?
building=* describes the building type. So building=supermarket is a building, which was built as a supermarket. (typical for the architecture of those buildings are special entrances for custumors and delivery with ramp for hgv and often only one level) building=retail is fine for a supermarket aswell. building=supermarket is a bit more precise than building=retail.
comment:20 by , 10 years ago
"why is building=retail not enough for shop=supermarket" - because shop=retail includes everything from a huge mall to a kiosk and more. building=supermarket is more specific and represents relatively well-defined type of buildings.
comment:21 by , 10 years ago
Sure, please link to the discussion where the "well-defined"ness was agreed upon and then put the definition on the wiki. Thanks.
comment:22 by , 10 years ago
This is fixed for now. Remember that the value of building
is not such an "important" tag and is not meant to replace e.g. shop=supermarket
. This tag was used nearly 5000 times and spread worldwide even without an extended wiki page or a josm preset. So I think the community agreed on this. The wiki page for shop=supermarket was improved. For building=civic|public, we have other tickets: #8708, #8978
comment:23 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Replying to ypharis@…:
-1, fix the renderer and do not tag for renderers. See also my comment on #9203.
+1