Separate string values in entrance preset from the highway service preset

[aceman]

The "entrance" key has values like "main", "service", "emergency". These mix with other similar values (e.g. highway=service). These need to be separated (context) for proper translation.

[skyper]

Thought the strings are different so far and you always translate whole strings but gonna have a look at it once more.

Do you have a problem translating in a specific language or did you simply scan the file ?

[aceman]

I have seen JOSM latest pick up translation of "service" that is for the highway=service value. It can not be used (in our language) for "entrance" because it does not match the label in the dialog.

In launchpad I see:
service
item "Highways/Streets/Roundabout" combo "Type" display value
item "Ways/Cycle Lane" combo "Highway" display value
item "Man Made/Man Made/Entrance" combo "Entrance" display value

main
item "Transport/Railway/Rail" combo "Usage" display value
item "Transport/Railway/Narrow Gauge Rail" combo "Usage" display value
item "Man Made/Man Made/Entrance" combo "Entrance" display value

Also, can you tell me why launchpad shows colors (e.g. "color service") as if they are to be translated? Is that correct? It appears to me as if those should be keywords (e.g. to be stored as preferences in some config file).

[AlfonZ]

Replying to aceman:

Also, can you tell me why launchpad shows colors (e.g. "color service") as if they are to be translated? Is that correct? It appears to me as if those should be keywords (e.g. to be stored as preferences in some config file).

These are named colors picked up from internal map paint style (e.g. elemstyles.xml#L507). They will show up in Colors preferences, in this case Paint style standard: service.

[stoecker]

@aceman:
When you have string conflicts, please tell us exactly which meanings collide with which. We need to add contexts to some of them, but to reduce the burden for other translators, we add contexts only when really necessary. So please tell us, which meanings are grouped correctly and which conflict. We cannot add contexts everywhere, so be as verbose as possible and we decide how to fix the issue. Also tell us what language you translate.

[aceman]

All my bugs were filed against the Slovak language.
I have listed the 2 specific words that I spotted. But I am not keen on filing a new ticket for each word I encounter.
I actually think you should add context to all lists unless the same list is duplicated in several presets and with the same label. That could fix all issues once and for all. Waiting for bug reports and randomly adding contexts when any localizers notice something may actually increase the work for localizers as already translated words are untranslated again just due to adding context. If they had a context from the start on, this would not happen.

[aceman]

Replying to AlfonZ:

These are named colors picked up from internal map paint style (e.g. elemstyles.xml#L507). They will show up in Colors preferences, in this case Paint style standard: service.

Thanks, I see them now in the Preferences panel. But you see a problem right there: Paint style standard: service is nonsense. What is 'service'? This should be 'service road' straight in the English original, or at least have a context 'color' so that the translator can make sense of it (know it is for the Preferences dialog where the "road" word will not be, in opposite to the "service" in the highway preset) and translate it better for the user (as Service road). Something you try to do for piste.* colors.

[stoecker]

Replying to aceman:

But I am not keen on filing a new ticket for each word I encounter.

You don't need to. Use one and the same ticket like this one.

Waiting for bug reports and randomly adding contexts when any localizers notice something may actually increase the work for localizers as already translated words are untranslated again just due to adding context. If they had a context from the start on, this would not happen.

It would mean we drop about 20000 to 40000 of already existing translations and increase the string count from 8.000 to 10.000 and still would not catch all cases. I had to work with software which used this all-contexts concept and I wont do the same - it's awful to translate one and the same string dozens of time without need.

[aceman]

That is exactly what I say:) Now is probably too late. But for new groups/lists, context could be added from the start on, so no re-translation is needed in the future.

[stoecker]

A said I contributed to software using that approach. It is awful as well. I prefer ours. We anyway invalidate about 100 strings each release due to slight changes.

[aceman]

I think this approach causes more invalidations than my proposal. But I am new to JOSM (but not to translating projects), maybe I'll see your point in the future. So do as you wish.
So please fix these specific strings here:

Split "service" into 3 for each of:
item "Highways/Streets/Roundabout" combo "Type" display value

item "Ways/Cycle Lane" combo "Highway" display value

item "Man Made/Man Made/Entrance" combo "Entrance" display value

Split "main" for these 2 groups:
item "Transport/Railway/Rail" combo "Usage" display value
item "Transport/Railway/Narrow Gauge Rail" combo "Usage" display value

item "Man Made/Man Made/Entrance" combo "Entrance" display value

Split "industrial" for these 2 groups:
item "Transport/Railway/Rail" combo "Usage" display value
item "Transport/Railway/Narrow Gauge Rail" combo "Usage" display value

item "Man Made/Man Made/Building" combo "Building" display value

[AlfonZ]

Replying to aceman:

Split "service" into 3 for each of:
item "Highways/Streets/Roundabout" combo "Type" display value

item "Ways/Cycle Lane" combo "Highway" display value

item "Man Made/Man Made/Entrance" combo "Entrance" display value

Both Highways/Streets/Roundabout and Ways/Cycle Lane refer to highway=service. I'm just wondering if they really need to be separated.
Also, there is already one service with context Highway (​http://translations.launchpad.net/josm/trunk/+pots/josm/sk/3957/+translate). Could one of them be assigned there?

[aceman]

For your information, the reason of my problems is that in our language the translation depends on context. We have gender suffixes, time suffixes (past, future tense), context suffixes, etc.
And sometimes even if 2 objects are called the same in English they are called differently in our language, as it has evolved.

So if I see in a dialog "Highway: service" and "Entrance: service" then we translate "service" differently in each context. As I do not see the preceding label while editing the .po file it is sometimes hard to guess. But thank you for the comments of the form [item "Highways/Streets/Roundabout" combo "Type" display value] so I can at least start JOSM and see that dialog (if I can guess how to get to the dialog).

So yes, I'll verify the roundabout and cycle lane case again by checking the real dialog.

[AlfonZ]

There is also reference list of source lines, from which the text was taken.
For ​context-less service it currently says

build/trans_presets.java:719
build/trans_presets.java:887
build/trans_presets.java:4722
build/trans_style.java:507
build/trans_style.java:3861
...

build/trans_presets.java refers to the internal presets, build/trans_style.java refers to the internal map paint style, line numbers match.

[stoecker]

In 6256/josm:

see #9094 - add context to some keys

[skyper]

Replying to stoecker:

In 6256/josm:

see #9094 - add context to some keys

Shit, forgot to mention that this is/was included in #9029. Did not upload before going out for supper and need to rework. - Damm

[aceman]

OK, I have checked out the roundabout preset. It is unfortunate that the first label there is a generic "Type", that is shared with a ton of other dialogs. Probably that was to mean "Type of road", not "Type of roundabout". But anyway, it seems you are lucky and all the strings in this dialog (e.g. "service") are lowercased so I can translate them with this dialog in mind (as they are only used here) and different from the uppercase variants (Service) that are used in other presets as titles.
So I take back this one request for now (until it clashes with some other use later:)) The patch as posted is everything needed for this ticket. Thanks.

[skyper]

Is this fixed ?

[stoecker]

Milestone renamed