Modify

Opened 6 years ago

Last modified 5 months ago

#8933 new defect

External presets / rules: Update does not work

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: update preset validator rules Cc: naoliv, Klumbumbus

Description

I did update wiki:Presets/LaneAttributes yesterday and today I did not get the updated version.

  • I did manually update the list under preferences
  • I did remove the old version, restart, add the new version and restart

Both did not work.

Only after manually deleting the cache file, I was able to get the new version.

Please, make it possible to update the presets within the preferences.

Thanks

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-04 01:35:11
Last Changed Author: Don-vip
Revision: 6111
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-04 02:49:28 +0200 (Sun, 04 Aug 2013)
Last Changed Rev: 6111

Identification: JOSM/1.5 (6111 en) Linux Debian GNU/Linux 7.1 (wheezy)
Memory Usage: 124 MB / 592 MB (86 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u25-2.3.10-1~deb7u1

Plugin: OpeningHoursEditor (29778)
Plugin: conflation (0.1.6)
Plugin: jts (29613)
Plugin: mirrored_download (29753)
Plugin: notes (0.3)
Plugin: openstreetbugs (29435)
Plugin: reverter (29771)
Plugin: undelete (29555)
Plugin: utilsplugin2 (29771)
Plugin: wikipedia (29778)

Attachments (1)

external_update.patch (22.0 KB) - added by taylor.smock 5 months ago.
Refactor the preferences pane to have a generic update panel (plugin updates still work, now there are options for (unimplemented) updates for validators, should be easy to copy over to the mappaint styles).

Download all attachments as: .zip

Change History (20)

comment:1 Changed 5 years ago by Don-vip

Ticket #9615 has been marked as a duplicate of this ticket.

comment:2 Changed 5 years ago by Don-vip

Cc: naoliv added
Keywords: validator rules added
Milestone: 14.02
Summary: External preset: Update does not workExternal presets / rules: Update does not work

comment:3 Changed 5 years ago by Don-vip

Milestone: 14.0214.03

comment:4 Changed 5 years ago by francois.lacombe

+1 for fixing this problem.
I've encountered the problem last night with styles and presets rules.

An idea would be to let users set their own caching lifetime in advanced parameters or even to follow cache lifetime of the http request for loading external presets or styles.
Currently, no way to load updated presets and styles without deleting the cache record in AppData directory.

comment:5 Changed 5 years ago by Don-vip

Milestone: 14.0314.04

comment:6 Changed 5 years ago by Don-vip

Milestone: 14.0414.05

This defect is here for ages it can wait next release to minimize the risk of regression in our last Java 6 version.

Last edited 5 years ago by Don-vip (previous) (diff)

comment:7 Changed 5 years ago by Don-vip

Milestone: 14.0514.06

comment:8 Changed 5 years ago by Don-vip

Milestone: 14.0614.07

Move all tickets for which no work has been done yet to next milestone

comment:9 Changed 5 years ago by Don-vip

Milestone: 14.0714.08

Move some tickets to next milestone

comment:10 Changed 5 years ago by Don-vip

Milestone: 14.08

comment:11 Changed 5 years ago by francois.lacombe

Hi Don-vip, why did you delete this ticket from 14.08 milestone ?

I would love looking for a solution for this real problem.
I don't even know where to start.

comment:12 Changed 5 years ago by Don-vip

I know this problem is real, unless I would have closed the ticket.
Problem is: it's not that simple, I'd like to rework the entire update feature to have something coherent between all extensions (plugins, styles, imagery sources, presets, validator rules).
This is no easy task and it will take some time I currently don't have, so instead of reporting this ticket from milestone to milestone I prefer to remove it to have cleaner milestones.
I'll add it to another milestone when I will have a better idea of how we can fix this.

comment:13 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:14 Changed 5 years ago by Klumbumbus

from the duplicate ticket #9615:
watch-modified: true; is used in a lot styles. Has this any purpose? Or did just everyone copy from each other? :)
I can't find any documentation about this.

comment:15 Changed 4 years ago by Klumbumbus

Ticket #11876 has been marked as a duplicate of this ticket.

comment:16 Changed 4 years ago by Klumbumbus

Ticket #11868 has been marked as a duplicate of this ticket.

comment:17 Changed 4 years ago by Klumbumbus

Ticket #11961 has been marked as a duplicate of this ticket.

comment:18 Changed 4 years ago by Polarbear-j

Didn't spot the cache files when looking first, since they clutter themselves with very long filenames.

Preset cache files should have their own folder in the cache directory.

Changed 5 months ago by taylor.smock

Attachment: external_update.patch added

Refactor the preferences pane to have a generic update panel (plugin updates still work, now there are options for (unimplemented) updates for validators, should be easy to copy over to the mappaint styles).

comment:19 Changed 5 months ago by taylor.smock

I'll continue working on this patch, but I figured that it would be worthwhile to get some feedback before I spend time implementing some form of update functionality for mappaint/validator.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to skyper
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.