Modify

Opened 11 years ago

Last modified 15 months ago

#8933 new defect

External presets / rules / styles: Update does not work

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: update external preset validator rule style cache Cc: naoliv, Klumbumbus, Gisbert, Patrik_B

Description

I did update wiki:Presets/LaneAttributes yesterday and today I did not get the updated version.

  • I did manually update the list under preferences
  • I did remove the old version, restart, add the new version and restart

Both did not work.

Only after manually deleting the cache file, I was able to get the new version.

Please, make it possible to update the presets within the preferences.

Thanks

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-08-04 01:35:11
Last Changed Author: Don-vip
Revision: 6111
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-08-04 02:49:28 +0200 (Sun, 04 Aug 2013)
Last Changed Rev: 6111

Identification: JOSM/1.5 (6111 en) Linux Debian GNU/Linux 7.1 (wheezy)
Memory Usage: 124 MB / 592 MB (86 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u25-2.3.10-1~deb7u1

Plugin: OpeningHoursEditor (29778)
Plugin: conflation (0.1.6)
Plugin: jts (29613)
Plugin: mirrored_download (29753)
Plugin: notes (0.3)
Plugin: openstreetbugs (29435)
Plugin: reverter (29771)
Plugin: undelete (29555)
Plugin: utilsplugin2 (29771)
Plugin: wikipedia (29778)

Attachments (1)

external_update.patch (22.0 KB ) - added by taylor.smock 5 years ago.
Refactor the preferences pane to have a generic update panel (plugin updates still work, now there are options for (unimplemented) updates for validators, should be easy to copy over to the mappaint styles).

Download all attachments as: .zip

Change History (32)

comment:1 by Don-vip, 10 years ago

Ticket #9615 has been marked as a duplicate of this ticket.

comment:2 by Don-vip, 10 years ago

Cc: naoliv added
Keywords: validator rules added
Milestone: 14.02
Summary: External preset: Update does not workExternal presets / rules: Update does not work

comment:3 by Don-vip, 10 years ago

Milestone: 14.0214.03

comment:4 by francois.lacombe, 10 years ago

+1 for fixing this problem.
I've encountered the problem last night with styles and presets rules.

An idea would be to let users set their own caching lifetime in advanced parameters or even to follow cache lifetime of the http request for loading external presets or styles.
Currently, no way to load updated presets and styles without deleting the cache record in AppData directory.

comment:5 by Don-vip, 10 years ago

Milestone: 14.0314.04

comment:6 by Don-vip, 10 years ago

Milestone: 14.0414.05

This defect is here for ages it can wait next release to minimize the risk of regression in our last Java 6 version.

Last edited 10 years ago by Don-vip (previous) (diff)

comment:7 by Don-vip, 10 years ago

Milestone: 14.0514.06

comment:8 by Don-vip, 10 years ago

Milestone: 14.0614.07

Move all tickets for which no work has been done yet to next milestone

comment:9 by Don-vip, 10 years ago

Milestone: 14.0714.08

Move some tickets to next milestone

comment:10 by Don-vip, 10 years ago

Milestone: 14.08

comment:11 by francois.lacombe, 10 years ago

Hi Don-vip, why did you delete this ticket from 14.08 milestone ?

I would love looking for a solution for this real problem.
I don't even know where to start.

comment:12 by Don-vip, 10 years ago

I know this problem is real, unless I would have closed the ticket.
Problem is: it's not that simple, I'd like to rework the entire update feature to have something coherent between all extensions (plugins, styles, imagery sources, presets, validator rules).
This is no easy task and it will take some time I currently don't have, so instead of reporting this ticket from milestone to milestone I prefer to remove it to have cleaner milestones.
I'll add it to another milestone when I will have a better idea of how we can fix this.

comment:13 by Klumbumbus, 10 years ago

Cc: Klumbumbus added

comment:14 by Klumbumbus, 10 years ago

from the duplicate ticket #9615:
watch-modified: true; is used in a lot styles. Has this any purpose? Or did just everyone copy from each other? :)
I can't find any documentation about this.

comment:15 by Klumbumbus, 9 years ago

Ticket #11876 has been marked as a duplicate of this ticket.

comment:16 by Klumbumbus, 9 years ago

Ticket #11868 has been marked as a duplicate of this ticket.

comment:17 by Klumbumbus, 9 years ago

Ticket #11961 has been marked as a duplicate of this ticket.

comment:18 by Polarbear-j, 9 years ago

Didn't spot the cache files when looking first, since they clutter themselves with very long filenames.

Preset cache files should have their own folder in the cache directory.

by taylor.smock, 5 years ago

Attachment: external_update.patch added

Refactor the preferences pane to have a generic update panel (plugin updates still work, now there are options for (unimplemented) updates for validators, should be easy to copy over to the mappaint styles).

comment:19 by taylor.smock, 5 years ago

I'll continue working on this patch, but I figured that it would be worthwhile to get some feedback before I spend time implementing some form of update functionality for mappaint/validator.

comment:20 by nathhad, 4 years ago

Is any current consideration still being given to this issue?

I'm working on a preset that's hosted on an independent server, and this issue makes it a lot more cumbersome for my beta testers to update when I've made a fix. I've spent more time explaining how to delete the cache file and update the preset in JOSM than I've needed to spend actually explaining the preset (which I suppose is a good thing for my preset, but nonetheless).

I know it would be lovely to have a nice, global solution for this ... but it would be a whole lot more expedient to add one button to the right of the installed preset list that forces a delete and reload of the selected preset. It might be simpler to implement, and might get this issue resolved more quickly than anything else ...

Thanks!

comment:21 by taylor.smock, 4 years ago

I am, unfortunately, working on other things.

There is a workaround, which is why I haven't been focused on this particular bug/feature request.

I'll look into rebasing the patch I have. But I'll probably have to significantly rework it. I never got around to hooking up actual (manual) update functionality for mapcss validators.

comment:22 by nathhad, 4 years ago

Thanks!

I wish I had time to learn enough Java to help solve it myself (not my language and I'm rusty on the things that are), but I've already taken on too many projects, too. The constant trouble with volunteer projects, only so many of us to volunteer!

comment:23 by skyper, 4 years ago

Keywords: external rule style added; rules removed
Summary: External presets / rules: Update does not workExternal presets / rules / styles: Update does not work

comment:24 by skyper, 4 years ago

Ticket #20093 has been marked as a duplicate of this ticket.

comment:25 by skyper, 4 years ago

Cc: Gisbert added

comment:26 by skyper, 4 years ago

Keywords: cache added

comment:27 by Klumbumbus, 4 years ago

How to update a cached presets/rules/styles in JOSM see e.g. wiki:/Styles#UpdatingstylesinJOSM

comment:28 by Don-vip, 3 years ago

Ticket #20144 has been marked as a duplicate of this ticket.

comment:29 by skyper, 21 months ago

Ticket #22465 has been marked as a duplicate of this ticket.

comment:30 by skyper, 15 months ago

Ticket #22866 has been marked as a duplicate of this ticket.

comment:31 by skyper, 15 months ago

Cc: Patrik_B added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to skyper.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.