Erorr if Measurementdialog was undocked while closing JOSM

[plaicy]

1. Start JOSM
2. Create new datalayer
3. Open MeasurementDialog
4. Undock MeasurementDialog
5. Close JOSM

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.7.0
Created-By: 11.2-b01 (Sun Microsystems Inc.)
Main-class: JOSM
Main-Version: 1986 SVN
Main-Date: 2009-08-20T16:15:05.263127Z
Memory Usage: 11 MB / 254 MB (3 MB allocated, but free)
Java version: 1.6.0_12

Plugins: measurement
Plugin measurement Version: 16801

java.lang.NullPointerException

at org.openstreetmap.josm.gui.dialogs.ToggleDialog$3.actionPerformed(ToggleDialog.java:169)
at org.openstreetmap.josm.gui.dialogs.ToggleDialog$5.run(ToggleDialog.java:235)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:597)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

[plaicy]

see also #3307 and #3316. I have created separate ticks because it has to be changed in each plugin. Otherwise undock status will not be restored correctly.

[Gubaer]

fixed in r1999

[pert]

This problem, although not the exception, is still present in version 2005.

Undock MeasurementDialog loses the window completely so the Measurement plugin can then no longer be
used. Not possible to "redock" without editing ./josm/preferences.

So only a partial fix as yet. Changeset 1999 fixed the exception but not the underlying problem?
Thus reopening...

================================ info ==========================
Path: trunk
URL: ​http://josm.openstreetmap.de/svn/trunk
Repository Root: ​http://josm.openstreetmap.de/svn
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 2005
Node Kind: directory
Last Changed Author: Gubaer
Last Changed Rev: 2005
Last Changed Date: 2009-08-29 15:51:00 +0200 (Sat, 29 Aug 2009)

Memory Usage: 38 MB / 63 MB (15 MB allocated, but free)
Java version: 1.6.0_14

Plugins: AgPifoJ
DirectUpload
editgpx
measurement
validator
Plugin AgPifoJ Version: 17363
Plugin DirectUpload Version: 16583
Plugin editgpx Version: 16793
Plugin measurement Version: 16801
Plugin validator Version: 17352

agpifoj.bounds=62,275,694,672
agpifoj.minimized=true
agpifoj.visible=true
audio.menuinvisible=true
cache.motd.html=1251658560
cache.motd.html.lang=En_GB:
cache.motd.html.version=2005
color.way=#33FF99
commandstack.visible=true
coordinates=DECIMAL_DEGREES
download.gps=false
download.newlayer=true
download.osm=true
draw.rawgps.direction=true
draw.rawgps.large=true
draw.rawgps.lines.force=true
draw.rawgps.max-line-length=40
draw.rawgps.max-line-length.local=30
gui.geometry=1150x863+130+0
josm.version=2005
laf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
lastAddAuthor=false
lastDirectory=/fs1/home/ael/mapping/27-8-2009
layerlist.visible=true
marker.audiofromstart=false
marker.buttonlabels=false
marker.traceaudio=false
measure.docked=false
measure.visible=true
mirror.http://josm.openstreetmap.de/presets=1251658662862;/home/ael/.josm/mirror_http___josm.openstreetmap.de_presets
mirror.http://josm.openstreetmap.de/styles=1251658662554;/home/ael/.josm/mirror_http___josm.openstreetmap.de_styles
mirror.http://svn.openstreetmap.org/applications/editors/josm/plugins/validator/ignoretags.cfg=1251394846296;/home/ael/.josm/plugins/validator/mirror_http___svn.openstreetmap.org_applications_editors_josm_plugins_validator_ignoretags.cfg
mirror.http://svn.openstreetmap.org/applications/editors/josm/plugins/validator/tagchecker.cfg=1251394846406;/home/ael/.josm/plugins/validator/mirror_http___svn.openstreetmap.org_applications_editors_josm_plugins_validator_tagchecker.cfg
mirror.http://svn.openstreetmap.org/applications/utils/planet.osm/java/speller/words.cfg=1251394846103;/home/ael/.josm/plugins/validator/mirror_http___svn.openstreetmap.org_applications_utils_planet.osm_java_speller_words.cfg
osm-download.bounds=51.804410390862;-1.4995315020462665;51.832693067451075;-1.4698616642076
osm-server.url=​http://www.openstreetmap.org/api
pluginmanager.lastupdate=1251658692363
plugins=AgPifoJ
DirectUpload
editgpx
measurement
validator
projection=org.openstreetmap.josm.data.projection.Epsg4326
propertiesdialog.visible=true
proxy.anonymous=false
proxy.enable=false
relationlist.visible=false
save.keepbackup=false
selectionlist.visible=true
shortcut.groups.1=128
shortcut.groups.10=64
shortcut.groups.11=576
shortcut.groups.12=64
shortcut.groups.13=512
shortcut.groups.15=640
shortcut.groups.16=640
shortcut.groups.17=576
shortcut.groups.18=512
shortcut.groups.19=128
shortcut.groups.2=128
shortcut.groups.20=512
shortcut.groups.3=0
shortcut.groups.4=512
shortcut.groups.5=0
shortcut.groups.6=512
shortcut.groups.8=192
shortcut.groups.9=192
shortcut.groups.configured=true
tagimages.doublegpstimezone=1.0
tagimages.gpstimezone=-1
tagimages.lastdirectory=/fs1/home/ael/mapping/27-8-2009
upload.comment.history=Local name added
Extrememly muddy/rocky/wet bridleway to Swanhall farm completed
Footpaths around Delly End
Ashtree Farm (lane), GPS passive station near Buckland, minor adjustments based on all public traces.
Minor tweaks
Small adjustments - Ramsden Heath area
Small adjustments + name for Skippett Lane after extra trace.
Corrected dangling way
Side road/track + pond: MT Skippett
Corrected misplaced way: Mt Skippett
Pond at Bridewell Farm: very approximate.
Added missing tag on path. Changed well tag to man_made=well_water which is awkward but seems to be best from wiki as of now.
Paths around Bridewell Farm
Bridewell itself (presumably) and path from Wilcote
Other road in Finstock Heath
userlist.visible=true
validator.tests=Coastlines=true,SimilarNamedWays=true,UntaggedNode=true,CrossingWays=true,NodesWithSameName=true,TagChecker=true,OverlappingWays=true,UnclosedWays=true,WronglyOrderedWays=true,UnconnectedWays=true,SelfIntersectingWay=true,DuplicatedWayNodes=true,UntaggedWay=true,DuplicateNode=true
validator.testsBeforeUpload=Coastlines=true,SimilarNamedWays=true,UntaggedNode=true,CrossingWays=true,NodesWithSameName=true,TagChecker=true,OverlappingWays=true,UnclosedWays=true,WronglyOrderedWays=true,UnconnectedWays=true,SelfIntersectingWay=true,DuplicatedWayNodes=true,UntaggedWay=true,DuplicateNode=true
validator.visible=false

==============================================================

[Gubaer]

Should be fixed in r2021