[PATCH] Fix Sonar issues in recent Grid Layer and OAuth

[DanProgs <Abenteurer.2901@…>]

see: https://josm.openstreetmap.de/sonar/project/issues?inNewCodePeriod=true&issueStatuses=OPEN%2CCONFIRMED&open=a456f556-6642-4372-80da-08660fc46217&id=josm

[wangi]

Attached is a patch against r19646.

The deprecated URL constructor in OsmConnectionTest came from my patch for #24925. While I was looking at it I noticed that the other Sonar issues in the new code period also come from my grid patch (#8464, r19640), so this patch fixes those as well. It clears every issue in that list except the four S1309 ones about the existing PMD suppressions.

#24925 (this ticket)

• OsmConnectionTest: new URL(…) → URI.create(…).toURL() (S1874)

#8464 grid

• MapFrame.gridOverlay, ShowTileBordersAction.layer and GridPreference.TranslatedRenderer.name are now transient (S1948).
• AlignGridRotationAction.getSelectedDirection() returns a shared EMPTY_DIRECTION constant instead of null (S1168). The callers and GridActionsTest now check the length. This is the same change as #24949, and the constant is taken from that patch, thanks DanProgs. This patch also updates the other two assertNull checks on getSelectedDirection() in GridActionsTest. The #24949 patch only changes the first, so the test would fail with it.
• GridPreference: GBC.HORIZONTAL/GBC.BOTH → GridBagConstraints.HORIZONTAL/BOTH (S3252)
• MapGridPaintable.getLatLonGridLines(): the meridian loop is moved out into addMeridian(), to go with the existing addParallel(). This brings the cognitive complexity down from 19 to under 15 (S3776).
• MapGridPaintable.mapView: volatile → AtomicReference (S3077)
• MapGridPaintable.projectionUnitsPerMetre(): removed the unnecessary (ILatLon) cast (S1905)
• S1940 "use <=": the !(x > 0) checks were written that way on purpose so that NaN gets rejected too, and a plain x <= 0 would let NaN through. They now call a small isPositive() helper in MapGridPaintable. In GridPreference, where the value is parsed from user input, the check is Double.isNaN(value) || value <= 0. The one in addParallel() never sees NaN, so it is simply maxLon <= minLon.

There is no change in behaviour. GridActionsTest, MapGridPaintableTest, ShowTileBordersActionTest, TileSourceDisplaySettingsTest, GridPreferenceTest and OsmConnectionTest all pass, and checkstyle and ant pmd report nothing in the changed files.

[DanProgs <Abenteurer.2901@…>]

Please also take ticket #24949 into account in this context. It includes the change to new EastNorth[0] adapted by 'wangi', but implemented as a static constant named EMPTY_DIRECTION. Perhaps you could adjust this as well?

[wangi]

Ticket #24949 has been marked as a duplicate of this ticket.

[wangi]

Replying to DanProgs <Abenteurer.2901@…>:

Please also take ticket #24949 into account in this context. It includes the change to new EastNorth[0] adapted by 'wangi', but implemented as a static constant named EMPTY_DIRECTION. Perhaps you could adjust this as well?

Patch and comment above updated. I've also closed off 24949 as duplicate now.

[stoecker]

In 19654/josm:

fix #24951 - Fix Sonar issues in recent Grid Layer and OAuth - patches by DanProgs & wangi

[stoecker]

In 19655/josm:

fix #24951 - Fix Sonar issues in recent Grid Layer and OAuth - patches by DanProgs & wangi